Skip to content

Commit b3e2f00

Browse files
committed
patch 7.4.1256
Problem: On Mac sys.exit(0) doesn't kill the test server. Solution: Use self.server.shutdown(). (Jun Takimoto)
1 parent 66624ff commit b3e2f00

File tree

2 files changed

+7
-4
lines changed

2 files changed

+7
-4
lines changed

src/testdir/test_channel.py

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -98,7 +98,8 @@ def handle(self):
9898
response = last_eval
9999
elif decoded[1] == '!quit!':
100100
# we're done
101-
sys.exit(0)
101+
self.server.shutdown()
102+
break
102103
elif decoded[1] == '!crash!':
103104
# Crash!
104105
42 / 0
@@ -127,14 +128,14 @@ class ThreadedTCPServer(socketserver.ThreadingMixIn, socketserver.TCPServer):
127128
server_thread = threading.Thread(target=server.serve_forever)
128129

129130
# Exit the server thread when the main thread terminates
130-
server_thread.daemon = True
131131
server_thread.start()
132132

133133
# Write the port number in Xportnr, so that the test knows it.
134134
f = open("Xportnr", "w")
135135
f.write("{}".format(port))
136136
f.close()
137137

138-
# Block here
139138
print("Listening on port {}".format(port))
140-
server.serve_forever()
139+
140+
# Main thread terminates, but the server continues running
141+
# until server.shutdown() is called.

src/version.c

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -742,6 +742,8 @@ static char *(features[]) =
742742

743743
static int included_patches[] =
744744
{ /* Add new patch number below this line */
745+
/**/
746+
1256,
745747
/**/
746748
1255,
747749
/**/

0 commit comments

Comments
 (0)