refactor: Remove NimbleRowReaderOptions, use RowReaderOptions::setIndexEnabled() (facebookincubator#443)

Summary:
Pull Request resolved: facebookincubator#443

The `NimbleRowReaderOptions` class was only used to control the `indexEnabled` flag for Nimble row readers. Since `RowReaderOptions` already has `setIndexEnabled()` and `indexEnabled()` methods, we can simplify the code by removing the Nimble-specific options class and using the common `RowReaderOptions` API directly.

This change:
- Removes the `NimbleRowReaderOptions` class and its header file
- Updates `SelectiveNimbleReader` to read `indexEnabled` directly from `RowReaderOptions`
- Updates all call sites to use `rowReaderOptions.setIndexEnabled()` instead of creating `NimbleRowReaderOptions`

Reviewed By: zzhao0

Differential Revision: D91557015

fbshipit-source-id: c574651eb5e840bacf1bb86b7a081cdb8d845a8e

Author: xiaoxmeng

dwio/nimble/velox/selective/NimbleRowReaderOptions.h

@@ -22,7 +22,6 @@
 
 #include "dwio/nimble/velox/SchemaUtils.h"
 #include "dwio/nimble/velox/selective/ColumnReader.h"
-#include "dwio/nimble/velox/selective/NimbleRowReaderOptions.h"
 #include "dwio/nimble/velox/selective/ReaderBase.h"
 #include "dwio/nimble/velox/selective/RowSizeTracker.h"
 #include "velox/common/base/RuntimeMetrics.h"
@@ -384,12 +383,9 @@ void SelectiveNimbleRowReader::initIndexBounds() {
     return;
   }
 
-  // Check if index filtering is disabled via format-specific options
-  if (auto nimbleOptions = std::dynamic_pointer_cast<NimbleRowReaderOptions>(
-          options_.formatSpecificOptions())) {
-    if (!nimbleOptions->indexEnabled()) {
-      return;
-    }
+  // Check if index filtering is disabled.
+  if (!options_.indexEnabled()) {
+    return;
   }
 
   // Verify that the file has a cluster index

dwio/nimble/velox/selective/SelectiveNimbleReader.cpp

@@ -18,7 +18,6 @@
 
 #include "dwio/nimble/encodings/PrefixEncoding.h"
 #include "dwio/nimble/velox/VeloxWriter.h"
-#include "dwio/nimble/velox/selective/NimbleRowReaderOptions.h"
 #include "dwio/nimble/velox/selective/SelectiveNimbleReader.h"
 #include "velox/common/base/RandomUtil.h"
 #include "velox/common/base/RuntimeMetrics.h"
@@ -298,10 +297,8 @@ class E2EIndexTestBase : public ::testing::Test {
     auto scanSpec = createScanSpec(requestedType, filtersCopy);
     rowReaderOptions.setScanSpec(std::move(scanSpec));
 
-    // Set format-specific options to control index.
-    auto nimbleOptions = std::make_shared<NimbleRowReaderOptions>();
-    nimbleOptions->setIndexEnabled(indexEnabled);
-    rowReaderOptions.setFormatSpecificOptions(std::move(nimbleOptions));
+    // Set index enabled option.
+    rowReaderOptions.setIndexEnabled(indexEnabled);
 
     // Set up a stat writer to capture runtime stats.
     TestRuntimeStatWriter statWriter;
@@ -3268,9 +3265,7 @@ TEST_P(E2EIndexTest, filterRestorationAcrossMultipleSplits) {
   RowReaderOptions rowReaderOptions;
   rowReaderOptions.setRequestedType(rowType);
   rowReaderOptions.setScanSpec(scanSpec);
-  auto nimbleOptions = std::make_shared<NimbleRowReaderOptions>();
-  nimbleOptions->setIndexEnabled(true);
-  rowReaderOptions.setFormatSpecificOptions(std::move(nimbleOptions));
+  rowReaderOptions.setIndexEnabled(true);
 
   auto rowReader = reader->createRowReader(rowReaderOptions);