Use variable helm_release_history_size to set how much helm releases to store instead of hardcoding the value.

mglotov · mglotov · commit caaf034a3f5b · 2021-04-27T22:38:43.000+06:00
diff --git a/terraform/layer2-k8s/eks-aws-node-termination-handler.tf b/terraform/layer2-k8s/eks-aws-node-termination-handler.tf
@@ -5,7 +5,7 @@ resource "helm_release" "aws_node_termination_handler" {
   repository  = local.helm_repo_eks
   namespace   = kubernetes_namespace.sys.id
   wait        = false
-  max_history = "3"
+  max_history = var.helm_release_history_size
 
   values = [
     file("${path.module}/templates/aws-node-termination-handler-values.yaml")
diff --git a/terraform/layer2-k8s/eks-cert-manager.tf b/terraform/layer2-k8s/eks-cert-manager.tf
@@ -21,7 +21,7 @@ resource "helm_release" "cert_manager" {
   namespace   = kubernetes_namespace.certmanager.id
   version     = var.cert_manager_version
   wait        = true
-  max_history = "3"
+  max_history = var.helm_release_history_size
 
   values = [
     data.template_file.cert_manager.rendered,
diff --git a/terraform/layer2-k8s/eks-certificate.tf b/terraform/layer2-k8s/eks-certificate.tf
@@ -12,7 +12,7 @@ resource "helm_release" "certificate" {
   chart       = "../../helm-charts/certificate"
   namespace   = module.ing_namespace.name
   wait        = false
-  max_history = "3"
+  max_history = var.helm_release_history_size
 
   values = [
     data.template_file.certificate.rendered,
diff --git a/terraform/layer2-k8s/eks-cluster-autoscaler.tf b/terraform/layer2-k8s/eks-cluster-autoscaler.tf
@@ -24,7 +24,7 @@ resource "helm_release" "cluster_autoscaler" {
   repository  = local.helm_repo_cluster_autoscaler
   version     = var.cluster_autoscaler_chart_version
   namespace   = kubernetes_namespace.sys.id
-  max_history = "3"
+  max_history = var.helm_release_history_size
 
   values = [
     data.template_file.cluster_autoscaler.rendered,
diff --git a/terraform/layer2-k8s/eks-cluster-issuer.tf b/terraform/layer2-k8s/eks-cluster-issuer.tf
@@ -13,7 +13,7 @@ resource "helm_release" "cluster_issuer" {
   chart       = "../../helm-charts/cluster-issuer"
   namespace   = kubernetes_namespace.certmanager.id
   wait        = false
-  max_history = "3"
+  max_history = var.helm_release_history_size
 
   values = [
     data.template_file.cluster_issuer.rendered,
diff --git a/terraform/layer2-k8s/eks-external-dns.tf b/terraform/layer2-k8s/eks-external-dns.tf
@@ -24,7 +24,7 @@ resource "helm_release" "external_dns" {
   repository  = local.helm_repo_bitnami
   version     = var.external_dns_version
   namespace   = kubernetes_namespace.dns.id
-  max_history = "3"
+  max_history = var.helm_release_history_size
 
   values = [
     data.template_file.external_dns.rendered,
diff --git a/terraform/layer2-k8s/eks-external-secrets.tf b/terraform/layer2-k8s/eks-external-secrets.tf
@@ -21,7 +21,7 @@ resource "helm_release" "external_secrets" {
   repository  = local.helm_repo_external_secrets
   version     = var.external_secrets_version
   namespace   = kubernetes_namespace.sys.id
-  max_history = "3"
+  max_history = var.helm_release_history_size
 
   values = [
     data.template_file.external_secrets.rendered,
@@ -35,7 +35,7 @@ resource "helm_release" "reloader" {
   version     = var.reloader_version
   namespace   = kubernetes_namespace.sys.id
   wait        = false
-  max_history = "3"
+  max_history = var.helm_release_history_size
 }
 
 #module "aws_iam_wp_external_secrets" {
diff --git a/terraform/layer2-k8s/eks-kube-prometheus-stack.tf b/terraform/layer2-k8s/eks-kube-prometheus-stack.tf
@@ -41,7 +41,7 @@ resource "helm_release" "prometheus_operator" {
   namespace   = kubernetes_namespace.monitoring.id
   version     = var.prometheus_operator_version
   wait        = false
-  max_history = "3"
+  max_history = var.helm_release_history_size
 
   values = [
     local.kube_prometheus_stack_template
diff --git a/terraform/layer2-k8s/eks-loki-stack.tf b/terraform/layer2-k8s/eks-loki-stack.tf
@@ -18,7 +18,7 @@ resource "helm_release" "loki_stack" {
   namespace   = kubernetes_namespace.monitoring.id
   version     = var.loki_stack
   wait        = false
-  max_history = "3"
+  max_history = var.helm_release_history_size
 
   values = [
     local.loki_stack_template
diff --git a/terraform/layer2-k8s/eks-network-policy.tf b/terraform/layer2-k8s/eks-network-policy.tf
@@ -3,12 +3,13 @@ data "template_file" "calico_daemonset" {
 }
 
 resource "helm_release" "calico_daemonset" {
-  name       = "aws-calico"
-  chart      = "aws-calico"
-  repository = local.helm_repo_eks
-  version    = var.calico_daemonset
-  namespace  = "kube-system"
-  wait       = false
+  name        = "aws-calico"
+  chart       = "aws-calico"
+  repository  = local.helm_repo_eks
+  version     = var.calico_daemonset
+  namespace   = "kube-system"
+  max_history = var.helm_release_history_size
+  wait        = false
 
   values = [
     data.template_file.calico_daemonset.rendered,
diff --git a/terraform/layer2-k8s/eks-nginx-ingress-controller.tf b/terraform/layer2-k8s/eks-nginx-ingress-controller.tf
@@ -25,7 +25,7 @@ resource "helm_release" "nginx_ingress" {
   namespace   = module.ing_namespace.name
   version     = var.nginx_ingress_controller_version
   wait        = false
-  max_history = "3"
+  max_history = var.helm_release_history_size
 
   values = [
     data.template_file.nginx_ingress.rendered,
diff --git a/terraform/layer2-k8s/examples/eks-alb-ingress-controller.tf b/terraform/layer2-k8s/examples/eks-alb-ingress-controller.tf
@@ -24,7 +24,7 @@ resource "helm_release" "alb_ingress_controller" {
   repository  = local.helm_repo_incubator
   version     = var.alb_ingress_chart_version
   namespace   = kubernetes_namespace.ing.id
-  max_history = "3"
+  max_history = var.helm_release_history_size
 
   values = [
     data.template_file.alb_ingress_controller.rendered
diff --git a/terraform/layer2-k8s/examples/eks-apm-server.tf b/terraform/layer2-k8s/examples/eks-apm-server.tf
@@ -13,7 +13,7 @@ resource "helm_release" "apm-server" {
   version     = var.elk_version
   namespace   = kubernetes_namespace.elk.id
   wait        = false
-  max_history = "3"
+  max_history = var.helm_release_history_size
 
   values = [
     data.template_file.apm.rendered,
diff --git a/terraform/layer2-k8s/examples/eks-elasticsearch.tf b/terraform/layer2-k8s/examples/eks-elasticsearch.tf
@@ -14,7 +14,7 @@ resource "helm_release" "elasticsearch" {
   version     = var.elk_version
   namespace   = kubernetes_namespace.elk.id
   wait        = false
-  max_history = "3"
+  max_history = var.helm_release_history_size
 
   values = [
     data.template_file.elasticsearch.rendered
diff --git a/terraform/layer2-k8s/examples/eks-elk.tf b/terraform/layer2-k8s/examples/eks-elk.tf
@@ -25,7 +25,7 @@ resource "helm_release" "elk" {
   chart       = "../../helm-charts/elk"
   namespace   = kubernetes_namespace.elk.id
   wait        = false
-  max_history = "3"
+  max_history = var.helm_release_history_size
 
   values = [
     data.template_file.elk.rendered
diff --git a/terraform/layer2-k8s/examples/eks-filebeat.tf b/terraform/layer2-k8s/examples/eks-filebeat.tf
@@ -9,7 +9,7 @@ resource "helm_release" "filebeat" {
   version     = var.elk_version
   namespace   = kubernetes_namespace.elk.id
   wait        = false
-  max_history = "3"
+  max_history = var.helm_release_history_size
 
   values = [
     data.template_file.filebeat.rendered
diff --git a/terraform/layer2-k8s/examples/eks-gitlab-runner.tf b/terraform/layer2-k8s/examples/eks-gitlab-runner.tf
@@ -38,7 +38,7 @@ resource "helm_release" "gitlab_runner" {
   version     = var.gitlab_runner_version
   namespace   = kubernetes_namespace.ci.id
   wait        = false
-  max_history = "3"
+  max_history = var.helm_release_history_size
 
   values = [
     local.gitlab_runner_template
diff --git a/terraform/layer2-k8s/examples/eks-istio.tf b/terraform/layer2-k8s/examples/eks-istio.tf
@@ -15,7 +15,7 @@ resource "helm_release" "istio_operator_resources" {
 
   namespace   = module.istio_system_namespace.name
   wait        = true
-  max_history = "3"
+  max_history = var.helm_release_history_size
 
   values = [
     file("${path.module}/templates/istio/istio-resources-values.yaml")
@@ -36,7 +36,7 @@ resource "helm_release" "istio_resources" {
 
   namespace   = module.istio_system_namespace.name
   wait        = false
-  max_history = "3"
+  max_history = var.helm_release_history_size
 
   values = [
     file("${path.module}/templates/istio/istio-resources-values.yaml")
@@ -52,7 +52,7 @@ resource "helm_release" "kiali" {
   namespace   = module.kiali_namespace.name
   version     = var.kiali_version
   wait        = false
-  max_history = "3"
+  max_history = var.helm_release_history_size
 
   values = [
     file("${path.module}/templates/istio/istio-kiali-values.yaml")
diff --git a/terraform/layer2-k8s/examples/eks-kibana.tf b/terraform/layer2-k8s/examples/eks-kibana.tf
@@ -42,7 +42,7 @@ resource "helm_release" "kibana" {
   version     = var.elk_version
   namespace   = kubernetes_namespace.elk.id
   wait        = false
-  max_history = "3"
+  max_history = var.helm_release_history_size
 
   values = [
     data.template_file.kibana.rendered
diff --git a/terraform/layer2-k8s/examples/eks-metricbeat.tf b/terraform/layer2-k8s/examples/eks-metricbeat.tf
@@ -9,7 +9,7 @@ resource "helm_release" "metricbeat" {
   version     = var.elk_version
   namespace   = kubernetes_namespace.elk.id
   wait        = false
-  max_history = "3"
+  max_history = var.helm_release_history_size
 
   values = [
     data.template_file.metricbeat.rendered
diff --git a/terraform/layer2-k8s/examples/eks-mysql-backup-wp.tf b/terraform/layer2-k8s/examples/eks-mysql-backup-wp.tf
@@ -40,7 +40,7 @@ resource "helm_release" "mysql_backup_wp" {
   version     = "2.1.4"
   namespace   = kubernetes_namespace.wp.id
   wait        = false
-  max_history = "3"
+  max_history = var.helm_release_history_size
 
   values = [
     data.template_file.mysql_backup_wp.rendered
diff --git a/terraform/layer2-k8s/examples/eks-oauth2-proxy.tf b/terraform/layer2-k8s/examples/eks-oauth2-proxy.tf
@@ -33,7 +33,7 @@ resource "helm_release" "oauth2_proxy" {
   version     = var.oauth2_proxy_version
   namespace   = kubernetes_namespace.elk.id
   wait        = false
-  max_history = "3"
+  max_history = var.helm_release_history_size
 
   values = [
     data.template_file.oauth2_proxy.rendered
diff --git a/terraform/layer2-k8s/examples/eks-postgresql-backups.tf b/terraform/layer2-k8s/examples/eks-postgresql-backups.tf
@@ -10,7 +10,7 @@ resource "helm_release" "postgresql_backups" {
   chart       = "../../helm-charts/postgresql-backups"
   namespace   = kubernetes_namespace.prod.id
   wait        = false
-  max_history = "3"
+  max_history = var.helm_release_history_size
 
   values = [
     local.postgresql_backups_template
diff --git a/terraform/layer2-k8s/examples/eks-prometheus-mysql-exporter.tf b/terraform/layer2-k8s/examples/eks-prometheus-mysql-exporter.tf
@@ -9,7 +9,7 @@ resource "helm_release" "prometheus_mysql_exporter_wp" {
   repository  = local.helm_repo_prometheus_community
   namespace   = kubernetes_namespace.wp.id
   wait        = false
-  max_history = "3"
+  max_history = var.helm_release_history_size
 
   values = [
     data.template_file.prometheus_mysql_exporter.rendered
diff --git a/terraform/layer2-k8s/examples/eks-prometheus-postgresql-exporter.tf b/terraform/layer2-k8s/examples/eks-prometheus-postgresql-exporter.tf
@@ -31,7 +31,7 @@ resource "helm_release" "postgresql_exporter_user" {
   chart       = "../../helm-charts/pg-exporter-user"
   namespace   = kubernetes_namespace.monitoring.id
   wait        = false
-  max_history = "3"
+  max_history = var.helm_release_history_size
 
   values = [
     local.postgresql_exporter_user_template
@@ -45,7 +45,7 @@ resource "helm_release" "postgresql_exporter" {
   version     = "1.4.0"
   namespace   = kubernetes_namespace.monitoring.id
   wait        = false
-  max_history = "3"
+  max_history = var.helm_release_history_size
 
   values = [
     local.prometheus_postgresql_exporter_template
diff --git a/terraform/layer2-k8s/examples/eks-teamcity.tf b/terraform/layer2-k8s/examples/eks-teamcity.tf
@@ -43,7 +43,7 @@ resource "helm_release" "teamcity" {
   namespace       = kubernetes_namespace.ci.id
   wait            = false
   cleanup_on_fail = true
-  max_history     = "3"
+  max_history     = var.helm_release_history_size
 
   values = [
     data.template_file.teamcity.rendered
diff --git a/terraform/layer2-k8s/variables.tf b/terraform/layer2-k8s/variables.tf
@@ -146,3 +146,8 @@ variable "calico_daemonset" {
   description = "Version of calico helm chart"
   default     = "0.3.4"
 }
+
+variable "helm_release_history_size" {
+  description = "How much helm releases to store"
+  default     = 5
+}
