Skip to content

Commit 5900e08

Browse files
madeindjskiurchv
andauthored
fix: event listeners are not registered (#4)
* chore: add prepare script * fix: move listener services to own module * fix: call explore methods in constructors instead of onModuleInit hooks Co-authored-by: Myroslav Kiurchev <[email protected]>
1 parent 49a185d commit 5900e08

File tree

4 files changed

+6
-9
lines changed

4 files changed

+6
-9
lines changed

package.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,7 @@
1616
"main": "dist/index.js",
1717
"types": "dist/index.d.ts",
1818
"scripts": {
19+
"prepare": "npm run build",
1920
"prebuild": "rimraf dist",
2021
"build": "nest build",
2122
"sample": "nodemon",

src/services/listener-explorer.service.ts

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ import { MetadataAccessorService } from './metadata-accessor.service';
1111
* Heavily inspired from [`BullExplorer`](https://github.com/nestjs/bull/blob/c230eab1dc26fb743a3428e61043167866b1e377/lib/bull.explorer.ts)
1212
*/
1313
@Injectable()
14-
export class ListenerExplorerService implements OnModuleInit {
14+
export class ListenerExplorerService {
1515
private readonly logger = new Logger(ListenerExplorerService.name);
1616

1717
public readonly listeners: { event: WorkerEventName; callback: Function }[] =
@@ -21,9 +21,7 @@ export class ListenerExplorerService implements OnModuleInit {
2121
private readonly discoveryService: DiscoveryService,
2222
private readonly metadataAccessor: MetadataAccessorService,
2323
private readonly metadataScanner: MetadataScanner,
24-
) {}
25-
26-
onModuleInit() {
24+
) {
2725
this.explore();
2826
}
2927

src/services/task-explorer.service.ts

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ import { MetadataAccessorService } from './metadata-accessor.service';
1111
* Heavily inspired from [`BullExplorer`](https://github.com/nestjs/bull/blob/c230eab1dc26fb743a3428e61043167866b1e377/lib/bull.explorer.ts)
1212
*/
1313
@Injectable()
14-
export class TaskExplorerService implements OnModuleInit {
14+
export class TaskExplorerService {
1515
private readonly logger = new Logger(TaskExplorerService.name);
1616

1717
public readonly taskList: TaskList = {};
@@ -20,9 +20,7 @@ export class TaskExplorerService implements OnModuleInit {
2020
private readonly discoveryService: DiscoveryService,
2121
private readonly metadataAccessor: MetadataAccessorService,
2222
private readonly metadataScanner: MetadataScanner,
23-
) {}
24-
25-
onModuleInit() {
23+
) {
2624
this.explore();
2725
}
2826

src/services/worker.service.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -101,7 +101,7 @@ export class WorkerService {
101101
for (const event of uniq(events)) {
102102
this.options.events.on(event, (...args: any[]) => {
103103
this.listenerExplorerService.listeners
104-
.filter(({ event }) => event === event)
104+
.filter((listener) => listener.event === event)
105105
.forEach(({ callback }) => callback(...args));
106106
});
107107
}

0 commit comments

Comments
 (0)