chore: enable Typescript strict mode

Author: madeindjs

src/graphile-worker.module.ts

@@ -1,19 +1,19 @@
-import { DynamicModule, Module, Provider } from '@nestjs/common';
-import { DiscoveryModule } from '@nestjs/core';
-import { EventEmitter } from 'events';
-import { RunnerOptions } from 'graphile-worker';
+import { DynamicModule, Module, Provider } from "@nestjs/common";
+import { DiscoveryModule } from "@nestjs/core";
+import { EventEmitter } from "node:events";
+import { RunnerOptions } from "graphile-worker";
 import {
   GraphileWorkerAsyncConfiguration,
   GraphileWorkerConfiguration,
   RUNNER_OPTIONS_KEY,
-} from './interfaces/module-config.interfaces';
-import { ListenerExplorerService } from './services/listener-explorer.service';
-import { MetadataAccessorService } from './services/metadata-accessor.service';
-import { TaskExplorerService } from './services/task-explorer.service';
-import { WorkerService } from './services/worker.service';
-import { RunnerLogger } from './utils/graphile-worker-logger.utils';
+} from "./interfaces/module-config.interfaces";
+import { ListenerExplorerService } from "./services/listener-explorer.service";
+import { MetadataAccessorService } from "./services/metadata-accessor.service";
+import { TaskExplorerService } from "./services/task-explorer.service";
+import { WorkerService } from "./services/worker.service";
+import { RunnerLogger } from "./utils/graphile-worker-logger.utils";
 
-export const GRAPHILE_WORKER_TOKEN = Symbol.for('NestJsGraphileWorker');
+export const GRAPHILE_WORKER_TOKEN = Symbol.for("NestJsGraphileWorker");
 
 const internalsProviders = [
   MetadataAccessorService,

src/index.ts

@@ -1,6 +1,6 @@
-export * from './decorators/task.decorators';
-export * from './decorators/worker.decorators';
-export * from './graphile-worker.module';
-export * from './interfaces/module-config.interfaces';
-export * from './interfaces/worker.interfaces';
-export * from './services/worker.service';
+export * from "./decorators/task.decorators";
+export * from "./decorators/worker.decorators";
+export * from "./graphile-worker.module";
+export * from "./interfaces/module-config.interfaces";
+export * from "./interfaces/worker.interfaces";
+export * from "./services/worker.service";

src/services/listener-explorer.service.ts

@@ -1,9 +1,9 @@
-import { Injectable, Logger, OnModuleInit } from '@nestjs/common';
-import { DiscoveryService } from '@nestjs/core';
-import { InstanceWrapper } from '@nestjs/core/injector/instance-wrapper';
-import { MetadataScanner } from '@nestjs/core/metadata-scanner';
-import { WorkerEventName } from '../interfaces/worker.interfaces';
-import { MetadataAccessorService } from './metadata-accessor.service';
+import { Injectable, Logger, OnModuleInit } from "@nestjs/common";
+import { DiscoveryService } from "@nestjs/core";
+import { InstanceWrapper } from "@nestjs/core/injector/instance-wrapper";
+import { MetadataScanner } from "@nestjs/core/metadata-scanner";
+import { WorkerEventName } from "../interfaces/worker.interfaces";
+import { MetadataAccessorService } from "./metadata-accessor.service";
 
 /**
  * This service is responsible to scan all [Worker decorators](../decorators/worker.decorators.ts) and register them.
@@ -17,7 +17,7 @@ export class ListenerExplorerService implements OnModuleInit {
   public readonly listeners: { event: WorkerEventName; callback: Function }[] =
     [];
 
-  private resolveInitialized: () => void;
+  private resolveInitialized: () => void = () => {};
 
   constructor(
     private readonly discoveryService: DiscoveryService,
@@ -54,9 +54,11 @@ export class ListenerExplorerService implements OnModuleInit {
               instance[key],
             );
 
+            if (event === undefined) return;
+
             this.listeners.push({
               event,
-              callback: (...args) => instance[key](...args),
+              callback: (...args: unknown[]) => instance[key](...args),
             });
 
             this.logger.debug(

src/services/task-explorer.service.spec.ts

@@ -36,7 +36,7 @@ describe(TaskExplorerService.name, () => {
     it("should register TestListenerService", () => {
       service.onModuleInit();
       assert.ok(service.taskList.hello);
-      assert.strictEqual(service.taskList.hello({}, undefined), "hello");
+      assert.strictEqual(service.taskList.hello({}, {} as any), "hello");
     });
   });
 });

src/services/task-explorer.service.ts

@@ -1,9 +1,9 @@
-import { Injectable, Logger, OnModuleInit } from '@nestjs/common';
-import { DiscoveryService } from '@nestjs/core';
-import { InstanceWrapper } from '@nestjs/core/injector/instance-wrapper';
-import { MetadataScanner } from '@nestjs/core/metadata-scanner';
-import { TaskList } from 'graphile-worker';
-import { MetadataAccessorService } from './metadata-accessor.service';
+import { Injectable, Logger, OnModuleInit } from "@nestjs/common";
+import { DiscoveryService } from "@nestjs/core";
+import { InstanceWrapper } from "@nestjs/core/injector/instance-wrapper";
+import { MetadataScanner } from "@nestjs/core/metadata-scanner";
+import { TaskList } from "graphile-worker";
+import { MetadataAccessorService } from "./metadata-accessor.service";
 
 /**
  * This service is responsible to scan all [Task decorators](../decorators/task.decorators.ts) and register them.
@@ -45,6 +45,8 @@ export class TaskExplorerService implements OnModuleInit {
               wrapper.metatype,
             );
 
+            if (name === undefined) return;
+
             this.taskList[name] = (...args) => instance[key](...args);
 
             this.logger.debug(

src/services/worker.service.ts

@@ -1,4 +1,4 @@
-import { Inject, Injectable, Logger } from '@nestjs/common';
+import { Inject, Injectable, Logger } from "@nestjs/common";
 import {
   Job,
   Runner,
@@ -8,16 +8,16 @@ import {
   makeWorkerUtils,
   run,
   runOnce,
-} from 'graphile-worker';
-import { RUNNER_OPTIONS_KEY } from '../interfaces/module-config.interfaces';
-import { uniq } from '../utils/array.utils';
-import { ListenerExplorerService } from './listener-explorer.service';
-import { TaskExplorerService } from './task-explorer.service';
+} from "graphile-worker";
+import { RUNNER_OPTIONS_KEY } from "../interfaces/module-config.interfaces";
+import { uniq } from "../utils/array.utils";
+import { ListenerExplorerService } from "./listener-explorer.service";
+import { TaskExplorerService } from "./task-explorer.service";
 
 @Injectable()
 export class WorkerService {
   private readonly logger = new Logger(WorkerService.name);
-  private isMigrationDone: boolean;
+  private isMigrationDone = false;
 
   constructor(
     @Inject(RUNNER_OPTIONS_KEY) private readonly options: RunnerOptions,
@@ -36,7 +36,7 @@ export class WorkerService {
   async run(): Promise<Runner> {
     await this.runMigrations();
 
-    this.logger.debug('Start runner');
+    this.logger.debug("Start runner");
 
     return await run(this.options);
   }
@@ -47,7 +47,7 @@ export class WorkerService {
   async runOnce(): Promise<void> {
     await this.runMigrations();
 
-    this.logger.debug('Start runner');
+    this.logger.debug("Start runner");
 
     await runOnce(this.options);
   }
@@ -89,7 +89,7 @@ export class WorkerService {
       return;
     }
 
-    this.logger.debug('Run migrations');
+    this.logger.debug("Run migrations");
     this.isMigrationDone = true;
   }
 
@@ -99,6 +99,8 @@ export class WorkerService {
       ({ event }) => event,
     );
 
+    if (this.options.events === undefined) return;
+
     for (const event of uniq(events)) {
       this.options.events.on(event, (...args: any[]) => {
         this.listenerExplorerService.listeners

src/utils/graphile-worker-logger.utils.ts

@@ -3,11 +3,11 @@ import {
   Logger as GraphileLogger,
   LogLevel,
   LogMeta,
-} from '@graphile/logger';
-import { Logger } from '@nestjs/common';
+} from "@graphile/logger";
+import { Logger } from "@nestjs/common";
 
-function graphileWorkerLogFactory(_scope): LogFunction {
-  const logger = new Logger('GraphileWorker');
+function graphileWorkerLogFactory(): LogFunction {
+  const logger = new Logger("GraphileWorker");
 
   return (level: LogLevel, message: string, meta?: LogMeta) => {
     if (meta !== undefined) {

tsconfig.json

@@ -1,5 +1,6 @@
 {
   "compilerOptions": {
+    "strict": true,
     "module": "commonjs",
     "declaration": true,
     "removeComments": false,
@@ -11,11 +12,8 @@
     "outDir": "./dist",
     "baseUrl": "./",
     "incremental": true,
-    "skipLibCheck": true,
+    "skipLibCheck": true
   },
-  "exclude": [
-    "node_modules",
-    "dist",
-    "sample"
-  ]
-}
+  "exclude": ["node_modules", "dist", "sample"]
+}
+