unsubscribe on component destroy

Andrew Turgeon · Andrew Turgeon · commit 33ce2cb43f68 · 2018-08-29T23:41:03.000-04:00
diff --git a/force-app/main/default/aura/Redux/Redux.cmp b/force-app/main/default/aura/Redux/Redux.cmp
@@ -1,5 +1,6 @@
 <aura:component description="Redux">
     <ltng:require scripts="{!$Resource.redux}"/>
+    <aura:handler name="destroy" value="{!this}" action="{!c.handleUnsubscribe}"/>
     <aura:attribute name="name" type="string" default="redux" />
     <aura:method name="createStore" action="{!c.createStore}">
         <aura:attribute name="name" type="string" />
diff --git a/force-app/main/default/aura/Redux/ReduxController.js b/force-app/main/default/aura/Redux/ReduxController.js
@@ -163,7 +163,7 @@
 
             handleChanges();
 
-            window.reduxStore[reduxName].subscribe(handleChanges);
+            component.unsubscribe = window.reduxStore[reduxName].subscribe(handleChanges);
             target.dispatch = window.reduxStore[reduxName].dispatch;
         } else {
             if(window.subscriberQueue && window.subscriberQueue[reduxName]) {
@@ -179,6 +179,11 @@
                 }];
             }
         }
+    },
+    handleUnsubscribe: function(component) {
+      if (component.unsubscribe) {
+        component.unsubscribe();
+      }
     }
 
 })

Original file line number	Diff line number	Diff line change
`@@ -163,7 +163,7 @@`
`163`	`163`
`164`	`164`	`handleChanges();`
`165`	`165`
`166`		`- window.reduxStore[reduxName].subscribe(handleChanges);`
	`166`	`+ component.unsubscribe = window.reduxStore[reduxName].subscribe(handleChanges);`
`167`	`167`	`target.dispatch = window.reduxStore[reduxName].dispatch;`
`168`	`168`	`} else {`
`169`	`169`	`if(window.subscriberQueue && window.subscriberQueue[reduxName]) {`
`@@ -179,6 +179,11 @@`
`179`	`179`	`}];`
`180`	`180`	`}`
`181`	`181`	`}`
	`182`	`+ },`
	`183`	`+ handleUnsubscribe: function(component) {`
	`184`	`+ if (component.unsubscribe) {`
	`185`	`+ component.unsubscribe();`
	`186`	`+ }`
`182`	`187`	`}`
`183`	`188`
`184`	`189`	`})`