Skip to content

Commit 8e3957b

Browse files
committed
- fixing correct coverage output
- improving karma configuration - improving package.json file
1 parent 586b293 commit 8e3957b

File tree

3 files changed

+15
-19
lines changed

3 files changed

+15
-19
lines changed

.travis.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,4 +16,4 @@ addons:
1616

1717
after_success:
1818
- npm install -g codeclimate-test-reporter
19-
- codeclimate-test-reporter < lcov.info
19+
- codeclimate-test-reporter < coverage/lcov.info

karma.conf.js

Lines changed: 13 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -26,11 +26,22 @@ module.exports = function (config) {
2626
// preprocess matching files before serving them to the browser
2727
// available preprocessors: https://npmjs.org/browse/keyword/karma-preprocessor
2828
preprocessors: {
29-
'./karma-shim.js': ['webpack', 'sourcemap']
29+
'./karma-shim.js': ['coverage', 'webpack', 'sourcemap']
3030
},
3131

3232
webpack: webpackConfig,
3333

34+
coverageReporter: {
35+
type: 'in-memory'
36+
},
37+
38+
remapCoverageReporter: {
39+
'text-summary': null,
40+
json: './coverage/coverage.json',
41+
html: './coverage/html',
42+
lcovonly: './coverage/lcov.info'
43+
},
44+
3445
webpackMiddleware: {
3546
// webpack-dev-middleware configuration
3647
// i. e.
@@ -44,7 +55,7 @@ module.exports = function (config) {
4455
// test results reporter to use
4556
// possible values: 'dots', 'progress', 'mocha'
4657
// available reporters: https://npmjs.org/browse/keyword/karma-reporter
47-
reporters: ["mocha"],
58+
reporters: ["mocha", "coverage", "remap-coverage"],
4859

4960
// web server port
5061
port: 9876,
@@ -68,20 +79,6 @@ module.exports = function (config) {
6879
singleRun: true
6980
};
7081

71-
if (!isTestWatch) {
72-
_config.reporters.push("coverage");
73-
74-
_config.coverageReporter = {
75-
dir: 'coverage/',
76-
reporters: [{
77-
type: 'json',
78-
dir: 'coverage',
79-
subdir: 'json',
80-
file: 'coverage-final.json'
81-
}]
82-
};
83-
}
84-
8582
config.set(_config);
8683

8784
};

package.json

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,6 @@
2727
"lint": "tslint --force \"src/**/*.ts\"",
2828
"pretest": "npm run lint",
2929
"test": "karma start",
30-
"posttest": "remap-istanbul -i coverage/json/coverage-final.json -o coverage/html -t html",
3130
"test-watch": "karma start --no-single-run --auto-watch",
3231
"build": "rimraf dist && ngc -p src/tsconfig.aot.json && gulp"
3332
},
@@ -76,7 +75,7 @@
7675
"karma-jasmine": "^1.0.2",
7776
"karma-mocha-reporter": "^2.0.3",
7877
"karma-phantomjs-launcher": "^1.0.0",
79-
"karma-remap-istanbul": "0.2.1",
78+
"karma-remap-coverage": "^0.1.4",
8079
"karma-sourcemap-loader": "^0.3.7",
8180
"karma-webpack": "1.8.0",
8281
"less": "^2.7.1",

0 commit comments

Comments
 (0)