Skip to content

Commit 586295b

Browse files
djanosikmadskristensen
authored andcommitted
Updates project files to fix broken extension (#337)
* Updates project files to fix broken extension. * Includes *.targets, Newtensoft.Json and NUglify in VSIX package. * Removes Bootstrapper packages. * Includes *.targets in NuGet package.
1 parent 25bc229 commit 586295b

File tree

3 files changed

+32
-16
lines changed

3 files changed

+32
-16
lines changed

src/WebCompiler/WebCompiler.csproj

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -13,9 +13,6 @@
1313
<!-- forces SDK to copy dependencies into build output to make packing easier -->
1414
<CopyLocalLockFileAssemblies>true</CopyLocalLockFileAssemblies>
1515
</PropertyGroup>
16-
<ItemGroup>
17-
<Content Include="MSBuild\*.targets" PackagePath="build\" />
18-
</ItemGroup>
1916
<ItemGroup>
2017
<EmbeddedResource Include="Node\prepare.cmd" />
2118
<EmbeddedResource Include="Node\node.7z" />
@@ -29,6 +26,9 @@
2926
<PackageReference Include="Newtonsoft.Json" Version="9.0.1" PrivateAssets="All" />
3027
<PackageReference Include="NUglify" Version="1.5.5" PrivateAssets="All" />
3128
</ItemGroup>
29+
<ItemGroup>
30+
<Content Include="MSBuild\*.targets" PackagePath="build\" />
31+
</ItemGroup>
3232
<Target Name="PrepareNpmDependencies" AfterTargets="Restore">
3333
<Exec Command="..\..\build\build.cmd" />
3434
</Target>

src/WebCompilerVsix/WebCompilerVsix.csproj

Lines changed: 26 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -212,10 +212,16 @@
212212
<Reference Include="Microsoft.VisualStudio.Utilities, Version=14.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a, processorArchitecture=MSIL">
213213
<Private>False</Private>
214214
</Reference>
215-
<Reference Include="NuGet.VisualStudio, Version=2.8.60318.667, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a, processorArchitecture=x86">
216-
<HintPath>..\..\packages\NuGet.VisualStudio.2.8.5\lib\net40\NuGet.VisualStudio.dll</HintPath>
215+
<Reference Include="Newtonsoft.Json, Version=9.0.0.0, Culture=neutral, PublicKeyToken=30ad4fe6b2a6aeed, processorArchitecture=MSIL">
216+
<HintPath>..\..\packages\Newtonsoft.Json.9.0.1\lib\net45\Newtonsoft.Json.dll</HintPath>
217+
</Reference>
218+
<Reference Include="NuGet.VisualStudio, Version=3.5.0.1996, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a, processorArchitecture=MSIL">
219+
<HintPath>..\..\packages\NuGet.VisualStudio.3.5.0\lib\net45\NuGet.VisualStudio.dll</HintPath>
217220
<EmbedInteropTypes>True</EmbedInteropTypes>
218221
</Reference>
222+
<Reference Include="NUglify, Version=1.5.5.0, Culture=neutral, PublicKeyToken=15bc7810aec21b5e, processorArchitecture=MSIL">
223+
<HintPath>..\..\packages\NUglify.1.5.5\lib\net40\NUglify.dll</HintPath>
224+
</Reference>
219225
<Reference Include="PresentationCore" />
220226
<Reference Include="PresentationFramework" />
221227
<Reference Include="stdole, Version=7.0.3300.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a">
@@ -226,12 +232,20 @@
226232
<Reference Include="System.ComponentModel.Composition" />
227233
<Reference Include="System.Design" />
228234
<Reference Include="System.Windows.Forms" />
235+
<Reference Include="System.Xml" />
229236
<Reference Include="WindowsBase" />
230237
</ItemGroup>
231238
<ItemGroup>
239+
<!--
240+
Exclude some facade-only assemblies (i.e. assemblies without any implementation) from the VSIX using the SuppressFromVsix ItemGroup.
241+
The list is dependent on the framework being targeted. Changes to TargetFrameworkVersion would may require changes to the SuppressFromVsix ItemGroup.
242+
-->
243+
<SuppressFromVsix Include="Microsoft.Build.Framework.dll" Visible="false" />
244+
<SuppressFromVsix Include="Microsoft.Build.Utilities.Core.dll" Visible="false" />
245+
<SuppressFromVsix Include="System.Threading.Thread.dll" Visible="false" />
232246
<ProjectReference Include="..\WebCompiler\WebCompiler.csproj">
233247
<Project>{b714b5b9-27c4-443c-9517-fe5c5ef46ea2}</Project>
234-
<Name>WebCompiler</Name>
248+
<Name>WebCompiler</Name>
235249
<!-- Workaround for https://github.com/dotnet/sdk/issues/433 -->
236250
<Private>false</Private>
237251
<IncludeOutputGroupsInVSIX>
@@ -240,15 +254,15 @@
240254
</IncludeOutputGroupsInVSIXLocalOnly>
241255
</ProjectReference>
242256
</ItemGroup>
243-
<ItemGroup />
257+
<ItemGroup>
258+
<VSIXSourceItem Include="..\WebCompiler\MSBuild\*.targets" Visible="false" />
259+
<VSIXSourceItem Include="..\WebCompiler\bin\$(Configuration)\net46\WebCompiler.pdb" Visible="false" />
260+
<VSIXSourceItem Include="..\WebCompiler\bin\$(Configuration)\net46\WebCompiler.exe" Visible="false" />
261+
<Content Include="@(VSIXSourceItem)">
262+
<CopyToOutputDirectory>PreserveNewest</CopyToOutputDirectory>
263+
</Content>
264+
</ItemGroup>
244265
<Import Project="$(MSBuildToolsPath)\Microsoft.CSharp.targets" />
245-
<Import Project="$(VSToolsPath)\VSSDK\Microsoft.VsSDK.targets" Condition="'$(VSToolsPath)' != ''" />
266+
<Import Project="$(VSToolsPath)\VSSDK\Microsoft.VsSDK.targets" Condition="Exists('$(VSToolsPath)\VSSDK\Microsoft.VsSDK.targets')" />
246267
<ProjectExtensions />
247-
<!-- To modify your build process, add your task inside one of the targets below and uncomment it.
248-
Other similar extension points exist, see Microsoft.Common.targets.
249-
<Target Name="BeforeBuild">
250-
</Target>
251-
<Target Name="AfterBuild">
252-
</Target>
253-
-->
254268
</Project>
Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,6 @@
11
<?xml version="1.0" encoding="utf-8"?>
22
<packages>
3-
<package id="NuGet.VisualStudio" version="2.8.5" targetFramework="net451" />
3+
<package id="Newtonsoft.Json" version="9.0.1" targetFramework="net46" />
4+
<package id="NuGet.VisualStudio" version="3.5.0" targetFramework="net46" />
5+
<package id="NUglify" version="1.5.5" targetFramework="net46" />
46
</packages>

0 commit comments

Comments
 (0)