Hackily fix missing availability annotation on new

Author: madsmtm

crates/header-translator/src/availability.rs

@@ -397,6 +397,13 @@ impl Availability {
         }
         true
     }
+
+    pub fn method_update_new_from_init(&mut self, other: &Self) {
+        if other.unavailable == Unavailable::ALL_UNAVAILABLE {
+            self.unavailable = Unavailable::ALL_UNAVAILABLE;
+        }
+        // TODO: Other parameters?
+    }
 }
 
 impl fmt::Display for Availability {

crates/header-translator/src/global_analysis.rs

@@ -217,6 +217,51 @@ fn update_module(
 
     module.stmts.extend(deprecated_fns);
 
+    // Propagate availability information of `init` to `new`.
+    // NOTE: this only works within single files.
+    let init_availability: BTreeMap<String, Availability> = module
+        .stmts
+        .iter()
+        .filter_map(|stmt| match stmt {
+            Stmt::ExternMethods {
+                cls: id, methods, ..
+            }
+            | Stmt::ExternCategory {
+                cls: id, methods, ..
+            }
+            | Stmt::ProtocolDecl { id, methods, .. } => Some(
+                methods
+                    .iter()
+                    .filter(|method| method.selector == "init")
+                    .map(|method| (id.name.clone(), method.availability.clone())),
+            ),
+            _ => None,
+        })
+        .flatten()
+        .collect();
+    for stmt in module.stmts.iter_mut() {
+        if let Stmt::ExternMethods {
+            cls: id, methods, ..
+        }
+        | Stmt::ExternCategory {
+            cls: id, methods, ..
+        }
+        | Stmt::ProtocolDecl { id, methods, .. } = stmt
+        {
+            if let Some(init_availability) = init_availability.get(&id.name) {
+                if let Some(method) = methods.iter_mut().find(|method| method.selector == "new") {
+                    method
+                        .availability
+                        .method_update_new_from_init(init_availability);
+                    // TODO(breaking): Remove unavailable instead of just marking them unsafe.
+                    if !method.availability.is_available() {
+                        method.safe = false;
+                    }
+                }
+            }
+        }
+    }
+
     // disambiguate duplicate names
     // NOTE: this only works within single files
     let mut names = BTreeMap::<(String, String), &mut Method>::new();

crates/header-translator/src/method.rs

@@ -336,7 +336,7 @@ pub struct Method {
     memory_management: MemoryManagement,
     arguments: Vec<(String, Ty)>,
     result_type: Ty,
-    safe: bool,
+    pub safe: bool,
     is_pub: bool,
     // Thread-safe, even on main-thread only (@MainActor/@UIActor) classes
     non_isolated: bool,

framework-crates/objc2-foundation/src/tests/measurement.rs

@@ -4,6 +4,6 @@ use crate::{NSMeasurement, NSUnitMass, NSUnitPower};
 
 #[test]
 fn create() {
-    let mass = NSMeasurement::<NSUnitMass>::new();
+    let mass = unsafe { NSMeasurement::<NSUnitMass>::new() };
     let _power = unsafe { mass.cast_unchecked::<NSUnitPower>() };
 }