Remove various workarounds that prevented breaking changes

Next release will be a breaking release.

Author: madsmtm

crates/dispatch2/translation-config.toml

@@ -255,9 +255,8 @@ fn.dispatch_data_create_subrange.unsafe = true
 fn.dispatch_group_enter.unsafe = true
 fn.dispatch_group_leave.unsafe = true
 
-# TODO(breaking): The cleanup handler is run on the queue, so it must be
-# Send + Sync.
-fn.dispatch_io_create_with_io.unsafe = false
+# The cleanup handler is run on the queue, so it must be Send + Sync.
+fn.dispatch_io_create_with_io.unsafe = true
 
 # object.h
 # NOTE: These work on a raw context pointer, but that's
@@ -297,7 +296,7 @@ fn.dispatch_allow_send_signals.unsafe = true
 # All values allowed, negative will return NULL
 fn.dispatch_semaphore_create.unsafe = false
 
-# TODO(breaking): Make these unsafe (the handler function must be correct).
-fn.dispatch_source_set_event_handler_f.unsafe = false
-fn.dispatch_source_set_cancel_handler_f.unsafe = false
-fn.dispatch_source_set_registration_handler_f.unsafe = false
+# The handler function must be correct.
+fn.dispatch_source_set_event_handler_f.unsafe = true
+fn.dispatch_source_set_cancel_handler_f.unsafe = true
+fn.dispatch_source_set_registration_handler_f.unsafe = true

crates/objc2/src/topics/FRAMEWORKS_CHANGELOG.md

@@ -28,20 +28,22 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/).
 
   Breaking changes are noted elsewhere in this changelog entry.
 * Changed the value of `kUSBHostPortPropertyPortNumber`.
-
-### Removed
-* **BREAKING**: Removed a lot of deprecated function aliases. Use the methods instead.
 * **BREAKING**: Fixed a bunch of nullability and generics information in:
   - `CoreFoundation` / `objc2-core-foundation`.
   - `CoreGraphics` / `objc2-core-graphics`.
   - `CoreText` / `objc2-core-text`.
   - `SystemConfiguration` / `objc2-system-configuration`.
+* **BREAKING**: Made `NSWindow::delegate`/`NSWindow::setDelegate` `unsafe`, it breaks type-safety if used together with `NSSavePanel`.
+
+### Removed
+* **BREAKING**: Removed a lot of deprecated function aliases. Use the methods instead.
 * **BREAKING**: Removed `MTLAutoreleased*` typedefs.
 * **BREAKING**: Removed `UIButtonConfiguration::tintedGlassButtonConfiguration`.
 * **BREAKING**: Removed `UIDocumentBrowserAction::imageOnlyForContextMenu` and
   `UIDocumentBrowserAction::setImageOnlyForContextMenu`.
 * **BREAKING**: Removed `ColorSyncProfile::tag_count`.
 * **BREAKING**: Removed `HMErrorCode::QuotaExceeded`.
+* **BREAKING**: Removed `NSStatusBar::new`.
 
 ### Fixed
 * Fixed the encoding check in `NSUUID` methods.

crates/test-ui/ui/cf_type_old_syntax.rs

@@ -0,0 +1,12 @@
+use objc2_core_foundation::cf_type;
+
+#[allow(dead_code)]
+struct TISInputSource {}
+
+// Test old syntax still works (used by dependencies).
+cf_type!(
+    #[encoding_name = "__TISInputSource"]
+    unsafe impl TISInputSource {}
+);
+
+fn main() {}

crates/test-ui/ui/cf_type_old_syntax.stderr

@@ -108,7 +108,7 @@ define_class!(
             view.addSubview(&text_field);
             window.center();
             window.setContentMinSize(NSSize::new(300.0, 300.0));
-            window.setDelegate(Some(ProtocolObject::from_ref(self)));
+            unsafe { window.setDelegate(Some(ProtocolObject::from_ref(self))) };
 
             // Show the window.
             window.makeKeyAndOrderFront(None);

examples/app/hello_world_app.rs

@@ -304,10 +304,9 @@ class.NSColorSampler.methods."showSamplerWithSelectionHandler:".unsafe = true
 # Rust's minimum supported macOS version, so that's fine.
 class.NSOutlineView.methods."setStronglyReferencesItems:".unsafe = true
 
-# TODO(breaking): These crash, should probably be skipped (and marked
-# `NS_UNAVAILABLE` in the header).
-class.NSStatusBar.methods.new.unsafe = true
-class.NSStatusBar.methods.init.unsafe = true
+# These crash, should probably be marked `NS_UNAVAILABLE` in the header.
+class.NSStatusBar.methods.new.skipped = true
+class.NSStatusBar.methods.init.skipped = true
 
 # Incorrectly overwritten, breaks type-safety.
 class.NSTableView.methods.dataSource.unsafe = true
@@ -326,8 +325,7 @@ class.NSTextContentStorage.methods."setDelegate:".unsafe = true
 class.NSTextContentManager.methods."setDelegate:".unsafe = true
 class.NSSavePanel.methods.delegate.unsafe = true
 class.NSSavePanel.methods."setDelegate:".unsafe = true
-# TODO(breaking): Mark this unsafe (or allow delegate protocols to break type-safety).
-class.NSWindow.methods.delegate.unsafe = false
-class.NSWindow.methods."setDelegate:".unsafe = false
+class.NSWindow.methods.delegate.unsafe = true
+class.NSWindow.methods."setDelegate:".unsafe = true
 class.NSComboButton.methods."setMenu:".unsafe = true
 class.NSResponder.methods."setMenu:".unsafe = true

framework-crates/objc2-app-kit/translation-config.toml

@@ -4,19 +4,3 @@ gnustep-1-8 = []
 gnustep-1-9 = []
 gnustep-2-0 = []
 gnustep-2-1 = []
-
-# TODO(breaking): Remove this
-NSFetchedResultsController = [
-    "objc2-foundation/NSArray",
-    "objc2-foundation/NSError",
-    "objc2-foundation/NSIndexPath",
-    "objc2-foundation/NSOrderedCollectionDifference",
-    "objc2-foundation/NSString",
-    "NSFetchRequest",
-]
-NSPersistentStoreResult = [
-    "objc2-foundation/NSArray",
-    "objc2-foundation/NSError",
-    "objc2-foundation/NSProgress",
-    "NSFetchRequest",
-]

framework-crates/objc2-core-data/Cargo.modified.toml

@@ -29,7 +29,6 @@
 #[macro_export]
 macro_rules! cf_type {
     (
-        $(#[encoding_name = $encoding_name:literal])? // TODO(breaking): Remove this.
         unsafe impl $(<$($generic:ident : ?$sized:ident),* $(,)?>)? $ty:ident $(<$($generic_param:ident),* $(,)?>)? $(: $superclass:ty)? {}
     ) => {
         // Reflexive AsRef impl.
@@ -90,12 +89,6 @@ macro_rules! cf_type {
                 $crate::__cf_macro_helpers::fmt::Debug::fmt(this, f)
             }
         }
-
-        // Objective-C interop
-        $crate::__cf_type_objc2!(
-            impl ($(<$($generic : ?$sized),*>)?) $ty $(<$($generic_param),*>)?;
-            $($encoding_name)?
-        );
     };
 }
 
@@ -151,40 +144,3 @@ macro_rules! __cf_type_superclass {
         }
     };
 }
-
-#[doc(hidden)]
-#[macro_export]
-macro_rules! __cf_type_no_superclass {
-    (impl ($($generics:tt)*) $ty:ty) => {};
-}
-
-#[cfg(feature = "objc2")]
-#[doc(hidden)]
-#[macro_export]
-macro_rules! __cf_type_objc2 {
-    (impl ($($generics:tt)*) $ty:ty;) => {};
-    (impl ($($generics:tt)*) $ty:ty; $encoding:literal) => {
-        $crate::__cf_macro_helpers::cf_objc2_type!(
-            unsafe impl $($generics)* RefEncode<$encoding> for $ty {}
-        );
-    };
-}
-
-#[cfg(not(feature = "objc2"))]
-#[doc(hidden)]
-#[macro_export]
-macro_rules! __cf_type_objc2 {
-    ($($t:tt)*) => {};
-}
-
-#[cfg(test)]
-mod tests {
-    #[allow(dead_code)]
-    struct TISInputSource {}
-
-    // Test old syntax still works (used by dependencies).
-    cf_type!(
-        #[encoding_name = "__TISInputSource"]
-        unsafe impl TISInputSource {}
-    );
-}

framework-crates/objc2-core-data/Cargo.toml

@@ -23,6 +23,10 @@ const.kMORTLigLastAction.use-value = true
 const.kMORXCoverVertical.use-value = true
 const.kKERXVertical.use-value = true
 
+# `CTRunDelegateCreate` creates this from a nullable parameter, so this is
+# probably also nullable.
+fn.CTRunDelegateGetRefCon.return.nullability = "nullable"
+
 ##
 ## Fixing bounds information.
 ##
@@ -206,10 +210,6 @@ unsafe-default-safety.documentation-is-reviewed = true
 # - `CTRunGetStringIndices` takes buffer pointer, so ofc. isn't safe.
 unsafe-default-safety.bounds-checked-internally = true
 
-# TODO(breaking): Mark this as nullable? `CTRunDelegateCreate` creates it from
-# a nullable parameter.
-fn.CTRunDelegateGetRefCon.unsafe = true
-
 # Documents that:
 # > The return value is undefined if CTFontCollectionCreateFromAvailableFonts was used to create the collection.
 # But that probably isn't language-level UB.