Add tests for Debug formatting

Author: madsmtm

objc2-foundation/src/array.rs

@@ -352,6 +352,7 @@ impl<T: INSObject, O: Ownership> Index<usize> for NSMutableArray<T, O> {
 
 #[cfg(test)]
 mod tests {
+    use alloc::format;
     use alloc::vec;
     use alloc::vec::Vec;
 
@@ -405,6 +406,18 @@ mod tests {
         assert_ne!(array1, array2);
     }
 
+    #[test]
+    #[ignore = "Output is different depending on OS version and runtime"]
+    fn test_debug() {
+        let obj = sample_number_array(3);
+        let expected = r#"(
+    "<00>",
+    "<01>",
+    "<02>"
+)"#;
+        assert_eq!(format!("{:?}", obj), format!("{:?}", expected));
+    }
+
     #[test]
     fn test_get() {
         let array = sample_array(4);

objc2-foundation/src/object.rs

@@ -46,9 +46,8 @@ impl NSObject {
 #[cfg(test)]
 mod tests {
     use super::{INSObject, NSObject};
-    use crate::{INSString, NSString};
+    use crate::NSString;
     use alloc::format;
-    use objc2::rc::autoreleasepool;
 
     #[test]
     fn test_equality() {
@@ -66,16 +65,10 @@ mod tests {
     }
 
     #[test]
-    fn test_description() {
+    fn test_debug() {
         let obj = NSObject::new();
-        let description = obj.description();
         let expected = format!("<NSObject: {:p}>", &*obj);
-        autoreleasepool(|pool| {
-            assert_eq!(description.as_str(pool), &*expected);
-        });
-
-        let expected = format!("\"<NSObject: {:p}>\"", &*obj);
-        assert_eq!(format!("{:?}", obj), expected);
+        assert_eq!(format!("{:?}", obj), format!("{:?}", expected));
     }
 
     #[test]

objc2-foundation/src/string.rs

@@ -122,6 +122,7 @@ impl fmt::Display for NSString {
 #[cfg(test)]
 mod tests {
     use super::*;
+    use alloc::format;
 
     #[cfg(gnustep)]
     #[test]
@@ -140,6 +141,14 @@ mod tests {
         assert_ne!(s1, s3);
     }
 
+    #[test]
+    fn test_debug_display() {
+        let s = "xyz123";
+        let obj = NSString::from_str(s);
+        assert_eq!(format!("{:?}", obj), format!("{:?}", s));
+        assert_eq!(format!("{}", obj), format!("{}", s));
+    }
+
     #[test]
     fn test_empty() {
         let s1 = NSString::from_str("");

objc2-foundation/src/value.rs

@@ -94,6 +94,8 @@ pub struct NSValueFloatNotEq;
 
 #[cfg(test)]
 mod tests {
+    use alloc::format;
+
     use crate::{INSValue, NSRange, NSValue};
     use objc2::rc::{Id, Shared};
     use objc2::Encode;
@@ -126,6 +128,33 @@ mod tests {
         assert_ne!(val1, val2);
     }
 
+    #[test]
+    #[ignore = "Output is different depending on OS version and runtime"]
+    fn test_debug() {
+        fn assert_debug(val: impl core::fmt::Debug, expected: &str) {
+            assert_eq!(format!("{:?}", val), format!("{:?}", expected));
+        }
+        let val = NSValue::new(0xabu8);
+        let expected = "<ab>";
+        assert_debug(val, expected);
+
+        let val = NSValue::new(0x12i8);
+        let expected = "<12>";
+        assert_debug(val, expected);
+
+        let val = NSValue::new(0xdeadbeefu32);
+        let expected = "<efbeadde>";
+        assert_debug(val, expected);
+
+        // Very brittle
+        let val = NSValue::new(1.0f32);
+        let expected = &format!(
+            "<{:08x}>",
+            u32::from_le_bytes(1.0f32.to_le_bytes()).reverse_bits()
+        );
+        assert_debug(val, expected);
+    }
+
     #[test]
     fn test_value_nsrange() {
         let val = NSValue::new(NSRange::from(1..2));