Skip to content

Commit 6762628

Browse files
committed
Fix year field parse failure when given invalid input. Fixes #173
1 parent ff4becc commit 6762628

File tree

2 files changed

+5
-1
lines changed

2 files changed

+5
-1
lines changed

lib/crontab/cron_expression/parser.ex

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -349,7 +349,7 @@ defmodule Crontab.CronExpression.Parser do
349349
{number, ""} ->
350350
{:ok, number}
351351

352-
:error ->
352+
_ ->
353353
{:error, "Can't parse " <> value <> " as interval " <> Atom.to_string(interval) <> "."}
354354
end
355355
end

test/crontab/cron_expression/parser_test.exs

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -374,6 +374,10 @@ defmodule Crontab.CronExpression.ParserTest do
374374
assert parse("*/0") == {:error, "Can't parse 0 as increment."}
375375
end
376376

377+
test "parse invalid year expression gives error" do
378+
assert parse("* * * * * 1x") == {:error, "Can't parse 1x as interval year."}
379+
end
380+
377381
describe "parse/2 non-range step value" do
378382
setup do: %{now: ~N[2024-01-01 00:00:01]}
379383

0 commit comments

Comments
 (0)