Service unvailable in new tab or window

[maforget]

Describe the bug
Some functions are not available when lists are open in a new tab or window. Things like removing books are disabled.

Exact Steps to Reproduce
Steps to reproduce the behavior:

1. Open a List in a new tab
2. Go back to the Library tab and switch lists
3. Go to the previous list in the new tab
4. The Remove entry in the context menu is grayed out.

Version/Commit (check the about page, next to the version, for the string between brackets):

• Version: 0.9.180
• Commit: fe5b7ce

Additional context
When UpdateBookList is called

ComicRackCE/ComicRack/Views/ComicListLibraryBrowser.cs

Lines 728 to 738 in 4258007

	private void UpdateBookList()
	{
	updateTimer.Stop();
	using (new WaitCursor())
	{
	if (tvQueries.SelectedNode != null)
	{
	BookList = tvQueries.SelectedNode.Tag as IComicBookListProvider;
	}
	}
	}

It sets the BookList, but when the list differ, it disconnects the ServiceRequest from the old one.

ComicRackCE/ComicRack/Views/ComicListBrowser.cs

Lines 25 to 42 in 4258007

	protected set
	{
	if (bookList != value)
	{
	IComicBookListProvider comicBookListProvider = bookList;
	bookList = value;
	if (bookList != null)
	{
	bookList.ServiceRequest += bookList_ServiceRequest;
	}
	OnBookListChanged();
	if (comicBookListProvider != null)
	{
	comicBookListProvider.ServiceRequest -= bookList_ServiceRequest;
	}
	history.AddAtCursor(bookList);
	}
	}

So things that use QueryService might not work. When the QueryService is called it execute the OnServiceRequest. But since it is disconnected it won't trigger.

ComicRackCE/cYo.Common/ComponentModel/LiteComponent.cs

Lines 11 to 24 in 4258007

	public virtual T QueryService<T>() where T : class
	{
	ServiceRequestEventArgs serviceRequestEventArgs = new ServiceRequestEventArgs(typeof(T), this as T);
	OnServiceRequest(serviceRequestEventArgs);
	return serviceRequestEventArgs.Service as T;
	}
	protected virtual void OnServiceRequest(ServiceRequestEventArgs e)
	{
	if (this.ServiceRequest != null)
	{
	this.ServiceRequest(this, e);
	}
	}

ComicRackCE/ComicRack/Views/ComicListLibraryBrowser.cs

Lines 355 to 358 in 4258007

	if (e.Service == null && e.ServiceType == typeof(IRemoveBooks))
	{
	e.Service = new RemoveBookHandler(this, Library, senderList);
	}

But it seems to be a problem specifically with IRemoveBooks. Usually when BookList.QueryService<IRemoveBooks>() is called, if the caller (in this case a ComicIdListItem or ComicSmartListItem or any type of lists) doesn't implement IRemoveBooks then the Service becomes null, thus no allowing it to work with CanRemoveBooks or RemoveBooks.

ComicRackCE/ComicRack/Views/ComicBrowserControl.cs

Lines 2757 to 2781 in 4258007

	public void RemoveBooks(IEnumerable<ComicBook> books)
	{
	IRemoveBooks removeBooks = BookList.QueryService<IRemoveBooks>();
	if (removeBooks != null)
	{
	ItemView.BeginUpdate();
	try
	{
	removeBooks.RemoveBooks(books, Control.ModifierKeys != Keys.Control);
	}
	finally
	{
	ItemView.EndUpdate();
	}
	}
	}
	private bool CanRemoveBooks()
	{
	if (itemView.InplaceEditItem == null && ComicEditMode.CanDeleteComics() && BookList != null)
	{
	return BookList.QueryService<IRemoveBooks>() != null;
	}
	return false;
	}

[maforget]

It may be a bug or it's intentional. I'd be wary of changing the behavior because it could lead the files being deleted in all open list instead of only the active one.

[secondsabre]

Ah, you went and made the report for me (and far better than I could have). Yea, I agree that it could be either a bug or intentional, some kind of security quirk to make sure that specific actions are taken on specific books. I had wondered if it was something that could be bypassed via Preferences or in the INI, but scoured both and found nothing, so it's gotta be hard-coded.

Mostly I come across this problem when I have a bunch of lists open and I'm trying to organize them, like putting together a reading list or shuffling stuff around. If a book is on 2-3 different lists, it can be a pain to have them all open in separate tabs but still have to find them all in the main browser library in order to remove them.

In terms of changing the behaviour (if I understand correctly) and implementing the ability, would it be possible to just connect the necessary services for the currently active tab/window so the actions don't spread across all open lists? It sounds like it might be a lot of work, though.

Maybe a slightly easier solution might be to add something to the context menu for opened tabs/windows, a "Jump to Current List" option, that will make the main Library tab jump (in the background) to the list that's open in the tab/window? I'd assume then services would connect automatically and stuff can be deleted? It would add in an extra click, but keeps the security active and provides a shortcut for when using multiple workspaces.

idk, just spitballing here, but I'd be happy to do any testing or PR's that come up as a result of this. Thanks again!

[maforget]

The solution is to do it like I did with the Paste Data crashes and move the check to enable the menu entry when you actually open the menu instead of in the background using the Service. It wouldn't matter in that case which list is the active one.

It might have effects when using the keyboard and pressing the DEL key, would need to test with which part of the screen is active (like treeview).