Skip to content

Virtual Tag aren't transferred when using a Remote Library. #242

@maforget

Description

@maforget

Describe the bug
Connecting to a remote library that uses Virtual Tags for grouping/stacking/sorting will use the client Virtual Tag instead.

Exact Steps to Reproduce
Steps to reproduce the behavior:

  1. Connect to a remote library (that is not our own - aka -orc)
  2. Go to a list that uses a Virtual Tag for grouping/stacking
  3. The stacking/grouping/sorting will use the client tags instead.

Screenshots

Version/Commit (check the about page, next to the version, for the string between brackets):

Additional context
Virtual Tags are set when the Library is set.

set
{
if (library != value)
{
library = value;
library.CustomValuesChanged += delegate
{
SetExtraColumns(ExtraColumnType.Custom);
};
SetExtraColumns(); // BUG: Adding Virtual Tags here means that when added to the Remote Libraries they aren't transfered and will use the client tags instead.
ComicBookMetadataManager.Create(itemView.Columns); // Saves columns when we require a Comparer/Grouper for a specific column key
}

It could be possible to just not set the Virtual Tag extra columns, but I thought it would be better to just leave it so if the local/remote tags match at least it would work. The fix is probably to transfer the Virtual Tag settings to client.

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions