Skip to content

Commit c92e9d6

Browse files
authored
Skip generation of package versions that already exist for consistency with upstream (#224)
1 parent a51c693 commit c92e9d6

File tree

1 file changed

+4
-2
lines changed

1 file changed

+4
-2
lines changed

src/package-modules.js

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -283,8 +283,10 @@ async function createPackageForRef(url, moduleDir, ref, options) {
283283
// build the package even if it already exists - this is important as a workaround against inconsistencies in upstream
284284
// release tagging of adobe-ims
285285
if (fs.existsSync(packageFilepath)) {
286-
//fs.unlinkSync(packageFilepath)
287-
//return packageWithVersion;
286+
// the package version was already built while processing an earlier tag, so we skip the generation. The content
287+
// _should_ be the same. However, it sometimes changes due to mistakes in the upstream processes, but in those cases
288+
// upstream uses the earliest version of the package, so we do the same to be consistent.
289+
return packageWithVersion;
288290
}
289291

290292
const files = (await repo.listFiles(url, moduleDir, ref, excludes))

0 commit comments

Comments
 (0)