feat: provide hover & definition for element values

Author: raideer

src/definition/XmlClasslikeDefinitionProvider.ts

@@ -22,7 +22,7 @@ export class XmlClasslikeDefinitionProvider implements DefinitionProvider {
     position: Position,
     token: CancellationToken
   ) {
-    const range = document.getWordRangeAtPosition(position, /"[^"]*"/);
+    const range = document.getWordRangeAtPosition(position, /("[^"]+")|(>[^<]+<)/);
 
     if (!range) {
       return null;
@@ -36,7 +36,7 @@ export class XmlClasslikeDefinitionProvider implements DefinitionProvider {
       return null;
     }
 
-    const potentialNamespace = word.replace(/"/g, '');
+    const potentialNamespace = word.replace(/["<>]/g, '');
 
     const classUri = await namespaceIndexData.findClassByNamespace(
       PhpNamespace.fromString(potentialNamespace)
@@ -48,11 +48,16 @@ export class XmlClasslikeDefinitionProvider implements DefinitionProvider {
 
     const targetPosition = await this.getClasslikeNameRange(document, classUri);
 
+    const originSelectionRange = new Range(
+      range.start.with({ character: range.start.character + 1 }),
+      range.end.with({ character: range.end.character - 1 })
+    );
+
     return [
       {
         targetUri: classUri,
         targetRange: targetPosition,
-        originSelectionRange: range,
+        originSelectionRange,
       } as LocationLink,
     ];
   }

src/hover/XmlClasslikeHoverProvider.ts

@@ -4,13 +4,13 @@ import PhpNamespace from 'common/PhpNamespace';
 import { AutoloadNamespaceIndexData } from 'indexer/autoload-namespace/AutoloadNamespaceIndexData';
 import AutoloadNamespaceIndexer from 'indexer/autoload-namespace/AutoloadNamespaceIndexer';
 import IndexManager from 'indexer/IndexManager';
-import { Hover, HoverProvider, Position, TextDocument } from 'vscode';
+import { Hover, HoverProvider, Position, Range, TextDocument } from 'vscode';
 
 export default class XmlClasslikeHoverProvider implements HoverProvider {
   private namespaceIndexData: AutoloadNamespaceIndexData | undefined;
 
   public async provideHover(document: TextDocument, position: Position): Promise<Hover | null> {
-    const range = document.getWordRangeAtPosition(position, /"[^"]*"/);
+    const range = document.getWordRangeAtPosition(position, /("[^"]+")|(>[^<]+<)/);
 
     if (!range) {
       return null;
@@ -24,7 +24,7 @@ export default class XmlClasslikeHoverProvider implements HoverProvider {
       return null;
     }
 
-    const potentialNamespace = word.replace(/"/g, '');
+    const potentialNamespace = word.replace(/["<>]/g, '');
 
     const classUri = await namespaceIndexData.findClassByNamespace(
       PhpNamespace.fromString(potentialNamespace)
@@ -37,7 +37,12 @@ export default class XmlClasslikeHoverProvider implements HoverProvider {
     const phpFile = await PhpDocumentParser.parseUri(document, classUri);
     const classLikeInfo = new ClasslikeInfo(phpFile);
 
-    return new Hover(classLikeInfo.getHover(), range);
+    const rangeWithoutTags = new Range(
+      range.start.with({ character: range.start.character + 1 }),
+      range.end.with({ character: range.end.character - 1 })
+    );
+
+    return new Hover(classLikeInfo.getHover(), rangeWithoutTags);
   }
 
   private getNamespaceIndexData(): AutoloadNamespaceIndexData | undefined {