fixing tests

Author: mageddo

reflection-config-generator/acceptance-tests/build.gradle

@@ -1,6 +1,6 @@
 dependencies {
 
-	compileOnly(project(":reflection-config-generator"))
+	compile(project(":reflection-config-generator")) // compile for third party generation
 	annotationProcessor(project(":reflection-config-generator"))
 
 	compile ("com.fasterxml.jackson.core:jackson-databind:2.10.1")

reflection-config-generator/acceptance-tests/src/main/java/com/acme/TestUtils.java

@@ -1,11 +1,13 @@
 package com.acme;
 
+import java.io.IOException;
+import java.io.InputStream;
+
 import com.fasterxml.jackson.databind.MapperFeature;
 import com.fasterxml.jackson.databind.ObjectMapper;
 import com.fasterxml.jackson.databind.SerializationFeature;
-import org.apache.commons.io.IOUtils;
 
-import java.io.IOException;
+import org.apache.commons.io.IOUtils;
 
 public class TestUtils {
 
@@ -14,12 +16,16 @@ private TestUtils() {
 
 	public static String getResourceAsString(String path) {
 		try {
-			return IOUtils.toString(TestUtils.class.getResourceAsStream(path), "UTF-8");
+			return IOUtils.toString(getResourceAsStream(path), "UTF-8");
 		} catch (IOException e) {
 			throw new RuntimeException(e);
 		}
 	}
 
+	public static InputStream getResourceAsStream(String path) {
+		return TestUtils.class.getResourceAsStream(path);
+	}
+
 	public static String sortJson(String json){
 		try {
 		final ObjectMapper om = new ObjectMapper()

reflection-config-generator/acceptance-tests/src/test/java/com/acme/ReflectionConfigGenerationTest.java

@@ -1,19 +1,24 @@
 package com.acme;
 
+import java.io.IOException;
+import java.io.InputStream;
+import java.nio.file.Files;
+import java.nio.file.Path;
 import java.util.ArrayList;
 import java.util.Collections;
 import java.util.Comparator;
 import java.util.List;
 
-import com.fasterxml.jackson.core.JsonProcessingException;
 import com.fasterxml.jackson.databind.JsonNode;
 import com.fasterxml.jackson.databind.ObjectMapper;
 import com.fasterxml.jackson.databind.SerializationFeature;
 
-import org.junit.jupiter.api.Disabled;
 import org.junit.jupiter.api.Test;
+import org.junit.jupiter.api.io.TempDir;
 
+import static com.acme.TestUtils.getResourceAsStream;
 import static com.acme.TestUtils.getResourceAsString;
+import nativeimage.core.thirdparty.Main;
 import static org.junit.jupiter.api.Assertions.assertEquals;
 
 class ReflectionConfigGenerationTest {
@@ -23,33 +28,30 @@ class ReflectionConfigGenerationTest {
 		;
 
 	@Test
-	void mustConfigureReflectJson() throws JsonProcessingException {
+	void mustConfigureReflectJson() throws IOException {
 		// arrange
-
 		// act
-		final List<JsonNode> items = readReflectConfig("reflect.json");
-
 		// assert
-		assertEquals(13, items.size());
 		assertEquals(
 				getResourceAsString("/reflection-config-generation-test/001.json"),
-				objectMapper.writeValueAsString(items)
+				readReflectConfig("reflect.json")
 		);
 	}
 
 	@Test
-	@Disabled
-	void mustConfigureThirdPartyReflectJson() throws JsonProcessingException {
+	void mustConfigureThirdPartyReflectJson(@TempDir Path tmpDir) throws Exception {
 		// arrange
+		final Path reflectFile = Files.createTempFile(tmpDir, "reflect", ".json");
 
 		// act
-		final List<JsonNode> items = readReflectConfig("reflect-third-party.json");
+		Main.main(new String[]{
+				"com.fasterxml.jackson.core.util", reflectFile.toString()
+		});
 
 		// assert
-		assertEquals(14, items.size());
 		assertEquals(
-				getResourceAsString("/reflection-config-generation-test/002.json"),
-				objectMapper.writeValueAsString(items)
+				readReflectConfig(getResourceAsStream("/reflection-config-generation-test/002.json")),
+				readReflectConfig(Files.newInputStream(reflectFile))
 		);
 	}
 
@@ -66,11 +68,13 @@ void mustConfigureNativeImagePropertiesFile(){
 	}
 
 
-	private List<JsonNode> readReflectConfig(final String fileName) throws JsonProcessingException {
+	private String readReflectConfig(final String fileName) throws IOException {
+		return readReflectConfig(getResourceAsStream("/META-INF/native-image/com.acme/" + fileName));
+	}
+
+	private String readReflectConfig(final InputStream in) throws IOException {
 		final List<JsonNode> items = new ArrayList<>();
-		final JsonNode reflectItems = this.objectMapper.readTree(
-				getResourceAsString("/META-INF/native-image/com.acme/" + fileName)
-		);
+		final JsonNode reflectItems = this.objectMapper.readTree(in);
 		for (JsonNode jsonNode : reflectItems) {
 			items.add(jsonNode);
 		}
@@ -80,7 +84,7 @@ public int compare(JsonNode a, JsonNode b) {
 				return a.at("/name").asText().compareTo(b.at("/name").asText());
 			}
 		});
-		return items;
+		return objectMapper.writeValueAsString(items);
 	}
 
 }

reflection-config-generator/acceptance-tests/src/test/resources/reflection-config-generation-test/002.json

@@ -1,37 +1,37 @@
 [ {
-  "name" : "com.fasterxml.jackson.core.util.ByteArrayBuilder",
+  "name" : "com.fasterxml.jackson.core.util.BufferRecycler",
   "allDeclaredConstructors" : false,
   "allPublicConstructors" : false,
   "allDeclaredMethods" : false,
   "allPublicMethods" : false,
   "allPublicFields" : false,
   "allDeclaredFields" : false
 }, {
-  "name" : "com.fasterxml.jackson.core.util.DefaultIndenter",
+  "name" : "com.fasterxml.jackson.core.util.BufferRecyclers",
   "allDeclaredConstructors" : false,
   "allPublicConstructors" : false,
   "allDeclaredMethods" : false,
   "allPublicMethods" : false,
   "allPublicFields" : false,
   "allDeclaredFields" : false
 }, {
-  "name" : "com.fasterxml.jackson.core.util.DefaultPrettyPrinter",
+  "name" : "com.fasterxml.jackson.core.util.DefaultIndenter",
   "allDeclaredConstructors" : false,
   "allPublicConstructors" : false,
   "allDeclaredMethods" : false,
   "allPublicMethods" : false,
   "allPublicFields" : false,
   "allDeclaredFields" : false
 }, {
-  "name" : "com.fasterxml.jackson.core.util.DefaultPrettyPrinter$FixedSpaceIndenter",
+  "name" : "com.fasterxml.jackson.core.util.DefaultPrettyPrinter",
   "allDeclaredConstructors" : false,
   "allPublicConstructors" : false,
   "allDeclaredMethods" : false,
   "allPublicMethods" : false,
   "allPublicFields" : false,
   "allDeclaredFields" : false
 }, {
-  "name" : "com.fasterxml.jackson.core.util.DefaultPrettyPrinter$Indenter",
+  "name" : "com.fasterxml.jackson.core.util.DefaultPrettyPrinter$FixedSpaceIndenter",
   "allDeclaredConstructors" : false,
   "allPublicConstructors" : false,
   "allDeclaredMethods" : false,
@@ -47,63 +47,63 @@
   "allPublicFields" : false,
   "allDeclaredFields" : false
 }, {
-  "name" : "com.fasterxml.jackson.core.util.Instantiatable",
+  "name" : "com.fasterxml.jackson.core.util.JacksonFeatureSet",
   "allDeclaredConstructors" : false,
   "allPublicConstructors" : false,
   "allDeclaredMethods" : false,
   "allPublicMethods" : false,
   "allPublicFields" : false,
   "allDeclaredFields" : false
 }, {
-  "name" : "com.fasterxml.jackson.core.util.InternCache",
+  "name" : "com.fasterxml.jackson.core.util.MinimalPrettyPrinter",
   "allDeclaredConstructors" : false,
   "allPublicConstructors" : false,
   "allDeclaredMethods" : false,
   "allPublicMethods" : false,
   "allPublicFields" : false,
   "allDeclaredFields" : false
 }, {
-  "name" : "com.fasterxml.jackson.core.util.JsonGeneratorDelegate",
+  "name" : "com.fasterxml.jackson.core.util.RequestPayload",
   "allDeclaredConstructors" : false,
   "allPublicConstructors" : false,
   "allDeclaredMethods" : false,
   "allPublicMethods" : false,
   "allPublicFields" : false,
   "allDeclaredFields" : false
 }, {
-  "name" : "com.fasterxml.jackson.core.util.JsonParserDelegate",
+  "name" : "com.fasterxml.jackson.core.util.Separators",
   "allDeclaredConstructors" : false,
   "allPublicConstructors" : false,
   "allDeclaredMethods" : false,
   "allPublicMethods" : false,
   "allPublicFields" : false,
   "allDeclaredFields" : false
 }, {
-  "name" : "com.fasterxml.jackson.core.util.JsonParserSequence",
+  "name" : "com.fasterxml.jackson.core.util.TextBuffer",
   "allDeclaredConstructors" : false,
   "allPublicConstructors" : false,
   "allDeclaredMethods" : false,
   "allPublicMethods" : false,
   "allPublicFields" : false,
   "allDeclaredFields" : false
 }, {
-  "name" : "com.fasterxml.jackson.core.util.MinimalPrettyPrinter",
+  "name" : "com.fasterxml.jackson.core.util.ThreadLocalBufferManager",
   "allDeclaredConstructors" : false,
   "allPublicConstructors" : false,
   "allDeclaredMethods" : false,
   "allPublicMethods" : false,
   "allPublicFields" : false,
   "allDeclaredFields" : false
 }, {
-  "name" : "com.fasterxml.jackson.core.util.RequestPayload",
+  "name" : "com.fasterxml.jackson.core.util.ThreadLocalBufferManager$ThreadLocalBufferManagerHolder",
   "allDeclaredConstructors" : false,
   "allPublicConstructors" : false,
   "allDeclaredMethods" : false,
   "allPublicMethods" : false,
   "allPublicFields" : false,
   "allDeclaredFields" : false
 }, {
-  "name" : "com.fasterxml.jackson.core.util.Separators",
+  "name" : "com.fasterxml.jackson.core.util.VersionUtil",
   "allDeclaredConstructors" : false,
   "allPublicConstructors" : false,
   "allDeclaredMethods" : false,