Skip to content

Commit f56e1e9

Browse files
authored
Changed resolv.conf handling format to make it compatible with alpine linux (#658)
1 parent 14899ff commit f56e1e9

File tree

14 files changed

+710
-15
lines changed

14 files changed

+710
-15
lines changed

RELEASE-NOTES.md

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,12 @@
1-
## 5.0.5
1+
## 5.1.0
2+
* Changed resolv.conf handling format to make it compatible with alpine linux see [#627][5_1_0_1][1].
23
* Refactoring Linux amd64 static build to work on Github Actions
34
* Creating the docs for config v3
45
* Fixing Hostname Entry Update API
56
* Fixing intermittent unit test
67

8+
[5_1_0_1]: https://github.com/mageddo/dns-proxy-server/issues/627
9+
710
## 5.0.0
811
* Refactoring config module to support config v3
912
* Activating Config v3 for beta testing

gradle.properties

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
version=5.0.5-snapshot
1+
version=5.1.0-snapshot

src/main/java/com/mageddo/dnsproxyserver/dnsconfigurator/DnsConfiguratorDefault.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ public void configure(IpAddr addr) {
3737
final var serversBefore = this.findNetworkDnsServers(network);
3838
this.serversBefore.put(network, serversBefore);
3939
final var success = this.updateDnsServers(network,
40-
Collections.singletonList(addr.getRawIP())
40+
Collections.singletonList(addr.getIpAsText())
4141
);
4242
log.debug("status=configuring, network={}, serversBefore={}, success={}", network,
4343
this.serversBefore, success

src/main/java/com/mageddo/dnsproxyserver/dnsconfigurator/linux/DnsConfiguratorLinux.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,7 @@ public void configure(IpAddr addr) {
5858

5959
if (confFile.isResolvconf()) {
6060
final var overrideNameServers = this.isOverrideNameServersActive();
61-
ResolvconfConfigurator.process(confFile.getPath(), addr, overrideNameServers);
61+
ResolvconfConfiguratorV2.process(confFile.getPath(), addr, overrideNameServers);
6262
} else if (confFile.isResolved()) {
6363
this.configureResolved(addr, confFile);
6464
} else {
@@ -82,7 +82,7 @@ public void restore() {
8282

8383
final var confFile = this.getConfFile();
8484
if (confFile.isResolvconf()) {
85-
ResolvconfConfigurator.restore(confFile.getPath());
85+
ResolvconfConfiguratorV2.restore(confFile.getPath());
8686
} else if (confFile.isResolved()) {
8787
ResolvedConfigurator.restore(confFile.getPath());
8888
tryRestartResolved();

src/main/java/com/mageddo/dnsproxyserver/dnsconfigurator/linux/LinuxResolverConfDetector.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@
88
import com.mageddo.dnsproxyserver.dnsconfigurator.linux.ResolvFile.Type;
99

1010
public class LinuxResolverConfDetector {
11+
1112
public static Type detect(Path path) {
1213

1314
if (isSystemdResolved(path)) {

src/main/java/com/mageddo/dnsproxyserver/dnsconfigurator/linux/ResolvconfConfigurator.java

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,10 @@
88
import com.mageddo.dnsproxyserver.utils.Dns;
99
import com.mageddo.net.IpAddr;
1010

11+
/**
12+
* @deprecated deprecated because of #627, use {@link ResolvconfConfiguratorV2}
13+
*/
14+
@Deprecated
1115
public class ResolvconfConfigurator {
1216

1317
public static void process(Path confFile, IpAddr addr) {

0 commit comments

Comments
 (0)