Coding standart improvements

Author: ihorvansach

Api/SitemapConfigInterface.php

@@ -35,5 +35,4 @@ public function getFrequency($page);
      * @return float
      */
     public function getPriority($page);
-
-}
+}

Block/Adminhtml/Post/Helper/Form/Gallery/Content.php

@@ -49,7 +49,8 @@ public function __construct(
             /* Try for old magento version where ImageUploadConfigDataProvider does not exist */
             $this->imageUploadConfigDataProvider = $imageUploadConfigDataProvider
                 ?: ObjectManager::getInstance()->get(\Magento\Backend\Block\DataProviders\ImageUploadConfig::class);
-        } catch (\Exception $e) {}
+        } catch (\Exception $e) {
+        }
     }
 
     /**

Block/Tag/PostList.php

@@ -61,7 +61,6 @@ protected function _prepareLayout()
                     $robots = $this->config->getTagRobots();
                     $this->pageConfig->setRobots($robots);
                 }
-
             }
 
             if ($this->config->getDisplayCanonicalTag(\Magefan\Blog\Model\Config::CANONICAL_PAGE_TYPE_TAG)) {

Model/Config.php

@@ -120,9 +120,9 @@ public function __construct(
     public function getAuthorRobots($storeId = null)
     {
         return $this->getConfig(
-                self::XML_AUTHOR_ROBOTS,
-                $storeId
-            );
+            self::XML_AUTHOR_ROBOTS,
+            $storeId
+        );
     }
 
     /**
@@ -133,9 +133,9 @@ public function getAuthorRobots($storeId = null)
     public function getTagRobots($storeId = null)
     {
         return $this->getConfig(
-                self::XML_TAG_ROBOTS,
-                $storeId
-            );
+            self::XML_TAG_ROBOTS,
+            $storeId
+        );
     }
 
     /**
@@ -146,9 +146,9 @@ public function getTagRobots($storeId = null)
     public function getSearchRobots($storeId = null)
     {
         return $this->getConfig(
-                self::XML_SEARCH_ROBOTS,
-                $storeId
-            );
+            self::XML_SEARCH_ROBOTS,
+            $storeId
+        );
     }
 
     /**

Model/Config/Source/TagRobots.php

@@ -22,7 +22,7 @@ class TagRobots extends Robots
     public function toOptionArray()
     {
         $options = parent::toOptionArray();
-        array_unshift($options,  ['value' => '', 'label' => 'Use config settings']);
+        array_unshift($options, ['value' => '', 'label' => 'Use config settings']);
         return $options;
     }
-}
+}

Model/ImageUploader.php

@@ -71,7 +71,7 @@ public function moveFileFromTmp($imageName)
             $i++;
             $p = mb_strrpos($originalImageName, '.');
             if (false !== $p) {
-                $imageName = mb_substr($originalImageName, 0, $p) . $i .  mb_substr($originalImageName,  $p);
+                $imageName = mb_substr($originalImageName, 0, $p) . $i .  mb_substr($originalImageName, $p);
             } else {
                 $imageName = $originalImageName . $i;
             }

Model/Import/Mageplaza.php

@@ -223,10 +223,8 @@ public function execute()
             $t_result = $this->_mysqliQuery($t_sql);
 
             while ($t_data = mysqli_fetch_assoc($t_result)) {
-
                 $oldId = $t_data['tag_id'];
                 if (isset($oldTags[$oldId])) {
-
                     $id = $oldTags[$oldId]->getId();
                     $postTags[$id] = $id;
                 }
@@ -270,8 +268,6 @@ public function execute()
                 $resultComments = $this->_mysqliQuery($sql);
 
                 while ($comments = mysqli_fetch_assoc($resultComments)) {
-
-
                     $commentData = [
                         'parent_id' => 0,
                         'post_id' => $post->getPostId(),

Model/Post.php

@@ -475,7 +475,6 @@ public function getShortFilteredContent($len = null, $endСharacters = null)
             }
 
             if ($len) {
-
                 /* Do not cut words */
                 while ($len < strlen($content)
                     && !in_array($content{$len}, [' ', '<', "\t", "\r", "\n"]) ) {

Model/ResourceModel/Post/Collection.php

@@ -33,11 +33,6 @@ class Collection extends \Magento\Framework\Model\ResourceModel\Db\Collection\Ab
      */
     protected $category;
 
-    /**
-     * @var \Magento\Framework\Event\ManagerInterface
-     */
-    protected $eventManager;
-
     /**
      * @param \Magento\Framework\Data\Collection\EntityFactory $entityFactory
      * @param \Psr\Log\LoggerInterface $logger
@@ -59,7 +54,6 @@ public function __construct(
         \Magento\Framework\Model\ResourceModel\Db\AbstractDb $resource = null
     ) {
         parent::__construct($entityFactory, $logger, $fetchStrategy, $eventManager, $connection, $resource);
-        $this->eventManager = $eventManager;
         $this->_date = $date;
         $this->_storeManager = $storeManager;
     }
@@ -393,16 +387,16 @@ protected function _afterLoad()
      *
      * @return void
      */
-    protected function _renderFiltersBefore() {
+    protected function _renderFiltersBefore()
+    {
         foreach (['store', 'category', 'tag'] as $key) {
             if ($this->getFilter($key)) {
-
                 $joinOptions = new \Magento\Framework\DataObject;
                 $joinOptions->setData([
                     'key' => $key,
                     'fields' => [],
                 ]);
-                $this->eventManager->dispatch('mfblog_post_collection_render_filter_join', ['join_options' => $joinOptions]);
+                $this->_eventManager->dispatch('mfblog_post_collection_render_filter_join', ['join_options' => $joinOptions]);
                 $this->getSelect()->join(
                     [$key.'_table' => $this->getTable('magefan_blog_post_'.$key)],
                     'main_table.post_id = '.$key.'_table.post_id',

Model/Sitemap/SitemapConfig.php

@@ -68,4 +68,4 @@ public function getPriority($page)
         }
         return $priority;
     }
-}
+}