Added suffix for tags and authors URLs

Author: ihorvansach

Controller/Router.php

@@ -84,24 +84,9 @@ class Router implements \Magento\Framework\App\RouterInterface
     protected $_response;
 
     /**
-     * @var array
+     * @var array;
      */
-    protected $_postId;
-
-    /**
-     * @var array
-     */
-    protected $_categoryId;
-
-    /**
-     * @var int
-     */
-    protected $_authorId;
-
-    /**
-     * @var int
-     */
-    protected $_tagId;
+    protected $ids;
 
     /**
      * @param \Magento\Framework\App\ActionFactory $actionFactory
@@ -125,7 +110,8 @@ public function __construct(
         \Magefan\Blog\Model\TagFactory $tagFactory,
         \Magento\Store\Model\StoreManagerInterface $storeManager,
         \Magento\Framework\App\ResponseInterface $response
-    ) {
+    )
+    {
         $this->actionFactory = $actionFactory;
         $this->_eventManager = $eventManager;
         $this->_url = $url;
@@ -330,22 +316,12 @@ public function match(\Magento\Framework\App\RequestInterface $request)
      */
     protected function _getPostId($identifier, $checkSufix = true)
     {
-        $key = $identifier . ($checkSufix ? '-checksufix' : '');
-        if (!isset($this->_postId[$key])) {
-            $sufix = $this->_url->getUrlSufix(Url::CONTROLLER_POST);
-            $trimmedIdentifier = $this->_url->trimSufix($identifier, $sufix);
-            if ($checkSufix && $sufix && $trimmedIdentifier == $identifier) { //if url without sufix
-                $this->_postId[$key] = 0;
-            } else {
-                $post = $this->_postFactory->create();
-                $this->_postId[$key] = $post->checkIdentifier(
-                    $trimmedIdentifier,
-                    $this->_storeManager->getStore()->getId()
-                );
-            }
-        }
-
-        return $this->_postId[$key];
+        return $this->getObjectId(
+            $this->_postFactory,
+            Url::CONTROLLER_POST,
+            $identifier,
+            $checkSufix
+        );
     }
 
     /**
@@ -355,58 +331,73 @@ protected function _getPostId($identifier, $checkSufix = true)
      */
     protected function _getCategoryId($identifier, $checkSufix = true)
     {
-        $key = $identifier . ($checkSufix ? '-checksufix' : '');
-        if (!isset($this->_categoryId[$key])) {
-            $sufix = $this->_url->getUrlSufix(Url::CONTROLLER_CATEGORY);
-
-            $trimmedIdentifier = $this->_url->trimSufix($identifier, $sufix);
-
-            if ($checkSufix && $sufix && $trimmedIdentifier == $identifier) { //if url without sufix
-                $this->_categoryId[$key] = 0;
-            } else {
-                $category = $this->_categoryFactory->create();
-                $this->_categoryId[$key] = $category->checkIdentifier(
-                    $trimmedIdentifier,
-                    $this->_storeManager->getStore()->getId()
-                );
-            }
-        }
-
-        return $this->_categoryId[$key];
+        return $this->getObjectId(
+            $this->_categoryFactory,
+            Url::CONTROLLER_CATEGORY,
+            $identifier,
+            $checkSufix
+        );
     }
 
     /**
      * Retrieve category id by identifier
-     * @param  string $identifier
+     * @param string $identifier
+     * @param bool $checkSufix
      * @return int
      */
-    protected function _getAuthorId($identifier)
+    protected function _getAuthorId($identifier, $checkSufix = true)
     {
-        if (is_null($this->_authorId)) {
-            $author = $this->_authorFactory->create();
-            $this->_authorId = $author->checkIdentifier(
-                $identifier
-            );
-        }
-
-        return $this->_authorId;
+        return $this->getObjectId(
+            $this->_authorFactory,
+            Url::CONTROLLER_AUTHOR,
+            $identifier,
+            $checkSufix
+        );
     }
 
     /**
      * Retrieve tag id by identifier
-     * @param  string $identifier
+     * @param string $identifier
+     * @param bool $checkSufix
      * @return int
      */
-    protected function _getTagId($identifier)
+    protected function _getTagId($identifier, $checkSufix = true)
     {
-        if (is_null($this->_tagId)) {
-            $tag = $this->_tagFactory->create();
-            $this->_tagId = $tag->checkIdentifier(
-                $identifier
-            );
+        return $this->getObjectId(
+            $this->_tagFactory,
+            Url::CONTROLLER_TAG,
+            $identifier,
+            $checkSufix
+        );
+    }
+
+    /**
+     * @param $factory
+     * @param string $controllerName
+     * @param string $identifier
+     * @param bool $checkSufix
+     * @return mixed
+     */
+    protected function getObjectId($factory, $controllerName, $identifier, $checkSufix)
+    {
+        $key =  $controllerName . '-' .$identifier . ($checkSufix ? '-checksufix' : '');
+        if (!isset($this->ids[$key])) {
+            $sufix = $this->_url->getUrlSufix($controllerName);
+
+            $trimmedIdentifier = $this->_url->trimSufix($identifier, $sufix);
+
+            if ($checkSufix && $sufix && $trimmedIdentifier == $identifier) { //if url without sufix
+                $this->ids[$key] = 0;
+            } else {
+                $object = $factory->create();
+                $this->ids[$key] = $object->checkIdentifier(
+                    $trimmedIdentifier,
+                    $this->_storeManager->getStore()->getId()
+                );
+            }
         }
 
-        return $this->_tagId;
+        return $this->ids[$key];
     }
 
     /**

Model/Url.php

@@ -265,7 +265,12 @@ protected function getExpandedItentifier($identifier)
      */
     protected function addUrlSufix($url, $controllerName)
     {
-        if (in_array($controllerName, [self::CONTROLLER_POST, self::CONTROLLER_CATEGORY])) {
+        if (in_array($controllerName, [
+            self::CONTROLLER_POST,
+            self::CONTROLLER_CATEGORY,
+            self::CONTROLLER_AUTHOR,
+            self::CONTROLLER_TAG
+        ])) {
             if ($sufix = $this->getUrlSufix($controllerName)) {
                 $char = false;
                 foreach (['#', '?'] as $ch) {

etc/adminhtml/system.xml

@@ -387,10 +387,18 @@
                     <label>Tag Route</label>
                     <comment>E.g.: "tag" will make the blog posts by tag accessible from mystore.com/{blog_route}/tag/tag-name/</comment>
                 </field>
+                <field id="tag_sufix" translate="label comment" type="text" sortOrder="56" showInDefault="1" showInWebsite="1" showInStore="1">
+                    <label>Tag URL Suffix</label>
+                    <comment>E.g.: ".html" will make the blog tag accessible from mystore.com/{blog_route}/tag/tag-name.html</comment>
+                </field>
                 <field id="author_route" translate="label comment" type="text" sortOrder="60" showInDefault="1" showInWebsite="1" showInStore="1">
                     <label>Author Route</label>
                     <comment>E.g.: "author" will make the blog author posts accessible from mystore.com/{blog_route}/author/author-name/</comment>
                 </field>
+                <field id="author_sufix" translate="label comment" type="text" sortOrder="61" showInDefault="1" showInWebsite="1" showInStore="1">
+                    <label>Author URL Suffix</label>
+                    <comment>E.g.: ".html" will make the blog author accessible from mystore.com/{blog_route}/author/author-name.html</comment>
+                </field>
                 <field id="search_route" translate="label comment" type="text" sortOrder="70" showInDefault="1" showInWebsite="1" showInStore="1">
                     <label>Search Route</label>
                     <comment>E.g.: "search" will make the blog search accessible from mystore.com/{blog_route}/search/query/</comment>