Merge pull request #403 from magefan/5564-Sitemap-Query-Amasty

5564-Sitemap-Query-Amasty

Author: magefan

Model/Sitemap.php

@@ -135,7 +135,7 @@ public function save()
      */
     public function getSitemapPath(): string
     {
-        $path = $this->getData('sitemap_path');
+        $path = (string)$this->getData('sitemap_path');
         if ($serverPath = $this->getServerPath()) {
             if (!$this->_directory->isDirectory($serverPath)) {
                 $serverPath = BP . '/' . $serverPath;

Plugin/Magento/Sitemap/SitemapPlugin.php

@@ -75,24 +75,40 @@ public function __construct(
     public function afterGenerateXml(\Magento\Framework\Model\AbstractModel $sitemap, $result)
     {
         if ($this->isEnabled($sitemap)) {
-            /* if ($this->isMageWorxXmlSitemap($sitemap) || !method_exists($sitemap, 'collectSitemapItems')) { */
-                $sitemapId = $sitemap->getId() ?: 0;
+            $sitemapId = $sitemap->getId() ?: 0;
             if (in_array($sitemapId, $this->generated)) {
                 return $result;
             }
-                $this->generated[] = $sitemapId;
+            $this->generated[] = $sitemapId;
 
-                $blogSitemap = $this->sitemapFactory->create();
-                $blogSitemap->setData(
-                    $sitemap->getData()
-                );
+            $blogSitemap = $this->sitemapFactory->create();
+            $blogSitemap->setData(
+                $sitemap->getData()
+            );
 
-                $blogSitemap->setSitemapFilename(
-                    'blog_' . $sitemap->getSitemapFilename()
-                );
+            if (!$blogSitemap->getSitemapId() && $sitemap->getId()) {
+                $blogSitemap->setSitemapId($sitemap->getId());
+            }
+
+            /* Fix for Amasty\XmlSitemap\Model\Sitemap */
+            if ($sitemap->getFolderName()) {
+                $filename = pathinfo($sitemap->getFolderName());
+                if (!$blogSitemap->getSitemapFilename()) {
+                    if (isset($filename['basename'])) {
+                        $blogSitemap->setSitemapFilename($filename['basename']);
+                    }
+                }
+                if (!$blogSitemap->getSitemapPath()) {
+                    if (isset($filename['dirname'])) {
+                        $blogSitemap->setSitemapPath($filename['dirname']);
+                    }
+                }
+            }
 
-                $blogSitemap->generateXml();
-            /* } */
+            $blogSitemap->setSitemapFilename(
+                'blog_' . $blogSitemap->getSitemapFilename()
+            );
+            $blogSitemap->generateXml();
         }
         return $result;
     }

etc/di.xml

@@ -60,6 +60,11 @@
                 type="Magefan\Blog\Plugin\Magento\Sitemap\SitemapPlugin" sortOrder="10"/>
     </type>
 
+    <type name="Amasty\XmlSitemap\Model\Sitemap">
+        <plugin name="amasty_sitemap_model_sitemap_magefan_blog"
+                type="Magefan\Blog\Plugin\Magento\Sitemap\SitemapPlugin" sortOrder="10"/>
+    </type>
+
     <type name="Magento\AdminGws\Model\Models">
         <plugin name="magefan_blog_plugin_admingws_model_models_plugin" type="\Magefan\Blog\Plugin\Magento\AdminGws\Model\ModelsPlugin" sortOrder="10"/>
     </type>