Minor improvements

Author: ihorvansach

Controller/Adminhtml/Container/Generate.php

@@ -106,11 +106,13 @@ public function execute()
         /** @var Redirect $resultRedirect */
         $resultRedirect = $this->resultFactory->create(ResultFactory::TYPE_REDIRECT);
 
+        /* Ability to generate JSON file even if the module is disabled.
         if (!$this->config->isEnabled()) {
             $this->messageManager
                 ->addErrorMessage(__('To generate a JSON container, please enable the extension first.'));
             return $resultRedirect->setPath($this->redirect->getRefererUrl());
         }
+        */
 
         try {
             $storeId = (string)$this->getRequest()->getParam('store_id') ?: null;

composer.json

@@ -9,7 +9,7 @@
             "email": "[email protected]"
         }
     ],
-    "version": "2.0.3",
+    "version": "2.1.0",
     "require": {
         "magefan/module-community" : ">=2.1.13"
     },

etc/adminhtml/system.xml

@@ -33,15 +33,15 @@
                 <field id="account_id" translate="label comment" type="text" sortOrder="50" showInDefault="1" showInWebsite="1" showInStore="1">
                     <label>Account ID</label>
                     <comment><![CDATA[
-                            <p>Please get the Google Tag Manager account ID from the GTM Workspace URL path. E.g.<br/>
+                            <p>Please get the <a href="https://tagmanager.google.com/" title="Google Tag Manager" target="_blank">Google Tag Manager</a> account ID from the GTM Workspace URL path. E.g.<br/>
                             <pre style="border: 1px dashed #5f5f5f;padding: 5px;background: #f4f4f4;">https://tagmanager.google.com/#/container/accounts/<strong>XXXXXXXXXX</strong>/containers/XXXXXXXXX</pre></p>
                         ]]>
                     </comment>
                 </field>
                 <field id="container_id" translate="label comment" type="text" sortOrder="60" showInDefault="1" showInWebsite="1" showInStore="1">
                     <label>Container ID</label>
                     <comment><![CDATA[
-                            <p>Please get the Google Tag Manager container ID from the GTM Workspace URL path. E.g.<br/>
+                            <p>Please get the <a href="https://tagmanager.google.com/" title="Google Tag Manager" target="_blank">Google Tag Manager</a> container ID from the GTM Workspace URL path. E.g.<br/>
                             <pre style="border: 1px dashed #5f5f5f;padding: 5px;background: #f4f4f4;">https://tagmanager.google.com/#/container/accounts/XXXXXXXXXX/containers/<strong>XXXXXXXXX</strong></pre></p>
                         ]]>
                     </comment>

view/adminhtml/templates/system/config/button/button.phtml

@@ -22,6 +22,10 @@ if (!isset($escaper)) {
         <button type="button" id="mf_download">
             <?= $escaper->escapeHtml(__('Generate JSON Container & Download File')); ?>
         </button>
+        <p>
+            <br/>
+            <?= __('Once the JSON file is downloaded, upload it to %1 > Choose Container > Admin > Import Container.', '<a href="https://tagmanager.google.com/" title="Google Tag Manager" target="_blank">Google Tag Manager</a>') ?>
+        </p>
         <script>
             require([
                 'jquery',