Skip to content

Commit 9142d7a

Browse files
committed
Refactor 10738-Third-Party-Google-Analytics-and-AdWords
1 parent 55ad975 commit 9142d7a

File tree

3 files changed

+16
-7
lines changed

3 files changed

+16
-7
lines changed

etc/adminhtml/system.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -374,7 +374,7 @@ To create a new secret, navigate in the
374374
<label>Third-Party Google Analytics and AdWords</label>
375375
<field id="enabled" translate="label comment" type="select" sortOrder="10" showInDefault="1" showInWebsite="1" showInStore="1" canRestore="1">
376376
<label>Enable</label>
377-
<comment>If enabled Magefan Google Tag Manager Extension will not prevent the execution of default Magento and custom javascripts for Google Analytics, AdWords, and GTM. Please note that this can lead to event duplications and double tracking.</comment>
377+
<comment>If disabled, Magefan Google Tag Manager Extension prevents the execution of default Magento and custom JavaScripts for Google Analytics, AdWords, and GTM. Please note that enabling this option can lead to event duplications and double tracking.</comment>
378378
<source_model>Magento\Config\Model\Config\Source\Yesno</source_model>
379379
</field>
380380
</group>

etc/di.xml

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -22,10 +22,4 @@
2222
<argument name="container" xsi:type="object">Magefan\GoogleTagManager\Model\WebContainer</argument>
2323
</arguments>
2424
</type>
25-
<type name="Magento\Framework\App\Config\ScopeConfigInterface">
26-
<plugin name="Plugin_Magefan_GoogleTagManager_ScopeConfigInterface" type="Magefan\GoogleTagManager\Plugin\Magento\Framework\App\Config\ScopeConfig" sortOrder="10" disabled="false"/>
27-
</type>
28-
<type name="Magento\Customer\CustomerData\Customer">
29-
<plugin name="Magefan_GoogleTagManager_Plugin_Magento_Customer_CustomerData_Customer" type="Magefan\GoogleTagManager\Plugin\Magento\Customer\CustomerData\Customer" sortOrder="10" disabled="false"/>
30-
</type>
3125
</config>

etc/frontend/di.xml

Lines changed: 15 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,15 @@
1+
<?xml version="1.0" ?>
2+
<!--
3+
/**
4+
* Copyright © Magefan ([email protected]). All rights reserved.
5+
* Please visit Magefan.com for license details (https://magefan.com/end-user-license-agreement).
6+
*/
7+
-->
8+
<config xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:noNamespaceSchemaLocation="urn:magento:framework:ObjectManager/etc/config.xsd">
9+
<type name="Magento\Framework\App\Config\ScopeConfigInterface">
10+
<plugin name="Plugin_Magefan_GoogleTagManager_ScopeConfigInterface" type="Magefan\GoogleTagManager\Plugin\Magento\Framework\App\Config\ScopeConfig" sortOrder="10" disabled="false"/>
11+
</type>
12+
<type name="Magento\Customer\CustomerData\Customer">
13+
<plugin name="Magefan_GoogleTagManager_Plugin_Magento_Customer_CustomerData_Customer" type="Magefan\GoogleTagManager\Plugin\Magento\Customer\CustomerData\Customer" sortOrder="10" disabled="false"/>
14+
</type>
15+
</config>

0 commit comments

Comments
 (0)