MAGECLOUD-4849: Not full error log on failed execution of shell command (magento#654)

Author: oshmyheliuk

src/Shell/Process.php

@@ -38,7 +38,7 @@ public function execute()
             $error = sprintf(
                 'The command "%s" failed. %s',
                 $process->getCommandLine(),
-                trim($process->getErrorOutput(), "\n")
+                trim($process->getErrorOutput() ?: $process->getOutput(), "\n")
             );
 
             throw new ProcessException($error, $process->getExitCode());

src/Step/PostDeploy/TimeToFirstByte.php

@@ -7,6 +7,7 @@
 
 namespace Magento\MagentoCloud\Step\PostDeploy;
 
+use GuzzleHttp\Promise\PromiseInterface;
 use GuzzleHttp\RequestOptions;
 use Magento\MagentoCloud\Config\Stage\PostDeployInterface;
 use Magento\MagentoCloud\Http\PoolFactory;
@@ -82,7 +83,9 @@ public function execute()
                 'concurrency' => 1,
             ]);
 
-            $pool->promise()->wait();
+            /** @var PromiseInterface $promise */
+            $promise = $pool->promise();
+            $promise->wait();
         } catch (\Throwable $exception) {
             throw new StepException($exception->getMessage(), $exception->getCode(), $exception);
         }

src/Step/PostDeploy/WarmUp.php

@@ -8,6 +8,7 @@
 namespace Magento\MagentoCloud\Step\PostDeploy;
 
 use GuzzleHttp\Exception\RequestException;
+use GuzzleHttp\Promise\PromiseInterface;
 use Magento\MagentoCloud\Http\PoolFactory;
 use Magento\MagentoCloud\WarmUp\Urls;
 use Magento\MagentoCloud\Step\StepException;
@@ -85,7 +86,9 @@ public function execute()
         try {
             $pool = $this->poolFactory->create($urls, compact('fulfilled', 'rejected'));
 
-            $pool->promise()->wait();
+            /** @var PromiseInterface $promise */
+            $promise = $pool->promise();
+            $promise->wait();
         } catch (\Throwable $exception) {
             throw new StepException($exception->getMessage(), $exception->getCode(), $exception);
         }

src/Test/Functional/Acceptance/ErrorMessageCest.php

@@ -0,0 +1,39 @@
+<?php
+/**
+ * Copyright © Magento, Inc. All rights reserved.
+ * See COPYING.txt for license details.
+ */
+declare(strict_types=1);
+
+namespace Magento\MagentoCloud\Test\Functional\Acceptance;
+
+use CliTester;
+use Magento\MagentoCloud\Test\Functional\Codeception\Docker;
+
+/**
+ * This test runs on the latest version of PHP
+ */
+class ErrorMessageCest extends AbstractCest
+{
+    /**
+     * @param CliTester $I
+     * @throws \Robo\Exception\TaskException
+     */
+    public function _before(CliTester $I)
+    {
+        parent::_before($I);
+        $I->cloneTemplate();
+        $I->addEceComposerRepo();
+    }
+
+    /**
+     * @param CliTester $I
+     * @throws \Robo\Exception\TaskException
+     */
+    public function testShellErrorMessage(CliTester $I)
+    {
+        $I->cleanDirectories(['/bin/*']);
+        $I->assertFalse($I->runEceToolsCommand('build', Docker::BUILD_CONTAINER));
+        $I->seeInOutput('Could not open input file: ./bin/magento');
+    }
+}