Skip to content

Commit db439e7

Browse files
author
Oleksandr Gorkun
committed
MC-18685: Remove custom layout updates from admin
1 parent af80271 commit db439e7

File tree

2 files changed

+9
-16
lines changed

2 files changed

+9
-16
lines changed

app/code/Magento/CatalogSampleData/Model/Attribute.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -108,7 +108,7 @@ public function install(array $fixtures)
108108
foreach ($rows as $row) {
109109
$data = [];
110110
foreach ($row as $key => $value) {
111-
$data[$header[$key]] = $value;
111+
$data[$header[$key]] = trim($value);
112112
}
113113
$data['attribute_set'] = explode("\n", $data['attribute_set']);
114114

app/code/Magento/ConfigurableSampleData/Model/Product.php

Lines changed: 8 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@
55
*/
66
namespace Magento\ConfigurableSampleData\Model;
77

8-
use Magento\Framework\App\ObjectManager;
98
use Magento\Framework\Component\ComponentRegistrar;
109
use Magento\Framework\Filesystem\Directory\ReadFactory;
1110
use Magento\ImportExport\Model\Import;
@@ -16,6 +15,11 @@
1615
*/
1716
class Product
1817
{
18+
/**
19+
* @var Import
20+
*/
21+
private $importModel;
22+
1923
/**
2024
* @var \Magento\ImportExport\Model\Import\Source\CsvFactory
2125
*/
@@ -36,11 +40,6 @@ class Product
3640
*/
3741
private $componentRegistrar;
3842

39-
/**
40-
* @var \Magento\ImportExport\Model\ImportFactory
41-
*/
42-
private $importFactory;
43-
4443
/**
4544
* @var \Magento\Eav\Model\Config
4645
*/
@@ -53,37 +52,31 @@ class Product
5352
* @param \Magento\Indexer\Model\Indexer\CollectionFactory $indexerCollectionFactory
5453
* @param \Magento\Framework\Filesystem\Directory\ReadFactory $readFactory
5554
* @param \Magento\Framework\Component\ComponentRegistrar $componentRegistrar
56-
* @param \Magento\ImportExport\Model\ImportFactory|null $importFactory
5755
*/
5856
public function __construct(
5957
\Magento\Eav\Model\Config $eavConfig,
6058
Import $importModel,
6159
\Magento\ImportExport\Model\Import\Source\CsvFactory $csvSourceFactory,
6260
\Magento\Indexer\Model\Indexer\CollectionFactory $indexerCollectionFactory,
6361
\Magento\Framework\Filesystem\Directory\ReadFactory $readFactory,
64-
\Magento\Framework\Component\ComponentRegistrar $componentRegistrar,
65-
?\Magento\ImportExport\Model\ImportFactory $importFactory = null
62+
\Magento\Framework\Component\ComponentRegistrar $componentRegistrar
6663
) {
6764
$this->eavConfig = $eavConfig;
65+
$this->importModel = $importModel;
6866
$this->csvSourceFactory = $csvSourceFactory;
6967
$this->indexerCollectionFactory = $indexerCollectionFactory;
7068
$this->readFactory = $readFactory;
7169
$this->componentRegistrar = $componentRegistrar;
72-
$this->importFactory = $importFactory
73-
?? ObjectManager::getInstance()->get(\Magento\ImportExport\Model\ImportFactory::class);
7470
}
7571

7672
/**
7773
* @inheritdoc
7874
*/
7975
public function install()
8076
{
81-
\Magento\CatalogImportExport\Model\Import\Product\Type\AbstractType::$attributeCodeToId = [];
82-
\Magento\CatalogImportExport\Model\Import\Product\Type\AbstractType::$commonAttributesCache = [];
83-
\Magento\CatalogImportExport\Model\Import\Product\Type\AbstractType::$invAttributesCache = [];
8477
$this->eavConfig->clear();
8578
/** @var Import $importModel */
86-
$importModel = $this->importFactory->create();
79+
$importModel = $this->importModel;
8780
$importModel->setData(
8881
[
8982
'entity' => 'catalog_product',

0 commit comments

Comments
 (0)