MAGETWO-42918: Deploy SD to public

Author: Alex Bomko

app/code/Magento/ConfigurableSampleData/Model/Product.php

@@ -5,7 +5,8 @@
  */
 namespace Magento\ConfigurableSampleData\Model;
 
-use Magento\Framework\App\Filesystem\DirectoryList;
+use Magento\Framework\Component\ComponentRegistrar;
+use Magento\Framework\Filesystem\Directory\ReadFactory;
 use Magento\ImportExport\Model\Import;
 use Magento\ImportExport\Model\Import\ErrorProcessing\ProcessingErrorAggregatorInterface;
 
@@ -25,34 +26,42 @@ class Product
     private $csvSourceFactory;
 
     /**
-     * @var \Magento\Framework\Filesystem
+     * @var \Magento\Framework\Filesystem\Directory\ReadFactory
      */
-    private $filesystem;
+    private $readFactory;
 
     /**
      * @var \Magento\Indexer\Model\Indexer\CollectionFactory
      */
     private $indexerCollectionFactory;
 
+    /**
+     * @var \Magento\Framework\Component\ComponentRegistrar
+     */
+    private $componentRegistrar;
+
     /**
      * @param \Magento\Eav\Model\Config $eavConfig
      * @param \Magento\ImportExport\Model\Import $importModel
      * @param \Magento\ImportExport\Model\Import\Source\CsvFactory $csvSourceFactory
      * @param \Magento\Indexer\Model\Indexer\CollectionFactory $indexerCollectionFactory
-     * @param \Magento\Framework\Filesystem $filesystem
+     * @param \Magento\Framework\Filesystem\Directory\ReadFactory $readFactory
+     * @param \Magento\Framework\Component\ComponentRegistrar $componentRegistrar
      */
     public function __construct(
         \Magento\Eav\Model\Config $eavConfig,
         \Magento\ImportExport\Model\Import $importModel,
         \Magento\ImportExport\Model\Import\Source\CsvFactory $csvSourceFactory,
         \Magento\Indexer\Model\Indexer\CollectionFactory $indexerCollectionFactory,
-        \Magento\Framework\Filesystem $filesystem
+        \Magento\Framework\Filesystem\Directory\ReadFactory $readFactory,
+        \Magento\Framework\Component\ComponentRegistrar $componentRegistrar
     ) {
         $this->eavConfig = $eavConfig;
         $this->importModel = $importModel;
         $this->csvSourceFactory = $csvSourceFactory;
         $this->indexerCollectionFactory = $indexerCollectionFactory;
-        $this->filesystem = $filesystem;
+        $this->filesystem = $readFactory;
+        $this->componentRegistrar = $componentRegistrar;
     }
 
     /**
@@ -73,14 +82,15 @@ public function install()
 
         $source = $this->csvSourceFactory->create(
             [
-                'file' => 'Magento/ConfigurableSampleData/fixtures/products.csv',
-                'directory' => $this->filesystem->getDirectoryWrite(DirectoryList::MODULES)
+                'file' => 'fixtures/products.csv',
+                'directory' => $this->readFactory->create(
+                    $this->componentRegistrar->getPath(ComponentRegistrar::MODULE, 'Magento_SampleData')
+                )
             ]
         );
 
         $currentPath = getcwd();
-        chdir($this->filesystem->getDirectoryRead(DirectoryList::ROOT)->getAbsolutePath());
-
+        chdir(BP);
         $importModel->validateSource($source);
         $importModel->importSource();
 

app/code/Magento/SalesSampleData/Model/Order/Processor.php

@@ -262,10 +262,6 @@ protected function refundOrder(\Magento\Sales\Model\Order\Item $orderItem)
         if ($creditmemo && $creditmemo->isValidGrandTotal()) {
             $creditmemo->setOfflineRequested(true);
             $this->creditmemoManagement->refund($creditmemo, true);
-            $creditmemoTransaction = $this->transactionFactory->create()
-                ->addObject($creditmemo)
-                ->addObject($creditmemo->getOrder());
-            $creditmemoTransaction->save();
         }
     }
 
@@ -276,15 +272,6 @@ protected function refundOrder(\Magento\Sales\Model\Order\Item $orderItem)
     public function getCreditmemoData(\Magento\Sales\Model\Order\Item $orderItem)
     {
         $data = [$orderItem->getId() => $orderItem->getQtyToRefund()];
-//        foreach ($this->observerManager->getObservers() as $observer) {
-//            if (is_callable([$observer, 'getCreditmemoData'])) {
-//                $params = new DataObject([
-//                    'order_item' => $orderItem,
-//                    'credit_memo' => $data
-//                ]);
-//                $data = $observer->getCreditmemoData($params);
-//            }
-//        }
 
         return $data;
     }