MAGETWO-63855: Create functional automated for complete Signifyd flow

- Code review fixes

Author: Dmytro Yushkin

Test/Block/Adminhtml/Order/Grid.php

@@ -3,10 +3,8 @@
  * Copyright © 2013-2017 Magento, Inc. All rights reserved.
  * See COPYING.txt for license details.
  */
-
 namespace Magento\Signifyd\Test\Block\Adminhtml\Order;
 
-use Magento\Mtf\Client\Locator;
 use Magento\Ui\Test\Block\Adminhtml\DataGrid;
 
 /**

Test/Block/Adminhtml/Order/View/FraudProtection.php

@@ -6,7 +6,6 @@
 namespace Magento\Signifyd\Test\Block\Adminhtml\Order\View;
 
 use Magento\Mtf\Block\Block;
-use Magento\Mtf\Client\Locator;
 
 /**
  * Information about fraud protection on order page.
@@ -41,7 +40,7 @@ class FraudProtection extends Block
      */
     public function getCaseStatus()
     {
-        return $this->_rootElement->find($this->caseStatus, Locator::SELECTOR_CSS)->getText();
+        return $this->_rootElement->find($this->caseStatus)->getText();
     }
 
     /**
@@ -51,7 +50,7 @@ public function getCaseStatus()
      */
     public function getCaseGuaranteeDisposition()
     {
-        return $this->_rootElement->find($this->caseGuaranteeDisposition, Locator::SELECTOR_CSS)->getText();
+        return $this->_rootElement->find($this->caseGuaranteeDisposition)->getText();
     }
 
     /**
@@ -61,6 +60,6 @@ public function getCaseGuaranteeDisposition()
      */
     public function getCaseReviewDisposition()
     {
-        return $this->_rootElement->find($this->caseReviewDisposition, Locator::SELECTOR_CSS)->getText();
+        return $this->_rootElement->find($this->caseReviewDisposition)->getText();
     }
 }

Test/Block/Sandbox/CaseInfo.php

@@ -6,132 +6,167 @@
 namespace Magento\Signifyd\Test\Block\Sandbox;
 
 use Magento\Mtf\Block\Block;
-use Magento\Mtf\Client\Locator;
 
 /**
- * Block with case information.
+ * Case information block.
  */
 class CaseInfo extends Block
 {
     /**
+     * Css selector of "Flag Case As Good" button.
+     *
      * @var string
      */
-    private $flagGoodButton = '.flag-case-good';
+    private $flagCaseAsGoodButton = '[class*="flag-case-good"]';
 
     /**
+     * Css selector of guarantee status.
+     *
      * @var string
      */
-    private $guaranteeDisposition = '.guarantee-status';
+    private $guaranteeDisposition = '[class*="guarantee-status"]';
 
     /**
+     * Css selector of CVV response description.
+     *
      * @var string
      */
-    private $cvvResponseDescription = '//span[contains(@ng-bind, "caseOrderSummary.cvvResponseDescription")]';
+    private $cvvResponseDescription = '[ng-bind="caseOrderSummary.cvvResponseDescription"]';
 
     /**
+     * Css selector of CVV response code.
+     *
      * @var string
      */
-    private $cvvResponseCode = '//span[contains(@ng-bind, "caseOrderSummary.cvvResponseCode")]';
+    private $cvvResponseCode = '[ng-bind="caseOrderSummary.cvvResponseCode"]';
 
     /**
+     * Css selector of AVS response description.
+     *
      * @var string
      */
-    private $avsResponseDescription = '//span[contains(@ng-bind, "caseOrderSummary.avsResponseDescription")]';
+    private $avsResponseDescription = '[ng-bind="caseOrderSummary.avsResponseDescription"]';
 
     /**
+     * Css selector of AVS response code.
+     *
      * @var string
      */
-    private $avsResponseCode = '//span[contains(@ng-bind, "caseOrderSummary.avsResponseCode")]';
+    private $avsResponseCode = '[ng-bind="caseOrderSummary.avsResponseCode"]';
 
     /**
+     * Css selector of displayed case order id.
+     *
      * @var string
      */
-    private $orderId = '//span[contains(@ng-bind, "currentCase.caseIdDisplay")]';
+    private $orderId = '[ng-bind="currentCase.caseIdDisplay"]';
 
     /**
+     * Css selector of displayed order amount.
+     *
      * @var string
      */
-    private $orderAmount = '//span[contains(@ng-bind, "currentCase.orderAmount")]';
+    private $orderAmount = '[ng-bind*="currentCase.orderAmount"]';
 
     /**
+     * Css selector of displayed card holder name.
+     *
      * @var string
      */
-    private $cardHolder = '//a[contains(@data-dropdown, "peopleLinks0")]//span';
+    private $cardHolder = '[data-dropdown="peopleLinks0"] span';
 
     /**
+     * Css selector of displayed billing address.
+     *
      * @var string
      */
-    private $billingAddress = '//a[contains(@data-dropdown, "streetLinks0")]';
+    private $billingAddress = '[data-dropdown="streetLinks0"]';
 
     /**
+     * Flags case as good.
+     *
      * @return void
      */
-    public function flagCaseGood()
+    public function flagCaseAsGood()
     {
-        $this->_rootElement->find($this->flagGoodButton)->click();
+        $this->_rootElement->find($this->flagCaseAsGoodButton)->click();
     }
 
     /**
-     * @return array|string
+     * Gets guarantee disposition.
+     *
+     * @return string
      */
     public function getGuaranteeDisposition()
     {
         return $this->_rootElement->find($this->guaranteeDisposition)->getText();
     }
 
     /**
+     * Gets CVV response.
+     *
      * @return string
      */
     public function getCvvResponse()
     {
         return sprintf(
             '%s (%s)',
-            $this->_rootElement->find($this->cvvResponseDescription, Locator::SELECTOR_XPATH)->getText(),
-            $this->_rootElement->find($this->cvvResponseCode, Locator::SELECTOR_XPATH)->getText()
+            $this->_rootElement->find($this->cvvResponseDescription)->getText(),
+            $this->_rootElement->find($this->cvvResponseCode)->getText()
         );
     }
 
     /**
+     * Gets AVS response.
+     *
      * @return string
      */
     public function getAvsResponse()
     {
         return sprintf(
             '%s (%s)',
-            $this->_rootElement->find($this->avsResponseDescription, Locator::SELECTOR_XPATH)->getText(),
-            $this->_rootElement->find($this->avsResponseCode, Locator::SELECTOR_XPATH)->getText()
+            $this->_rootElement->find($this->avsResponseDescription)->getText(),
+            $this->_rootElement->find($this->avsResponseCode)->getText()
         );
     }
 
     /**
-     * @return array|string
+     * Gets displayed order id.
+     *
+     * @return string
      */
     public function getOrderId()
     {
-        return $this->_rootElement->find($this->orderId, Locator::SELECTOR_XPATH)->getText();
+        return $this->_rootElement->find($this->orderId)->getText();
     }
 
     /**
-     * @return array|string
+     * Gets displayed order amount.
+     *
+     * @return string
      */
     public function getOrderAmount()
     {
-        return $this->_rootElement->find($this->orderAmount, Locator::SELECTOR_XPATH)->getText();
+        return $this->_rootElement->find($this->orderAmount)->getText();
     }
 
     /**
-     * @return array|string
+     * Gets displayed card holder name.
+     *
+     * @return string
      */
     public function getCardHolder()
     {
-        return $this->_rootElement->find($this->cardHolder, Locator::SELECTOR_XPATH)->getText();
+        return $this->_rootElement->find($this->cardHolder)->getText();
     }
 
     /**
-     * @return array|string
+     * Gets displayed billing address.
+     *
+     * @return string
      */
     public function getBillingAddress()
     {
-        return $this->_rootElement->find($this->billingAddress, Locator::SELECTOR_XPATH)->getText();
+        return $this->_rootElement->find($this->billingAddress)->getText();
     }
 }

Test/Block/Sandbox/CaseSearch.php

@@ -14,42 +14,56 @@
 class CaseSearch extends Form
 {
     /**
+     * Css selector of search input.
+     *
      * @var string
      */
-    private $searchInput = '#queueSearchBar';
+    private $searchBar = '[id=queueSearchBar]';
 
     /**
+     * Css selector of search submit button.
+     *
      * @var string
      */
-    private $buttonSubmit = '[type=submit]';
+    private $submitButton = '[type=submit]';
 
     /**
+     * XPath selector of first searched element in list.
+     *
      * @var string
      */
-    private $buttonCase = '//ul//li[contains(@class, "app-sidebar-item")][1]//a';
+    private $selectCaseLink = '//ul//li[contains(@class, "app-sidebar-item")][1]//a';
 
     /**
-     * @param $searchCriteria
+     * Fill search input with customer name and submit.
+     *
+     * @param string $customerName
+     * @return void
      */
-    public function fillSearchCriteria($searchCriteria)
+    public function searchCaseByCustomerName($customerName)
     {
-        $this->waitForElementVisible($this->searchInput);
-        $this->_rootElement->find($this->searchInput)->setValue($searchCriteria);
+        $this->_rootElement->find($this->searchBar)->setValue($customerName);
+        $this->_rootElement->find($this->submitButton)->click();
     }
 
     /**
+     * Select searched case.
+     *
      * @return void
      */
-    public function searchCase()
+    public function selectCase()
     {
-        $this->_rootElement->find($this->buttonSubmit)->click();
+        $this->_rootElement->find($this->selectCaseLink, Locator::SELECTOR_XPATH)->click();
     }
 
+
     /**
+     * Waiting of case page loading.
+     *
      * @return void
      */
-    public function selectCase()
+    public function waitForLoading()
     {
-        $this->_rootElement->find($this->buttonCase, Locator::SELECTOR_XPATH)->click();
+        $this->waitForElementVisible($this->searchBar);
     }
 }

Test/Block/Sandbox/SignifydLogin.php

@@ -13,18 +13,18 @@
 class SignifydLogin extends Form
 {
     /**
-     * Login button on Signifyd side.
+     * Css selector of Signifyd login button.
      *
      * @var string
      */
     private $loginButton = '[type=submit]';
 
     /**
-     * Login to Signifyd Sandbox.
+     * Login to Signifyd.
      *
      * @return void
      */
-    public function sandboxLogin()
+    public function login()
     {
         $this->_rootElement->find($this->loginButton)->click();
     }