MAGETWO-63855: Create functional automated for complete Signifyd flow

Author: Dmytro Yushkin

Test/Block/Sandbox/CaseSearch.php

@@ -6,7 +6,6 @@
 namespace Magento\Signifyd\Test\Block\Sandbox;
 
 use Magento\Mtf\Block\Form;
-use Magento\Mtf\Client\Locator;
 
 /**
  * Side block with case search and cases list.
@@ -28,11 +27,11 @@ class CaseSearch extends Form
     private $submitButton = '[type=submit]';
 
     /**
-     * XPath selector of first searched element in list.
+     * Css selector of searched element in cases list.
      *
      * @var string
      */
-    private $selectCaseLink = '//ul//li[contains(@class, "app-sidebar-item")][1]//a';
+    private $selectCaseLink = 'ul[case-list=cases] li[case-list-case=case] a';
 
     /**
      * Fill search input with customer name and submit.
@@ -53,10 +52,9 @@ public function searchCaseByCustomerName($customerName)
      */
     public function selectCase()
     {
-        $this->_rootElement->find($this->selectCaseLink, Locator::SELECTOR_XPATH)->click();
+        $this->_rootElement->find($this->selectCaseLink)->click();
     }
 
-
     /**
      * Waiting of case page loading.
      *

Test/Block/Sandbox/WebhookAdd.php

@@ -67,7 +67,7 @@ class WebhookAdd extends Form
      * @param array $signifydData
      * @return void
      */
-    public function createWebhooks($signifydData)
+    public function createWebhooks(array $signifydData)
     {
         foreach ($this->webhookEventOptionsMap as $webhookEventCode => $webhookEventName) {
             $this->setEvent($webhookEventCode);

Test/Constraint/AssertCaseInfoOnBackend.php

@@ -58,7 +58,7 @@ public function processAssert(
     }
 
     /**
-     * Checks that case status matches.
+     * Checks case status is correct.
      *
      * @return void
      */
@@ -72,7 +72,7 @@ private function checkCaseStatus()
     }
 
     /**
-     * Checks that case guarantee disposition matches.
+     * Checks case guarantee disposition is correct.
      *
      * @return void
      */
@@ -86,7 +86,7 @@ private function checkCaseGuaranteeDisposition()
     }
 
     /**
-     * Checks that case review disposition matches.
+     * Checks case review disposition is correct.
      *
      * @return void
      */
@@ -100,9 +100,7 @@ private function checkCaseReviewDisposition()
     }
 
     /**
-     * Returns a string representation of the object.
-     *
-     * @return string
+     * @inheritdoc
      */
     public function toString()
     {

Test/Constraint/AssertCaseInfoOnSignifydConsole.php

@@ -5,8 +5,8 @@
  */
 namespace Magento\Signifyd\Test\Constraint;
 
-use Magento\Customer\Test\Fixture\Address;
 use Magento\Mtf\Constraint\AbstractConstraint;
+use Magento\Signifyd\Test\Fixture\SignifydAddress;
 use Magento\Signifyd\Test\Page\Sandbox\SignifydCases;
 
 /**
@@ -23,7 +23,7 @@ class AssertCaseInfoOnSignifydConsole extends AbstractConstraint
 
     /**
      * @param SignifydCases $signifydCases
-     * @param Address $billingAddress
+     * @param SignifydAddress $billingAddress
      * @param array $prices
      * @param string $orderId
      * @param string $customerFullName
@@ -32,11 +32,11 @@ class AssertCaseInfoOnSignifydConsole extends AbstractConstraint
      */
     public function processAssert(
         SignifydCases $signifydCases,
-        Address $billingAddress,
+        SignifydAddress $billingAddress,
         array $prices,
         $orderId,
         $customerFullName,
-        $signifydData
+        array $signifydData
     ) {
         $this->signifydCases = $signifydCases;
 
@@ -50,7 +50,7 @@ public function processAssert(
     }
 
     /**
-     * Checks that guarantee disposition matches.
+     * Checks guarantee disposition is correct.
      *
      * @param string $guaranteeDisposition
      * @return void
@@ -65,7 +65,7 @@ private function checkGuaranteeDisposition($guaranteeDisposition)
     }
 
     /**
-     * Checks that CVV response matches.
+     * Checks CVV response is correct.
      *
      * @param string $cvvResponse
      * @return void
@@ -80,7 +80,7 @@ private function checkCvvResponse($cvvResponse)
     }
 
     /**
-     * Checks that AVS response matches.
+     * Checks AVS response is correct.
      *
      * @param string $avsResponse
      * @return void
@@ -95,7 +95,7 @@ private function checkAvsResponse($avsResponse)
     }
 
     /**
-     * Checks that order id matches.
+     * Checks order id is correct.
      *
      * @param string $orderId
      * @return void
@@ -110,7 +110,7 @@ private function checkOrderId($orderId)
     }
 
     /**
-     * Checks that order amount matches.
+     * Checks order amount is correct.
      *
      * @param string $amount
      * @return void
@@ -125,7 +125,7 @@ private function checkOrderAmount($amount)
     }
 
     /**
-     * Checks that card holder matches.
+     * Checks card holder is correct.
      *
      * @param string $customerFullName
      * @return void
@@ -140,12 +140,12 @@ private function checkCardHolder($customerFullName)
     }
 
     /**
-     * Checks that billing address matches.
+     * Checks billing address is correct.
      *
-     * @param Address $billingAddress
+     * @param SignifydAddress $billingAddress
      * @return void
      */
-    private function checkBillingAddress(Address $billingAddress)
+    private function checkBillingAddress(SignifydAddress $billingAddress)
     {
         \PHPUnit_Framework_Assert::assertContains(
             $billingAddress->getStreet(),
@@ -155,9 +155,7 @@ private function checkBillingAddress(Address $billingAddress)
     }
 
     /**
-     * Returns a string representation of the object.
-     *
-     * @return string
+     * @inheritdoc
      */
     public function toString()
     {

Test/Constraint/AssertSignifydCaseInCommentsHistory.php

@@ -3,15 +3,15 @@
  * Copyright © 2013-2017 Magento, Inc. All rights reserved.
  * See COPYING.txt for license details.
  */
-
 namespace Magento\Signifyd\Test\Constraint;
 
 use Magento\Sales\Test\Page\Adminhtml\OrderIndex;
 use Magento\Sales\Test\Page\Adminhtml\SalesOrderView;
 use Magento\Mtf\Constraint\AbstractConstraint;
 
 /**
- * Assert that comment about created Signifyd Case exists in Comments History section on order page in Admin.
+ * Assert that comment about created Signifyd Case
+ * exists in Comments History section on order page in Admin.
  */
 class AssertSignifydCaseInCommentsHistory extends AbstractConstraint
 {
@@ -21,8 +21,6 @@ class AssertSignifydCaseInCommentsHistory extends AbstractConstraint
     const CASE_CREATED_PATTERN = '/Signifyd Case (\d)+ has been created for order\./';
 
     /**
-     * Assert that comment about Signifyd Case exists in Comments History section on order page in Admin.
-     *
      * @param SalesOrderView $salesOrderView
      * @param OrderIndex $salesOrder
      * @param string $orderId
@@ -49,9 +47,7 @@ public function processAssert(
     }
 
     /**
-     * Returns string representation of successful assertion.
-     *
-     * @return string
+     * @inheritdoc
      */
     public function toString()
     {

Test/Constraint/AssertSignifydCaseInOrdersGrid.php

@@ -3,7 +3,6 @@
  * Copyright © 2013-2017 Magento, Inc. All rights reserved.
  * See COPYING.txt for license details.
  */
-
 namespace Magento\Signifyd\Test\Constraint;
 
 use Magento\Signifyd\Test\Page\Adminhtml\OrdersGrid;
@@ -15,8 +14,6 @@
 class AssertSignifydCaseInOrdersGrid extends AbstractConstraint
 {
     /**
-     * Assert that order with fixture data is present in Sales -> Orders Grid.
-     *
      * @param string $orderId
      * @param string $status
      * @param OrdersGrid $ordersGrid
@@ -46,9 +43,7 @@ public function processAssert(
     }
 
     /**
-     * Returns a string representation of the object.
-     *
-     * @return string
+     * @inheritdoc
      */
     public function toString()
     {

Test/Constraint/AssertSignifydGuaranteeCancelInCommentsHistory.php

@@ -10,7 +10,8 @@
 use Magento\Sales\Test\Page\Adminhtml\SalesOrderView;
 
 /**
- * Class AssertSignifydGuaranteeCancelInCommentsHistory
+ * Assert that comment about created Signifyd Case guarantee
+ * has been cancelled exists in Comments History section on order page in Admin.
  */
 class AssertSignifydGuaranteeCancelInCommentsHistory extends AbstractConstraint
 {
@@ -47,9 +48,7 @@ public function processAssert(
     }
 
     /**
-     * Returns a string representation of the object.
-     *
-     * @return string
+     * @inheritdoc
      */
     public function toString()
     {

Test/Fixture/SignifydAddress.xml

@@ -0,0 +1,15 @@
+<?xml version="1.0" encoding="utf-8"?>
+<!--
+/**
+ * Copyright © 2013-2017 Magento, Inc. All rights reserved.
+ * See COPYING.txt for license details.
+ */
+ -->
+<config xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:noNamespaceSchemaLocation="../../../../../../vendor/magento/mtf/etc/fixture.xsd">
+    <fixture name="signifydAddress"
+             module="Magento_Signifyd"
+             class="Magento\Signifyd\Test\Fixture\SignifydAddress"
+             extends="\Magento\Customer\Test\Fixture\Address">
+        <field name="firstname" source="Magento\Signifyd\Test\Fixture\SignifydAddress\Firstname"  is_required="1" />
+    </fixture>
+</config>

Test/Fixture/SignifydAddress/Firstname.php

@@ -0,0 +1,50 @@
+<?php
+/**
+ * Copyright © 2013-2017 Magento, Inc. All rights reserved.
+ * See COPYING.txt for license details.
+ */
+namespace Magento\Signifyd\Test\Fixture\SignifydAddress;
+
+use Magento\Mtf\Fixture\DataSource;
+
+/**
+ * Source handler for `firstname` field in shipping address fixture.
+ */
+class Firstname extends DataSource
+{
+    /**
+     * @param string $data
+     */
+    public function __construct($data = '')
+    {
+        $this->data = $data;
+    }
+
+    /**
+     * Add isolation for `firstname` field.
+     *
+     * @param null $key
+     * @return string
+     */
+    public function getData($key = null)
+    {
+        $this->data = str_replace('%signifyd_isolation%', $this->generateIsolation(), $this->data);
+
+        return parent::getData($key);
+    }
+
+    /**
+     * Generates character isolation.
+     *
+     * @param int $length
+     * @return string
+     */
+    private function generateIsolation($length = 10)
+    {
+        return substr(
+            str_shuffle(
+                str_repeat("abcdefghijklmnopqrstuvwxyz", $length)),
+            0, $length
+        );
+    }
+}

Test/Repository/Address.xml

@@ -8,7 +8,7 @@
 <config xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:noNamespaceSchemaLocation="../../../../../../vendor/magento/mtf/Magento/Mtf/Repository/etc/repository.xsd">
     <repository class="Magento\Customer\Test\Repository\Address">
         <dataset name="signifyd_approve_us_shipping_address">
-            <field name="firstname" xsi:type="string">John</field>
+            <field name="firstname" xsi:type="string">John%signifyd_isolation%</field>
             <field name="lastname" xsi:type="string">Doe</field>
             <field name="company" xsi:type="string">Magento</field>
             <field name="city" xsi:type="string">Culver City</field>