[BUGFIX] All option values were deleted if one was deleted earlier

bartlubbersen · Volodymyr Kublytskyi · commit 14a4df89ab6a · 2018-02-01T17:00:39.000+02:00
The problem occurs if you delete one custom option value was deleted. This occurred because the same value object is used for saving all values, and if one value is deleted the _isDeleted flag is set tot true on that object. So all values after that value will also be deleted.
diff --git a/app/code/Magento/Catalog/Model/Product/Option/Value.php b/app/code/Magento/Catalog/Model/Product/Option/Value.php
@@ -188,6 +188,7 @@ public function getProduct()
     public function saveValues()
     {
         foreach ($this->getValues() as $value) {
+            $this->isDeleted(false);
             $this->setData(
                 $value
             )->setData(

Original file line number	Diff line number	Diff line change
`@@ -188,6 +188,7 @@ public function getProduct()`
`188`	`188`	`public function saveValues()`
`189`	`189`	`{`
`190`	`190`	`foreach ($this->getValues() as $value) {`
	`191`	`+ $this->isDeleted(false);`
`191`	`192`	`$this->setData(`
`192`	`193`	`$value`
`193`	`194`	`)->setData(`