fix test for cataloginvetory qty validation

Author: bordeo

app/code/Magento/CatalogInventory/Test/Unit/Block/Plugin/ProductViewTest.php

@@ -28,7 +28,7 @@ protected function setUp()
 
         $this->stockItem = $this->getMockBuilder(\Magento\CatalogInventory\Model\Stock\Item::class)
             ->disableOriginalConstructor()
-            ->setMethods(['getMinSaleQty', 'getQtyMaxAllowed', 'getQtyIncrements'])
+            ->setMethods(['getMinSaleQty', 'getMaxSaleQty', 'getQtyIncrements'])
             ->getMock();
 
         $this->stockRegistry = $this->getMockBuilder(\Magento\CatalogInventory\Api\StockRegistryInterface::class)
@@ -74,7 +74,7 @@ public function testAfterGetQuantityValidators()
             ->with('productId', 'websiteId')
             ->willReturn($this->stockItem);
         $this->stockItem->expects($this->once())->method('getMinSaleQty')->willReturn(0.5);
-        $this->stockItem->expects($this->any())->method('getQtyMaxAllowed')->willReturn(5);
+        $this->stockItem->expects($this->any())->method('getMaxSaleQty')->willReturn(5);
         $this->stockItem->expects($this->any())->method('getQtyIncrements')->willReturn(3);
 
         $this->assertEquals($result, $this->block->afterGetQuantityValidators($productViewBlock, $validators));

app/code/Magento/Ui/view/base/web/js/lib/validation/rules.js

@@ -910,6 +910,7 @@ define([
         'validate-item-quantity': [
             function (value, params) {
                 var validator = this,
+                    result = false,
                     // obtain values for validation
                     qty = utils.parseNumber(value),
                     isMinAllowedValid = typeof params.minAllowed === 'undefined' ||
@@ -919,15 +920,15 @@ define([
                     isQtyIncrementsValid = typeof params.qtyIncrements === 'undefined' ||
                         qty % utils.parseNumber(params.qtyIncrements) === 0;
 
-                var result = qty > 0;
+                result = qty > 0;
 
                 if (result === false) {
                   validator.itemQtyErrorMessage = $.mage.__("Please enter a quantity greater than 0.");//eslint-disable-line max-len
 
                   return result;
                 }
 
-                var result = isMinAllowedValid;
+                result = isMinAllowedValid;
 
                 if (result === false) {
                   validator.itemQtyErrorMessage = $.mage.__("The fewest you may purchase is %1.").replace('%1', params.minAllowed);//eslint-disable-line max-len

lib/web/mage/validation.js

@@ -1567,6 +1567,7 @@
         'validate-item-quantity': [
             function (value, element, params) {
                 var validator = this,
+                    result = false,
                     // obtain values for validation
                     qty = $.mage.parseNumber(value),
                     isMinAllowedValid = typeof params.minAllowed === 'undefined' ||
@@ -1576,15 +1577,15 @@
                     isQtyIncrementsValid = typeof params.qtyIncrements === 'undefined' ||
                         qty % $.mage.parseNumber(params.qtyIncrements) === 0;
 
-                var result = qty > 0;
+                result = qty > 0;
 
                 if (result === false) {
                   validator.itemQtyErrorMessage = $.mage.__("Please enter a quantity greater than 0.");//eslint-disable-line max-len
 
                   return result;
                 }
 
-                var result = isMinAllowedValid;
+                result = isMinAllowedValid;
 
                 if (result === false) {
                   validator.itemQtyErrorMessage = $.mage.__("The fewest you may purchase is %1.").replace('%1', params.minAllowed);//eslint-disable-line max-len