MAGETWO-83132: Move the logging to the button click action

- fix build failures

Author: Joan He

app/code/Magento/ReleaseNotification/Controller/Adminhtml/Notification/MarkUserNotified.php

@@ -84,4 +84,9 @@ public function execute()
         $resultJson = $this->resultFactory->create(ResultFactory::TYPE_JSON);
         return $resultJson->setData($responseContent);
     }
+
+    protected function _isAllowed()
+    {
+        return parent::_isAllowed();
+    }
 }

app/code/Magento/ReleaseNotification/Test/Unit/Controller/Notification/MarkUserNotifiedTest.php

@@ -21,6 +21,8 @@
 
 /**
  * Class MarkUserNotifiedTest
+ *
+ * @SuppressWarnings(PHPMD.CouplingBetweenObjects)
  */
 class MarkUserNotifiedTest extends \PHPUnit\Framework\TestCase
 {
@@ -126,7 +128,7 @@ public function testExecuteSuccess()
             ->willReturn('999.999.999-alpha');
         $this->notificationLoggerMock->expects($this->once())
             ->method('log')
-            ->with(1 , '999.999.999-alpha')
+            ->with(1, '999.999.999-alpha')
             ->willReturn(true);
         $this->resultMock->expects($this->once())
             ->method('setData')

app/code/Magento/ReleaseNotification/Test/Unit/Model/Condition/CanViewNotificationTest.php

@@ -109,7 +109,7 @@ public function testIsVisible($expected, $version, $lastViewVersion)
             ->willReturn($this->logMock);
         $this->cacheStorageMock->expects($this->once())
             ->method('save')
-            ->with(false,'release-notification-popup-1');
+            ->with(false, 'release-notification-popup-1');
         $this->assertEquals($expected, $this->canViewNotification->isVisible([]));
     }
 

dev/tests/integration/testsuite/Magento/ReleaseNotification/Model/ResourceModel/Viewer/LoggerTest.php

@@ -35,7 +35,7 @@ public function testLogAndGet()
         $userModel = Bootstrap::getObjectManager()->get(\Magento\User\Model\User::class);
         $adminUserNameFromFixture = 'adminUser';
         $adminUserId = $userModel->loadByUsername($adminUserNameFromFixture)->getId();
-        $this->assertNull($this->logger->get($adminUserId));
+        $this->assertEmpty($this->logger->get($adminUserId)->getId());
         $firstLogVersion = '2.2.2';
         $this->logger->log($adminUserId, $firstLogVersion);
         $firstLog = $this->logger->get($adminUserId);

dev/tests/static/testsuite/Magento/Test/Integrity/Magento/Backend/_files/controller_acl_test_whitelist_ce.txt

@@ -28,4 +28,3 @@ Magento\Swatches\Controller\Adminhtml\Product\Attribute\Plugin\Save
 Magento\Ui\Controller\Adminhtml\Export\GridToCsv
 Magento\Ui\Controller\Adminhtml\Export\GridToXml
 Magento\Catalog\Controller\Adminhtml\Product\Initialization\Helper\AttributeFilter
-Magento\ReleaseNotification\Controller\Adminhtml\Notification\MarkUserNotified