MAGETWO-67048: Cannot add translate attribute into the di.xml

nmalevanec · nmalevanec · commit 36deb52bfbcd · 2017-07-13T15:35:09.000+03:00
diff --git a/setup/src/Magento/Setup/Module/I18n/Parser/Adapter/Xml.php b/setup/src/Magento/Setup/Module/I18n/Parser/Adapter/Xml.php
@@ -55,13 +55,13 @@ protected function _getNodes($file)
     }
 
     /**
-     * Parse nodes pointed out in attribute "translate".
+     * Parse nodes pointed out in attribute "translate" and add phrases from them.
      *
-     * @param $attributes
-     * @param $element
+     * @param \SimpleXMLElement $attributes
+     * @param \SimpleXMLElement $element
      * @return void
      */
-    protected function parseTranslatableNodes($attributes, $element)
+    protected function parseTranslatableNodes(\SimpleXMLElement $attributes, \SimpleXMLElement $element)
     {
         $nodesDelimiter = strpos($attributes['translate'], ' ') === false ? ',' : ' ';
         foreach (explode($nodesDelimiter, $attributes['translate']) as $value) {

Original file line number	Diff line number	Diff line change
`@@ -55,13 +55,13 @@ protected function _getNodes($file)`
`55`	`55`	`}`
`56`	`56`
`57`	`57`	`/**`
`58`		`- * Parse nodes pointed out in attribute "translate".`
	`58`	`+ * Parse nodes pointed out in attribute "translate" and add phrases from them.`
`59`	`59`	`*`
`60`		`- * @param $attributes`
`61`		`- * @param $element`
	`60`	`+ * @param \SimpleXMLElement $attributes`
	`61`	`+ * @param \SimpleXMLElement $element`
`62`	`62`	`* @return void`
`63`	`63`	`*/`
`64`		`- protected function parseTranslatableNodes($attributes, $element)`
	`64`	`+ protected function parseTranslatableNodes(\SimpleXMLElement $attributes, \SimpleXMLElement $element)`
`65`	`65`	`{`
`66`	`66`	`$nodesDelimiter = strpos($attributes['translate'], ' ') === false ? ',' : ' ';`
`67`	`67`	`foreach (explode($nodesDelimiter, $attributes['translate']) as $value) {`