ENGCOM-1220: [Forwardport] Check if store id is not null instead of empty #14502

magento-engcom-team · magento-engcom-team · commit 6e5dfb8a4680 · 2018-04-03T03:20:18.000-05:00
- Merge Pull Request magento/magento2#14502 from storefront-bvba/magento2:2.3-develop - Merged commits: 1. 9d087f8
diff --git a/app/code/Magento/Cms/Model/PageRepository.php b/app/code/Magento/Cms/Model/PageRepository.php
@@ -111,7 +111,7 @@ public function __construct(
      */
     public function save(\Magento\Cms\Api\Data\PageInterface $page)
     {
-        if (empty($page->getStoreId())) {
+        if ($page->getStoreId() === null) {
             $storeId = $this->storeManager->getStore()->getId();
             $page->setStoreId($storeId);
         }

Original file line number	Diff line number	Diff line change
`@@ -111,7 +111,7 @@ public function __construct(`
`111`	`111`	`*/`
`112`	`112`	`public function save(\Magento\Cms\Api\Data\PageInterface $page)`
`113`	`113`	`{`
`114`		`- if (empty($page->getStoreId())) {`
	`114`	`+ if ($page->getStoreId() === null) {`
`115`	`115`	`$storeId = $this->storeManager->getStore()->getId();`
`116`	`116`	`$page->setStoreId($storeId);`
`117`	`117`	`}`