Skip to content
This repository was archived by the owner on Apr 29, 2019. It is now read-only.

Commit 97c8f81

Browse files
committed
MQE-727: MSI Test Cases
- Reverting Robo changes. - Removing the "AdminClearGridFiltersActionGroup". - Replacing AdminClearGridFiltersActionGroup logic with a conditionalClick for the "Clear All" button. - Revised selectors in the Admin Grid section.
1 parent 818a84c commit 97c8f81

File tree

5 files changed

+6
-27
lines changed

5 files changed

+6
-27
lines changed

dev/tests/acceptance/RoboFile.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -89,7 +89,7 @@ function functional()
8989
*/
9090
function group($args = '')
9191
{
92-
$this->taskExec('.' . DIRECTORY_SEPARATOR . 'vendor' . DIRECTORY_SEPARATOR . 'bin' . DIRECTORY_SEPARATOR . 'codecept run functional --debug --skip-group skip --group')->args($args)->run();
92+
$this->taskExec('.' . DIRECTORY_SEPARATOR . 'vendor' . DIRECTORY_SEPARATOR . 'bin' . DIRECTORY_SEPARATOR . 'codecept run functional --verbose --steps --skip-group skip --group')->args($args)->run();
9393
}
9494

9595
/**

dev/tests/acceptance/tests/functional/Magento/FunctionalTest/Ui/ActionGroup/AdminClearGridFiltersActionGroup.xml

Lines changed: 0 additions & 16 deletions
This file was deleted.

dev/tests/acceptance/tests/functional/Magento/FunctionalTest/Ui/ActionGroup/AdminGridFilterSearchResultsActionGroup.xml

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -14,11 +14,8 @@
1414
<argument name="value"/>
1515
</arguments>
1616

17-
<!-- Start of Action Group: AdminClearGridFiltersIfPresent -->
18-
<conditionalClick selector=".admin__data-grid-header[data-bind='afterRender: \$data.setToolbarNode'] .action-remove" dependentSelector=".admin__data-grid-header[data-bind='afterRender: \$data.setToolbarNode'] .admin__data-grid-filters-current._show" visible="true" stepKey="clearTheFiltersIfPresent"/>
19-
<executeJS function="jQuery('.action-remove').click();" stepKey="clearIfMultipleExist"/>
17+
<conditionalClick selector="{{AdminGridFilterControls.clearAll}}" dependentSelector=".admin__data-grid-header[data-bind='afterRender: \$data.setToolbarNode'] .admin__data-grid-filters-current._show" visible="true" stepKey="clearTheFiltersIfPresent"/>
2018
<waitForPageLoad stepKey="waitForPageLoad" time="5"/>
21-
<!-- End of Action Group: AdminClearGridFiltersIfPresent -->
2219

2320
<click selector="{{AdminGridFilterControls.filters}}" stepKey="clickOnFilters1"/>
2421
<fillField userInput="{{value}}" selector="{{selector}}" stepKey="fillCodeField2"/>

dev/tests/acceptance/tests/functional/Magento/FunctionalTest/Ui/ActionGroup/AdminGridSearchByKeywordActionGroup.xml

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -13,11 +13,8 @@
1313
<argument name="value"/>
1414
</arguments>
1515

16-
<!-- Start of Action Group: AdminClearGridFiltersIfPresent -->
17-
<conditionalClick selector=".admin__data-grid-header[data-bind='afterRender: \$data.setToolbarNode'] .action-remove" dependentSelector=".admin__data-grid-header[data-bind='afterRender: \$data.setToolbarNode'] .admin__data-grid-filters-current._show" visible="true" stepKey="clearTheFiltersIfPresent"/>
18-
<executeJS function="jQuery('.action-remove').click();" stepKey="clearIfMultipleExist"/>
16+
<conditionalClick selector="{{AdminGridFilterControls.clearAll}}" dependentSelector=".admin__data-grid-header[data-bind='afterRender: \$data.setToolbarNode'] .admin__data-grid-filters-current._show" visible="true" stepKey="clearTheFiltersIfPresent"/>
1917
<waitForPageLoad stepKey="waitForPageLoad" time="5"/>
20-
<!-- End of Action Group: AdminClearGridFiltersIfPresent -->
2118

2219
<fillField selector="{{AdminGridSearchBox.searchByKeyword}}" userInput="{{value}}" stepKey="fillSearchByKeyword"/>
2320
<click selector="{{AdminGridSearchBox.search}}" stepKey="clickOnSearch"/>

dev/tests/acceptance/tests/functional/Magento/FunctionalTest/Ui/Section/AdminGridControlsSection.xml

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,7 @@
3030
<element name="filters" type="button" selector=".admin__data-grid-header[data-bind='afterRender: \$data.setToolbarNode'] button[data-action='grid-filter-expand']" timeout="5"/>
3131
<element name="applyFilters" type="button" selector="button[data-action='grid-filter-apply']" timeout="30"/>
3232
<element name="cancel" type="button" selector="button[data-action='grid-filter-cancel']" timeout="30"/>
33+
<element name="clearAll" type="button" selector=".admin__data-grid-header[data-bind='afterRender: \$data.setToolbarNode'] button[data-action='grid-filter-reset']" timeout="5"/>
3334
</section>
3435
<!-- TODO: "Default View" drop down menu -->
3536
<section name="AdminGridColumnsControls">
@@ -54,9 +55,9 @@
5455
<element name="rowOne" type="text" selector="tr[data-repeat-index='0']"/>
5556
<element name="rowByIndex" type="text" selector="tr[data-repeat-index='{{var1}}']" parameterized="true"/>
5657

57-
<element name="editByValue" type="button" selector="//div[@class='data-grid-cell-content'][contains(text(), '{{var1}}')]/parent::*/parent::*/*/a" parameterized="true"/>
58+
<element name="editByValue" type="button" selector="//a[ancestor::tr[contains(., '{{var1}}')]]" parameterized="true"/>
5859

59-
<element name="checkboxByValue" type="checkbox" selector="//div[@class='data-grid-cell-content'][contains(text(), '{{var1}}')]/parent::*/parent::*/*/*/input" parameterized="true"/>
60+
<element name="checkboxByValue" type="checkbox" selector="//input[ancestor::tr[contains(., '{{var1}}')]]" parameterized="true"/>
6061
<element name="checkboxByIndex" type="checkbox" selector=".data-row[data-repeat-index='{{var1}}'] .admin__control-checkbox" parameterized="true"/>
6162
</section>
6263
</sections>

0 commit comments

Comments
 (0)