MAGETWO-89458: Cover changed and new logic with automated tests

Author: rganin

app/code/Magento/CatalogGraphQl/Model/Layer/CollectionProvider.php

@@ -3,11 +3,11 @@
  * Copyright © Magento, Inc. All rights reserved.
  * See COPYING.txt for license details.
  */
+declare(strict_types=1);
+
 namespace Magento\CatalogGraphQl\Model\Layer;
 
-use \Magento\CatalogSearch\Model\ResourceModel\Advanced\Collection;
-use Magento\Framework\Api\SearchCriteria\CollectionProcessor;
-use Magento\Framework\Registry;
+use Magento\CatalogSearch\Model\ResourceModel\Advanced\Collection;
 
 /**
  * Collection Provider for graphql layered navigation.

app/code/Magento/CatalogGraphQl/Model/Layer/Context.php

@@ -3,6 +3,8 @@
  * Copyright © Magento, Inc. All rights reserved.
  * See COPYING.txt for license details.
  */
+declare(strict_types=1);
+
 namespace Magento\CatalogGraphQl\Model\Layer;
 
 use Magento\Catalog\Model\Layer\CollectionFilterInterface;
@@ -11,8 +13,6 @@
 
 /**
  * Context for graphql layered navigation.
- *
- * @package Magento\CatalogGraphQl\Model\Layer
  */
 class Context implements \Magento\Catalog\Model\Layer\ContextInterface
 {

app/code/Magento/CatalogGraphQl/Model/Resolver/Layer/DataProvider/Filters.php

@@ -3,6 +3,8 @@
  * Copyright © Magento, Inc. All rights reserved.
  * See COPYING.txt for license details.
  */
+declare(strict_types=1);
+
 namespace Magento\CatalogGraphQl\Model\Resolver\Layer\DataProvider;
 
 use Magento\Catalog\Model\Layer\Filter\AbstractFilter;
@@ -36,7 +38,7 @@ public function __construct(
      * @param string $layerType
      * @return array
      */
-    public function getData(string $layerType)
+    public function getData(string $layerType) : array
     {
         $filtersData = [];
         /** @var AbstractFilter $filter */

app/code/Magento/CatalogGraphQl/Model/Resolver/Layer/FilterableAttributesListFactory.php

@@ -3,9 +3,12 @@
  * Copyright © Magento, Inc. All rights reserved.
  * See COPYING.txt for license details.
  */
+declare(strict_types=1);
+
 namespace Magento\CatalogGraphQl\Model\Resolver\Layer;
 
 use Magento\Catalog\Model\Layer\Category\FilterableAttributeList as CategoryFilterableAttributeList;
+use Magento\Catalog\Model\Layer\FilterList;
 use Magento\Catalog\Model\Layer\Resolver;
 use Magento\Catalog\Model\Layer\Search\FilterableAttributeList;
 
@@ -36,11 +39,11 @@ public function __construct(\Magento\Framework\ObjectManagerInterface $objectMan
     /**
      * Create class instance with specified parameters
      *
-     * @param $type
+     * @param string $type
      * @param array $data
-     * @return \Magento\Catalog\Model\Layer\FilterList
+     * @return FilterList
      */
-    public function create($type, array $data = array())
+    public function create(string $type, array $data = array()) : FilterList
     {
         if ($type === Resolver::CATALOG_LAYER_CATEGORY) {
             return $this->objectManager->create(CategoryFilterableAttributeList::class, $data);

app/code/Magento/CatalogGraphQl/Model/Resolver/Layer/FiltersProvider.php

@@ -7,10 +7,8 @@
 
 namespace Magento\CatalogGraphQl\Model\Resolver\Layer;
 
-use Magento\Catalog\Model\Layer\Filter\AbstractFilter;
 use Magento\Catalog\Model\Layer\FilterListFactory;
 use Magento\Catalog\Model\Layer\Resolver;
-use Magento\CatalogGraphQl\Model\Resolver\Layer\FilterableAttributesListFactory;
 
 /**
  * Layer types filters provider.