Issue #13582 show message for qty minAllowed, maxAllowed, qtyIncrements validation. Fix ProductView plugin for maxAllowed

Author: bordeo

app/code/Magento/CatalogInventory/Block/Plugin/ProductView.php

@@ -39,8 +39,8 @@ public function afterGetQuantityValidators(
 
         $params = [];
         $params['minAllowed']  = (float)$stockItem->getMinSaleQty();
-        if ($stockItem->getQtyMaxAllowed()) {
-            $params['maxAllowed'] = $stockItem->getQtyMaxAllowed();
+        if ($stockItem->getMaxSaleQty()) {
+            $params['maxAllowed'] = $stockItem->getMaxSaleQty();
         }
         if ($stockItem->getQtyIncrements() > 0) {
             $params['qtyIncrements'] = (float)$stockItem->getQtyIncrements();

app/code/Magento/Ui/view/base/web/js/lib/validation/rules.js

@@ -909,18 +909,52 @@ define([
         ],
         'validate-item-quantity': [
             function (value, params) {
-                // obtain values for validation
-                var qty = utils.parseNumber(value),
+                var validator = this,
+                    // obtain values for validation
+                    qty = utils.parseNumber(value),
                     isMinAllowedValid = typeof params.minAllowed === 'undefined' ||
                         qty >= utils.parseNumber(params.minAllowed),
                     isMaxAllowedValid = typeof params.maxAllowed === 'undefined' ||
                         qty <= utils.parseNumber(params.maxAllowed),
                     isQtyIncrementsValid = typeof params.qtyIncrements === 'undefined' ||
                         qty % utils.parseNumber(params.qtyIncrements) === 0;
 
-                return isMaxAllowedValid && isMinAllowedValid && isQtyIncrementsValid && qty > 0;
-            },
-            ''
+                var result = qty > 0;
+
+                if (result === false) {
+                  validator.itemQtyErrorMessage = $.mage.__("Please enter a quantity greater than 0.");//eslint-disable-line max-len
+
+                  return result;
+                }
+
+                var result = isMinAllowedValid;
+
+                if (result === false) {
+                  validator.itemQtyErrorMessage = $.mage.__("The fewest you may purchase is %1.").replace('%1', params.minAllowed);//eslint-disable-line max-len
+
+                  return result;
+                }
+
+                result = isMaxAllowedValid;
+
+                if (result === false) {
+                  validator.itemQtyErrorMessage = $.mage.__("The maximum you may purchase is %1.").replace('%1', params.maxAllowed);//eslint-disable-line max-len
+
+                  return result;
+                }
+
+                result = isQtyIncrementsValid;
+
+                if (result === false) {
+                  validator.itemQtyErrorMessage = $.mage.__("You can buy this product only in quantities of %1 at a time.").replace('%1', params.qtyIncrements);//eslint-disable-line max-len
+
+                  return result;
+                }
+
+                return result;
+            }, function () {
+            return this.itemQtyErrorMessage;
+          }
         ],
         'equalTo': [
             function (value, param) {

lib/web/mage/validation.js

@@ -1566,18 +1566,52 @@
         ],
         'validate-item-quantity': [
             function (value, element, params) {
-                // obtain values for validation
-                var qty = $.mage.parseNumber(value),
+                var validator = this,
+                    // obtain values for validation
+                    qty = $.mage.parseNumber(value),
                     isMinAllowedValid = typeof params.minAllowed === 'undefined' ||
                         qty >= $.mage.parseNumber(params.minAllowed),
                     isMaxAllowedValid = typeof params.maxAllowed === 'undefined' ||
                         qty <= $.mage.parseNumber(params.maxAllowed),
                     isQtyIncrementsValid = typeof params.qtyIncrements === 'undefined' ||
                         qty % $.mage.parseNumber(params.qtyIncrements) === 0;
 
-                return isMaxAllowedValid && isMinAllowedValid && isQtyIncrementsValid && qty > 0;
-            },
-            ''
+                var result = qty > 0;
+
+                if (result === false) {
+                  validator.itemQtyErrorMessage = $.mage.__("Please enter a quantity greater than 0.");//eslint-disable-line max-len
+
+                  return result;
+                }
+
+                var result = isMinAllowedValid;
+
+                if (result === false) {
+                  validator.itemQtyErrorMessage = $.mage.__("The fewest you may purchase is %1.").replace('%1', params.minAllowed);//eslint-disable-line max-len
+
+                  return result;
+                }
+
+                result = isMaxAllowedValid;
+
+                if (result === false) {
+                  validator.itemQtyErrorMessage = $.mage.__("The maximum you may purchase is %1.").replace('%1', params.maxAllowed);//eslint-disable-line max-len
+
+                  return result;
+                }
+
+                result = isQtyIncrementsValid;
+
+                if (result === false) {
+                  validator.itemQtyErrorMessage = $.mage.__("You can buy this product only in quantities of %1 at a time.").replace('%1', params.qtyIncrements);//eslint-disable-line max-len
+
+                  return result;
+                }
+
+                return result;
+              }, function () {
+              return this.itemQtyErrorMessage;
+            }
         ],
         'password-not-equal-to-user-name': [
             function (value, element, params) {