Skip to content
This repository was archived by the owner on Apr 29, 2019. It is now read-only.

Commit ae5e7dd

Browse files
author
Alex Paliarush
committed
MAGETWO-69717: Custom option value IDs changed after import
1 parent a46ba6a commit ae5e7dd

File tree

2 files changed

+5
-5
lines changed

2 files changed

+5
-5
lines changed

app/code/Magento/CatalogImportExport/Model/Import/Product/Option.php

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -383,8 +383,8 @@ class Option extends \Magento\ImportExport\Model\Import\Entity\AbstractEntity
383383
* @param \Magento\Framework\App\Config\ScopeConfigInterface $scopeConfig
384384
* @param \Magento\Framework\Stdlib\DateTime\TimezoneInterface $dateTime
385385
* @param ProcessingErrorAggregatorInterface $errorAggregator
386-
* @param ProductOptionValueCollectionFactory $productOptionValueCollectionFactory
387386
* @param array $data
387+
* @param ProductOptionValueCollectionFactory $productOptionValueCollectionFactory
388388
* @throws \Magento\Framework\Exception\LocalizedException
389389
*
390390
* @SuppressWarnings(PHPMD.ExcessiveParameterList)
@@ -402,8 +402,8 @@ public function __construct(
402402
\Magento\Framework\App\Config\ScopeConfigInterface $scopeConfig,
403403
\Magento\Framework\Stdlib\DateTime\TimezoneInterface $dateTime,
404404
ProcessingErrorAggregatorInterface $errorAggregator,
405-
ProductOptionValueCollectionFactory $productOptionValueCollectionFactory = null,
406-
array $data = []
405+
array $data = [],
406+
ProductOptionValueCollectionFactory $productOptionValueCollectionFactory = null
407407
) {
408408
$this->_resource = $resource;
409409
$this->_catalogData = $catalogData;

app/code/Magento/CatalogImportExport/Test/Unit/Model/Import/Product/Type/OptionTest.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -305,8 +305,8 @@ protected function setUp()
305305
'',
306306
false
307307
),
308-
$optionValueCollectionFactoryMock,
309-
$this->_getModelDependencies($addExpectations, $deleteBehavior, $doubleOptions)
308+
$this->_getModelDependencies($addExpectations, $deleteBehavior, $doubleOptions),
309+
$optionValueCollectionFactoryMock
310310
];
311311

312312
$modelClassName = \Magento\CatalogImportExport\Model\Import\Product\Option::class;

0 commit comments

Comments
 (0)