Fix Url Validator unit tests

Author: Ben Batschelet

lib/internal/Magento/Framework/Url/Test/Unit/ValidatorTest.php

@@ -12,13 +12,21 @@ class ValidatorTest extends \PHPUnit\Framework\TestCase
     /** @var \Magento\Framework\Url\Validator */
     protected $object;
 
+    /** @var \Zend\Validator\Uri */
+    protected $zendValidator;
+
     /** @var string[] */
     protected $expectedValidationMessages = ['invalidUrl' => "Invalid URL '%value%'."];
 
     protected function setUp()
     {
         $objectManager = new ObjectManager($this);
-        $this->object = $objectManager->getObject(\Magento\Framework\Url\Validator::class);
+
+        $this->zendValidator = $this->createMock(\Zend\Validator\Uri::class);
+        $this->object = $objectManager->getObject(
+            \Magento\Framework\Url\Validator::class,
+            ['validator' => $this->zendValidator]
+        );
     }
 
     public function testConstruct()
@@ -28,13 +36,23 @@ public function testConstruct()
 
     public function testIsValidWhenValid()
     {
-        $this->assertEquals(true, $this->object->isValid('http://example.com'));
+        $this->zendValidator
+            ->method('isValid')
+            ->with('http://example.com')
+            ->willReturn(true);
+
+        $this->assertTrue($this->object->isValid('http://example.com'));
         $this->assertEquals([], $this->object->getMessages());
     }
 
     public function testIsValidWhenInvalid()
     {
-        $this->assertEquals(false, $this->object->isValid('%value%'));
+        $this->zendValidator
+            ->method('isValid')
+            ->with('%value%')
+            ->willReturn(false);
+
+        $this->assertFalse($this->object->isValid('%value%'));
         $this->assertEquals($this->expectedValidationMessages, $this->object->getMessages());
     }
 }