Skip to content
This repository was archived by the owner on Apr 29, 2019. It is now read-only.

Commit c084214

Browse files
committed
MSI: Update Magento 2 core to support MSI
1 parent 6d5e882 commit c084214

File tree

5 files changed

+5
-9
lines changed

5 files changed

+5
-9
lines changed

app/code/Magento/Backend/Ui/Component/Control/DeleteButton.php

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -58,6 +58,7 @@ class DeleteButton implements ButtonProviderInterface
5858
/**
5959
* @param RequestInterface $request
6060
* @param UrlInterface $urlBuilder
61+
* @param Escaper $escaper
6162
* @param string $confirmationMessage
6263
* @param string $idFieldName
6364
* @param string $deleteRoutePath
@@ -87,7 +88,7 @@ public function __construct(
8788
public function getButtonData()
8889
{
8990
$data = [];
90-
$fieldId = $this->request->getParam($this->idFieldName);
91+
$fieldId = $this->escaper->escapeJs($this->escaper->escapeHtml($this->request->getParam($this->idFieldName)));
9192
if (null !== $fieldId) {
9293
$url = $this->urlBuilder->getUrl($this->deleteRoutePath);
9394
$escapedMessage = $this->escaper->escapeJs($this->escaper->escapeHtml($this->confirmationMessage));

app/code/Magento/CatalogImportExport/Model/Import/Product.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -536,7 +536,7 @@ class Product extends \Magento\ImportExport\Model\Import\Entity\AbstractEntity
536536

537537
/**
538538
* @var \Magento\CatalogInventory\Model\ResourceModel\Stock\ItemFactory
539-
* @deprecated
539+
* @deprecated this variable isn't used anymore.
540540
*/
541541
protected $_stockResItemFac;
542542

app/code/Magento/ImportExport/Controller/Adminhtml/Import/Download.php

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -81,15 +81,13 @@ public function execute()
8181
$entityName = $this->getRequest()->getParam('filename');
8282

8383
if (preg_match('/^\w+$/', $entityName) == 0) {
84-
/** @var \Magento\Backend\Model\View\Result\Redirect $resultRedirect */
85-
$this->messageManager->addErrorMessage(__('Incorrect file name.'));
84+
$this->messageManager->addErrorMessage(__('Incorrect entity name.'));
8685

8786
return $this->getResultRedirect();
8887
}
8988
try {
9089
$fileContents = $this->sampleFileProvider->getFileContents($entityName);
9190
} catch (NoSuchEntityException $e) {
92-
/** @var \Magento\Backend\Model\View\Result\Redirect $resultRedirect */
9391
$this->messageManager->addError(__('There is no sample file for this entity.'));
9492

9593
return $this->getResultRedirect();

app/code/Magento/ImportExport/Model/Import/SampleFileProvider.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -85,8 +85,8 @@ public function getFileContents(string $entityName): string
8585
*/
8686
private function getPath(string $entityName): string
8787
{
88-
$directoryRead = $this->getDirectoryRead($entityName);
8988
$moduleName = $this->getModuleName($entityName);
89+
$directoryRead = $this->getDirectoryRead($entityName);
9090
$moduleDir = $this->componentRegistrar->getPath(ComponentRegistrar::MODULE, $moduleName);
9191
$fileAbsolutePath = $moduleDir . '/Files/Sample/' . $entityName . '.csv';
9292

dev/tests/api-functional/phpunit_soap.xml.dist

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -21,9 +21,6 @@
2121
<!-- <exclude>testsuite/Magento/GraphQl</exclude> -->
2222
<directory suffix="Test.php">../../../app/code/*/*/Test/Api</directory>
2323
</testsuite>
24-
<testsuite name="msi">
25-
<directory suffix="Test.php">../../../app/code/*/*/Test/Api</directory>
26-
</testsuite>
2724
</testsuites>
2825

2926
<!-- PHP INI settings and constants definition -->

0 commit comments

Comments
 (0)