MAGETWO-83132: Move the logging to the button click action

- fix build failures

Author: Joan He

app/code/Magento/ReleaseNotification/Test/Unit/Controller/Notification/MarkUserNotifiedTest.php

@@ -29,11 +29,6 @@ class MarkUserNotifiedTest extends \PHPUnit\Framework\TestCase
      */
     private $storageMock;
 
-    /**
-     * @var \PHPUnit_Framework_MockObject_MockObject|Context
-     */
-    private $contextMock;
-
     /**
      * @var \PHPUnit_Framework_MockObject_MockObject|Auth
      */
@@ -44,11 +39,6 @@ class MarkUserNotifiedTest extends \PHPUnit\Framework\TestCase
      */
     private $loggerMock;
 
-    /**
-     * @var \PHPUnit_Framework_MockObject_MockObject|ResultFactory
-     */
-    private $resultFactoryMock;
-
     /**
      * @var \PHPUnit_Framework_MockObject_MockObject|Json
      */
@@ -77,10 +67,10 @@ public function setUp()
         $this->authMock = $this->getMockBuilder(Auth::class)
             ->disableOriginalConstructor()
             ->getMock();
-        $this->contextMock = $this->getMockBuilder(Context::class)
+        $contextMock = $this->getMockBuilder(Context::class)
             ->disableOriginalConstructor()
             ->getMock();
-        $this->contextMock->expects($this->once())
+        $contextMock->expects($this->once())
             ->method('getAuth')
             ->willReturn($this->authMock);
         $this->productMetadataMock = $this->getMockBuilder(ProductMetadataInterface::class)
@@ -90,24 +80,24 @@ public function setUp()
             ->getMock();
         $this->loggerMock = $this->getMockBuilder(LoggerInterface::class)
             ->getMock();
-        $this->resultFactoryMock = $this->getMockBuilder(ResultFactory::class)
+        $resultFactoryMock = $this->getMockBuilder(ResultFactory::class)
             ->disableOriginalConstructor()
             ->getMock();
         $this->resultMock = $this->getMockBuilder(Json::class)
             ->disableOriginalConstructor()
             ->getMock();
-        $this->resultFactoryMock->expects($this->once())
+        $resultFactoryMock->expects($this->once())
             ->method('create')
             ->with(ResultFactory::TYPE_JSON)
             ->willReturn($this->resultMock);
         $objectManagerHelper = new ObjectManagerHelper($this);
         $this->action = $objectManagerHelper->getObject(
             MarkUserNotified::class,
             [
-                'resultFactory' => $this->resultFactoryMock,
+                'resultFactory' => $resultFactoryMock,
                 'productMetadata' => $this->productMetadataMock,
                 'notificationLogger' => $this->notificationLoggerMock,
-                'context' => $this->contextMock,
+                'context' => $contextMock,
                 'logger' => $this->loggerMock
             ]
         );
@@ -126,7 +116,7 @@ public function testExecuteSuccess()
             ->willReturn('999.999.999-alpha');
         $this->notificationLoggerMock->expects($this->once())
             ->method('log')
-            ->with(1 , '999.999.999-alpha')
+            ->with(1, '999.999.999-alpha')
             ->willReturn(true);
         $this->resultMock->expects($this->once())
             ->method('setData')

dev/tests/integration/testsuite/Magento/ReleaseNotification/Model/ResourceModel/Viewer/LoggerTest.php

@@ -35,7 +35,7 @@ public function testLogAndGet()
         $userModel = Bootstrap::getObjectManager()->get(\Magento\User\Model\User::class);
         $adminUserNameFromFixture = 'adminUser';
         $adminUserId = $userModel->loadByUsername($adminUserNameFromFixture)->getId();
-        $this->assertNull($this->logger->get($adminUserId));
+        $this->assertEmpty($this->logger->get($adminUserId)->getId());
         $firstLogVersion = '2.2.2';
         $this->logger->log($adminUserId, $firstLogVersion);
         $firstLog = $this->logger->get($adminUserId);