MAGETWO-87190: Test coverage for critical logic

Sergii Kovalenko · Sergii Kovalenko · commit cf7579c7ba3e · 2018-02-01T12:40:48.000+02:00
diff --git a/setup/src/Magento/Setup/Model/Declaration/Schema/Diff/SchemaDiff.php b/setup/src/Magento/Setup/Model/Declaration/Schema/Diff/SchemaDiff.php
@@ -70,15 +70,14 @@ public function __construct(
      */
     private function createTableIndex(array $tableNames, array $generatedTableNames)
     {
-        $tableNames = array_flip($tableNames);
         foreach ($generatedTableNames as $tableName) {
             //If table exists only in db
-            if (!isset($tableNames[$tableName])) {
-                array_push($tableNames, $tableName);
+            if (!in_array($tableName, $tableNames)) {
+                $tableNames[] = $tableName;
             }
         }
 
-        return $tableNames;
+        return array_flip($tableNames);
     }
 
     /**

Original file line number	Diff line number	Diff line change
`@@ -70,15 +70,14 @@ public function __construct(`
`70`	`70`	`*/`
`71`	`71`	`private function createTableIndex(array $tableNames, array $generatedTableNames)`
`72`	`72`	`{`
`73`		`- $tableNames = array_flip($tableNames);`
`74`	`73`	`foreach ($generatedTableNames as $tableName) {`
`75`	`74`	`//If table exists only in db`
`76`		`- if (!isset($tableNames[$tableName])) {`
`77`		`- array_push($tableNames, $tableName);`
	`75`	`+ if (!in_array($tableName, $tableNames)) {`
	`76`	`+ $tableNames[] = $tableName;`
`78`	`77`	`}`
`79`	`78`	`}`
`80`	`79`
`81`		`- return $tableNames;`
	`80`	`+ return array_flip($tableNames);`
`82`	`81`	`}`
`83`	`82`
`84`	`83`	`/**`