MAGETWO-65105: Unhold on "Approved" guarantee status

Author: viktym

Model/CaseServices/UpdatingServiceTest.php

@@ -9,6 +9,7 @@
 use Magento\Framework\App\ResourceConnection;
 use Magento\Sales\Api\Data\OrderStatusHistoryInterface;
 use Magento\Sales\Api\OrderRepositoryInterface;
+use Magento\Sales\Model\Order;
 use Magento\Signifyd\Api\CaseRepositoryInterface;
 use Magento\Signifyd\Api\Data\CaseInterface;
 use Magento\Signifyd\Model\MessageGenerators\GeneratorFactory;
@@ -47,6 +48,7 @@ protected function setUp()
 
     /**
      * Checks case updating flow and messages in order comments history.
+     * Also checks that order is unholded when case guarantee disposition is APPROVED.
      *
      * @covers \Magento\Signifyd\Model\CaseServices\UpdatingService::update
      * @magentoDataFixture Magento/Signifyd/_files/case.php
@@ -97,6 +99,7 @@ public function testUpdate()
         /** @var OrderRepositoryInterface $orderRepository */
         $orderRepository = $this->objectManager->get(OrderRepositoryInterface::class);
         $order = $orderRepository->get($caseEntity->getOrderId());
+        static::assertEquals(Order::STATE_PROCESSING, $order->getState());
         $histories = $order->getStatusHistories();
         static::assertNotEmpty($histories);
 
@@ -106,6 +109,63 @@ public function testUpdate()
         static::assertEquals("Signifyd Case $caseId has been created for order.", $caseCreationComment->getComment());
     }
 
+    /**
+     * Checks that order is holded when case guarantee disposition is DECLINED.
+     *
+     * @covers \Magento\Signifyd\Model\CaseServices\UpdatingService::update
+     * @magentoDataFixture Magento/Signifyd/_files/approved_case.php
+     */
+    public function testOrderStateAfterDeclinedGuaranteeDisposition()
+    {
+        $caseId = 123;
+        $data = [
+            'caseId' => $caseId,
+            'orderId' => '100000001',
+            'guaranteeDisposition' => CaseInterface::GUARANTEE_DECLINED
+        ];
+
+        /** @var CaseRepositoryInterface $caseRepository */
+        $caseRepository = $this->objectManager->get(CaseRepositoryInterface::class);
+        $caseEntity = $caseRepository->getByCaseId($caseId);
+
+        $this->service->update($caseEntity, $data);
+
+        /** @var OrderRepositoryInterface $orderRepository */
+        $orderRepository = $this->objectManager->get(OrderRepositoryInterface::class);
+        $order = $orderRepository->get($caseEntity->getOrderId());
+
+        static::assertEquals(Order::STATE_HOLDED, $order->getState());
+    }
+
+    /**
+     * Checks that order doesn't become holded
+     * when previous case guarantee disposition was DECLINED
+     * and webhook without guarantee disposition was received.
+     *
+     * @covers \Magento\Signifyd\Model\CaseServices\UpdatingService::update
+     * @magentoDataFixture Magento/Signifyd/_files/declined_case.php
+     */
+    public function testOrderStateAfterWebhookWithoutGuaranteeDisposition()
+    {
+        $caseId = 123;
+        $data = [
+            'caseId' => $caseId,
+            'orderId' => '100000001'
+        ];
+
+        /** @var CaseRepositoryInterface $caseRepository */
+        $caseRepository = $this->objectManager->get(CaseRepositoryInterface::class);
+        $caseEntity = $caseRepository->getByCaseId($caseId);
+
+        $this->service->update($caseEntity, $data);
+
+        /** @var OrderRepositoryInterface $orderRepository */
+        $orderRepository = $this->objectManager->get(OrderRepositoryInterface::class);
+        $order = $orderRepository->get($caseEntity->getOrderId());
+
+        static::assertEquals(Order::STATE_PROCESSING, $order->getState());
+    }
+
     /**
      * Returns value of signifyd_guarantee_status column from sales order grid
      *

_files/case.php

@@ -3,12 +3,17 @@
  * Copyright © 2013-2017 Magento, Inc. All rights reserved.
  * See COPYING.txt for license details.
  */
+use Magento\Sales\Api\OrderManagementInterface;
 use Magento\Signifyd\Api\CaseRepositoryInterface;
 use Magento\Signifyd\Api\Data\CaseInterface;
 use Magento\Signifyd\Api\Data\CaseInterfaceFactory;
 
 require __DIR__ . '/order_with_customer_and_two_simple_products.php';
 
+/** @var OrderManagementInterface $orderManagement */
+$orderManagement = $objectManager->create(OrderManagementInterface::class);
+$orderManagement->hold($order->getEntityId());
+
 /** @var CaseInterfaceFactory $caseFactory */
 $caseFactory = $objectManager->get(CaseInterfaceFactory::class);
 
@@ -28,6 +33,7 @@
     ->setOrderId($order->getEntityId())
     ->setAssociatedTeam($associatedTeam)
     ->setReviewDisposition(CaseInterface::DISPOSITION_GOOD)
+    ->setGuaranteeDisposition(CaseInterface::GUARANTEE_PENDING)
     ->setCreatedAt('2016-12-12T15:17:17+0000')
     ->setUpdatedAt('2016-12-12T19:23:16+0000');
 

_files/declined_case.php

@@ -0,0 +1,38 @@
+<?php
+/**
+ * Copyright © 2013-2017 Magento, Inc. All rights reserved.
+ * See COPYING.txt for license details.
+ */
+
+use Magento\Signifyd\Api\CaseRepositoryInterface;
+use Magento\Signifyd\Api\Data\CaseInterface;
+use Magento\Signifyd\Api\Data\CaseInterfaceFactory;
+
+require __DIR__ . '/order_with_customer_and_two_simple_products.php';
+
+/** @var CaseInterfaceFactory $caseFactory */
+$caseFactory = $objectManager->get(CaseInterfaceFactory::class);
+
+$associatedTeam = [
+    'teamName' => 'Some Team',
+    'teamId' => 123,
+    'getAutoDismiss' => true,
+    'getTeamDismissalDays' => 3
+];
+
+/** @var CaseInterface $case */
+$case = $caseFactory->create();
+$case->setCaseId(123)
+    ->setGuaranteeEligible(false)
+    ->setGuaranteeDisposition(CaseInterface::GUARANTEE_DECLINED)
+    ->setStatus(CaseInterface::STATUS_PROCESSING)
+    ->setScore(553)
+    ->setOrderId($order->getEntityId())
+    ->setAssociatedTeam($associatedTeam)
+    ->setReviewDisposition(CaseInterface::DISPOSITION_FRAUDULENT)
+    ->setCreatedAt('2016-12-12T15:17:17+0000')
+    ->setUpdatedAt('2016-12-12T19:23:16+0000');
+
+/** @var CaseRepositoryInterface $caseRepository */
+$caseRepository = $objectManager->get(CaseRepositoryInterface::class);
+$caseRepository->save($case);