Skip to content
This repository was archived by the owner on Apr 29, 2019. It is now read-only.

Commit e5415c9

Browse files
ENGCOM-1230: [forwardport] fix translation issue with rating stars #14525
- Merge Pull Request magento/magento2#14525 from Karlasa/magento2:2.3-review-translation - Merged commits: 1. 3f2174c 2. 96f1210
2 parents b7ca049 + 96f1210 commit e5415c9

File tree

2 files changed

+4
-2
lines changed

2 files changed

+4
-2
lines changed

app/code/Magento/Review/i18n/en_US.csv

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -133,3 +133,5 @@ Summary,Summary
133133
Active,Active
134134
Inactive,Inactive
135135
"Please select one of each of the ratings above.","Please select one of each of the ratings above."
136+
star,star
137+
stars,stars

app/code/Magento/Review/view/frontend/templates/form.phtml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -40,9 +40,9 @@
4040
<label
4141
class="rating-<?= $block->escapeHtmlAttr($iterator) ?>"
4242
for="<?= $block->escapeHtmlAttr($_rating->getRatingCode()) ?>_<?= $block->escapeHtmlAttr($_option->getValue()) ?>"
43-
title="<?= $block->escapeHtmlAttr(__('%1 %2', $iterator, $iterator > 1 ? 'stars' : 'star')) ?>"
43+
title="<?= $block->escapeHtmlAttr(__('%1 %2', $iterator, $iterator > 1 ? __('stars') : __('star'))) ?>"
4444
id="<?= $block->escapeHtmlAttr($_rating->getRatingCode()) ?>_<?= $block->escapeHtmlAttr($_option->getValue()) ?>_label">
45-
<span><?= $block->escapeHtml(__('%1 %2', $iterator, $iterator > 1 ? 'stars' : 'star')) ?></span>
45+
<span><?= $block->escapeHtml(__('%1 %2', $iterator, $iterator > 1 ? __('stars') : __('star'))) ?></span>
4646
</label>
4747
<?php $iterator++; ?>
4848
<?php endforeach; ?>

0 commit comments

Comments
 (0)