MAGETWO-89675: Build Stabilization

Add product-ui-select JSUnit tests

Author: danmooney2

app/code/Magento/Catalog/view/adminhtml/web/js/components/product-ui-select.js

@@ -21,6 +21,15 @@ define([
         initialize: function () {
             this._super();
 
+            this.validateInitialValue();
+
+            return this;
+        },
+
+        /**
+         * Validate initial value actually exists
+         */
+        validateInitialValue: function () {
             if (this.value()) {
                 $.ajax({
                     url: this.validationUrl,
@@ -53,8 +62,6 @@ define([
             } else {
                 this.validationLoading(false);
             }
-
-            return this;
         },
 
         /** @inheritdoc */

dev/tests/js/jasmine/tests/app/code/Magento/Catalog/adminhtml/js/components/product-ui-select-test.js

@@ -0,0 +1,89 @@
+/**
+ * Copyright © Magento, Inc. All rights reserved.
+ * See COPYING.txt for license details.
+ */
+
+define([
+    'underscore',
+    'uiRegistry',
+    'Magento_Catalog/js/components/product-ui-select',
+    'ko',
+    'jquery'
+], function (_, registry, Constr, ko, $) {
+    'use strict';
+
+    describe('Magento_Catalog/js/components/product-ui-select', function () {
+        var obj,
+            jQueryMethodsOverridden = {};
+
+        beforeEach(function () {
+            obj = new Constr({
+                name: 'productUiSelect',
+                dataScope: '',
+                provider: 'provider',
+                options: [],
+                value: ''
+            });
+
+            jQueryMethodsOverridden = {};
+        });
+
+        afterEach(function () {
+            _.each(jQueryMethodsOverridden, function (value, key) {
+                $.fn[key] = value;
+            });
+        });
+
+        describe('"validateInitialValue" method', function () {
+            it('Should be defined', function () {
+                expect(obj.hasOwnProperty('validateInitialValue')).toBeDefined();
+            });
+
+            it('Should call not call ajax if value is empty', function () {
+                jQueryMethodsOverridden.ajax = $.ajax;
+                spyOn($, 'ajax');
+
+                spyOn(obj, 'validationLoading');
+                spyOn(obj, 'value').and.returnValue('');
+
+                expect(obj.validateInitialValue()).toBeUndefined();
+
+                expect($.ajax).not.toHaveBeenCalled();
+                expect(obj.validationLoading).toHaveBeenCalledWith(false);
+            });
+
+            it('Should call ajax if value is not empty', function () {
+                var successCallback,
+                    completeCallback,
+                    responseData = {
+                    label: 'hello world',
+                    value: 'hello world'
+                };
+
+                jQueryMethodsOverridden.ajax = $.ajax;
+                spyOn($, 'ajax').and.callFake(function (request) {
+                    successCallback = request.success.bind(obj);
+                    completeCallback = request.complete.bind(obj);
+                });
+
+                spyOn(obj, 'validationLoading');
+                spyOn(obj, 'value').and.returnValue('hello world');
+                spyOn(obj, 'options');
+                spyOn(obj, 'setCaption');
+
+                expect(obj.validateInitialValue()).toBeUndefined();
+
+                successCallback(responseData);
+                completeCallback();
+
+                expect($.ajax).toHaveBeenCalled();
+
+                expect(obj.validationLoading).toHaveBeenCalledWith(false);
+                expect(obj.loadedOption).toBe(responseData);
+                expect(obj.options).toHaveBeenCalledWith([responseData]);
+
+                expect(obj.setCaption).toHaveBeenCalled();
+            });
+        });
+    });
+});