Skip to content
This repository was archived by the owner on Apr 29, 2019. It is now read-only.

Approach to Implementation

Olga Kopylova edited this page Jan 4, 2018 · 2 revisions

Assumptions

  1. Both PHP 7.1 and 7.2 MUST be supported
  2. Builds on 2.3-develop branch are green at any given time

Technical Requirements to Fixes

  1. All fixes MUST follow:
  2. All builds for the PR MUST be green
    • Travis CI - visible for the community
    • Internal Magento builds - results provided by the Magento team, if there are any issues

Work Breakdown Structure

Fix Blockers

  1. Main tests are run on PHP 7.1 environment during this stage
    1. Additional tests are run on temporary branches to prove that a specific fix solves the issue. Such branch may have workarounds to bypass other issues. All workarounds MUST be applied o top of the branch with the fix, so that no fix is missed during the merge
  2. Make Composer pass environment requirements with PHP 7.2
    1. PHP requirements updated in composer.json to support 7.2
    2. Update 3rd-party libraries to support PHP 7.2

Fix Other Backwards Incompatible Issues

These include all issues NOT marked with deprecated or blocker labels.

Fix Issues Caused by Deprecated Functionality

These include all issues marked with deprecated label.

Clone this wiki locally