Fixed bug in quoteInto with $count parameter and question sign in $value

ivan-ponomarev · ivan-ponomarev · commit 7a4aa64235aa · 2014-11-13T14:17:37.000+06:00
diff --git a/library/Zend/Db/Adapter/Abstract.php b/library/Zend/Db/Adapter/Abstract.php
@@ -930,13 +930,7 @@ public function quoteInto($text, $value, $type = null, $count = null)
         if ($count === null) {
             return str_replace('?', $this->quote($value, $type), $text);
         } else {
-            while ($count > 0) {
-                if (strpos($text, '?') !== false) {
-                    $text = substr_replace($text, $this->quote($value, $type), strpos($text, '?'), 1);
-                }
-                --$count;
-            }
-            return $text;
+            return implode($this->quote($value, $type), explode('?', $text, $count));
         }
     }
 

Original file line number	Diff line number	Diff line change
`@@ -930,13 +930,7 @@ public function quoteInto($text, $value, $type = null, $count = null)`
`930`	`930`	`if ($count === null) {`
`931`	`931`	`return str_replace('?', $this->quote($value, $type), $text);`
`932`	`932`	`} else {`
`933`		`- while ($count > 0) {`
`934`		`- if (strpos($text, '?') !== false) {`
`935`		`- $text = substr_replace($text, $this->quote($value, $type), strpos($text, '?'), 1);`
`936`		`- }`
`937`		`- --$count;`
`938`		`- }`
`939`		`- return $text;`
	`933`	`+ return implode($this->quote($value, $type), explode('?', $text, $count));`
`940`	`934`	`}`
`941`	`935`	`}`
`942`	`936`