Merge pull request #11 from magento-engcom/deprecated-7.2-code

Remove PHP 7.2 Incompatible Code

Update or remove the following incompatible function calls:
- `each()`
- `create_function()`
- Calls to `count()` with un-countable values
- Removed `XmlRpc` component

Author: buskamuza

library/Zend/Cache/Backend.php

@@ -76,7 +76,7 @@ public function __construct(array $options = array())
     public function setDirectives($directives)
     {
         if (!is_array($directives)) Zend_Cache::throwException('Directives parameter must be an array');
-        while (list($name, $value) = each($directives)) {
+        foreach ($directives as $name => $value) {
             if (!is_string($name)) {
                 Zend_Cache::throwException("Incorrect option name : $name");
             }

library/Zend/Cache/Frontend/Page.php

@@ -395,7 +395,7 @@ protected function _makePartialId($arrayName, $bool1, $bool2)
             }
             return '';
         }
-        if (count($var) > 0) {
+        if (is_array($var) && count($var) > 0) {
             return false;
         }
         return '';

library/Zend/Config/Yaml.php

@@ -289,7 +289,7 @@ protected static function _decodeYaml($currentIndent, &$lines)
     {
         $config   = array();
         $inIndent = false;
-        while (list($n, $line) = each($lines)) {
+        foreach ($line as $n => $line) {
             $lineno = $n + 1;
 
             $line = rtrim(preg_replace("/#.*$/", "", $line));
@@ -362,11 +362,11 @@ protected static function _parseValue($value)
         $value = trim($value);
 
         // remove quotes from string.
-        if ('"' == $value['0']) {
-            if ('"' == $value[count($value) -1]) {
+        if ('"' == substr($value, 0, 1)) {
+            if ('"' == substr($value, -1)) {
                 $value = substr($value, 1, -1);
             }
-        } elseif ('\'' == $value['0'] && '\'' == $value[count($value) -1]) {
+        } elseif ('\'' == substr($value, 0, 1) && '\'' == substr($value, -1)) {
             $value = strtr($value, array("''" => "'", "'" => ''));
         }
 

library/Zend/Feed/Element.php

@@ -193,7 +193,7 @@ public function __get($var)
         if ($length == 1) {
             return new Zend_Feed_Element($nodes[0]);
         } elseif ($length > 1) {
-            return array_map(create_function('$e', 'return new Zend_Feed_Element($e);'), $nodes);
+            return array_map(function ($e) { return new Zend_Feed_Element($e); }, $nodes);
         } else {
             // When creating anonymous nodes for __set chaining, don't
             // call appendChild() on them. Instead we pass the current

library/Zend/Http/UserAgent/Features/Adapter/TeraWurfl.php

@@ -88,7 +88,7 @@ public static function getAllCapabilities(TeraWurfl $wurflObj)
             if (!is_array($group)) {
                 continue;
             }
-            while (list ($key, $value) = each($group)) {
+            foreach ($group as $key => $value) {
                 if (is_bool($value)) {
                     // to have the same type than the official WURFL API
                     $features[$key] = ($value ? 'true' : 'false');