Skip to content

Commit 05b6d24

Browse files
author
David Verholen
committed
Conflicts: README.md src/MagentoHackathon/Composer/Magento/Installer.php src/MagentoHackathon/Composer/Magento/Plugin.php src/MagentoHackathon/Composer/Magento/ProjectConfig.php tests/FullStackTest/home/composer.json tests/MagentoHackathon/Composer/Magento/FullStack/GlobalPluginTest.php
2 parents 646c320 + f6e6c2c commit 05b6d24

File tree

5 files changed

+46
-2
lines changed

5 files changed

+46
-2
lines changed

README.md

Lines changed: 27 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -40,6 +40,33 @@ other support contacts
4040
- Error message: `Fatal error: Call to undefined method MagentoHackathon\Composer\Magento\Installer::setDeployManager()` happens when you update from 1.x to 2.x, as we switched from pure installer to plugin.
4141

4242
Solution: remove the `vendor` directory and the `composer.lock` and do a fresh install.
43+
=======
44+
## Known issues
45+
46+
### When upgrading from 1.x to 2.x
47+
48+
The update from 1.x to 2.x has to be done with no plugins as otherwise a fatal error will be triggered (which does not hurt, just run the update again and it runs through).
49+
50+
- Error message: `Fatal error: Call to undefined method MagentoHackathon\Composer\Magento\Installer::setDeployManager()`
51+
52+
To prevent this error, upgrade only *magento-composer-installer* first:
53+
54+
```composer update --no-plugins --no-dev "magento-hackathon/magento-composer-installer"```
55+
56+
Fallback Solutions:
57+
58+
1. execute `composer install` two times.
59+
2. remove the `vendor` directory and `composer.lock` and do a fresh install.
60+
61+
### Timeouts and slow downloading.
62+
63+
Mostly caused by outtages of Github, Repositories or the Internet. This is a common problem with having all
64+
packges remote.
65+
66+
For all of this Issues you can make use of the commercial [Toran Proxy](https://toranproxy.com/).
67+
It also allows hosting of private packages and speeds up the whole downloading process.
68+
69+
Another alternative is to look into [Satis](https://github.com/composer/satis), bare git mirrors and repository aliasing.
4370

4471
## Usage
4572

composer.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -54,6 +54,7 @@
5454
"suggest":{
5555
"theseer/autoload": "~1.14",
5656
"zetacomponents/console-tools": "dev-master",
57+
"colinmollenhour/modman": "*",
5758
"magento-hackathon/composer-command-integrator":"*"
5859
},
5960
"autoload":{

doc/Mapping.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,9 +5,9 @@ Mapping
55

66
There are several ways how the mapping from files in the package into the Magento source is accomplished:
77

8-
1. [modman](https://github.com/colinmollenhour/modman) file
8+
1. A mapping in the composer.json
99
2. MagentoConnect package.xml file
10-
3. A mapping in the composer.json
10+
3. [modman](https://github.com/colinmollenhour/modman) file
1111

1212
As long as one of these mappings can be found, Magento modules are installable.
1313

tests/FullStackTest/home/composer.json

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,10 @@
1313
"magento-hackathon/magento-composer-installer": "*"
1414
},
1515
"extra": {
16+
<<<<<<< HEAD
1617
"magento-root-dir": "root"
18+
=======
19+
20+
>>>>>>> f6e6c2c58d5298e4f1388109ae09eec97482cd63
1721
}
1822
}

tests/MagentoHackathon/Composer/Magento/FullStack/GlobalPluginTest.php

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,11 @@ protected function prepareCleanDirectories()
3131
public function testGlobalInstall()
3232
{
3333
$process = new Process(
34+
<<<<<<< HEAD
3435
self::getComposerCommand().' global install ' . self::getComposerArgs(),
36+
=======
37+
self::getComposerCommand().' global install',
38+
>>>>>>> f6e6c2c58d5298e4f1388109ae09eec97482cd63
3539
self::getProjectRoot()
3640
);
3741
$process->setEnv( array('COMPOSER_HOME'=>self::getBasePath().'/home'));
@@ -44,7 +48,11 @@ public function testGlobalUpdate()
4448
{
4549

4650
$process = new Process(
51+
<<<<<<< HEAD
4752
self::getComposerCommand().' global update ' . self::getComposerArgs(),
53+
=======
54+
self::getComposerCommand().' global update',
55+
>>>>>>> f6e6c2c58d5298e4f1388109ae09eec97482cd63
4856
self::getProjectRoot()
4957
);
5058
$process->setEnv( array('COMPOSER_HOME'=>self::getBasePath().'/home'));
@@ -53,4 +61,8 @@ public function testGlobalUpdate()
5361
$this->assertProcess($process);
5462
}
5563

64+
<<<<<<< HEAD
5665
}
66+
=======
67+
}
68+
>>>>>>> f6e6c2c58d5298e4f1388109ae09eec97482cd63

0 commit comments

Comments
 (0)