Refactoring

Author: konarshankar07

…diaGalleryRenditionsApi/Model/Config.php MediaGalleryRenditions/Model/Config.phpMediaGalleryRenditionsApi/Model/Config.php renamed to MediaGalleryRenditions/Model/Config.php MediaGalleryRenditionsApi/Model/Config.php renamed to MediaGalleryRenditions/Model/Config.php

@@ -6,14 +6,15 @@
 
 declare(strict_types=1);
 
-namespace Magento\MediaGalleryRenditionsApi\Model;
+namespace Magento\MediaGalleryRenditions\Model;
 
 use Magento\Framework\App\Config\ScopeConfigInterface;
+use Magento\MediaGalleryRenditionsApi\Model\ConfigInterface;
 
 /**
  * Class responsible for providing access to Media Gallery Renditions system configuration.
  */
-class Config
+class Config implements ConfigInterface
 {
     /**
      * Config path for Media Gallery Renditions Width

MediaGalleryRenditionsApi/Model/ConfigInterface.php

@@ -0,0 +1,29 @@
+<?php
+/**
+ * Copyright © Magento, Inc. All rights reserved.
+ * See COPYING.txt for license details.
+ */
+
+declare(strict_types=1);
+
+namespace Magento\MediaGalleryRenditionsApi\Model;
+
+/**
+ * Class responsible for providing API access to Media Gallery Renditions system configuration
+ */
+interface ConfigInterface
+{
+    /**
+     * Get width value specified in Media Gallery Renditions
+     *
+     * @return int
+     */
+    public function getWidth(): int;
+
+    /**
+     * Get length value specified in Media Gallery Renditions
+     *
+     * @return int
+     */
+    public function getHeight(): int;
+}

MediaGallerySynchronization/Model/GenerateRenditionImages.php

@@ -0,0 +1,58 @@
+<?php
+/**
+ * Copyright © Magento, Inc. All rights reserved.
+ * See COPYING.txt for license details.
+ */
+declare(strict_types=1);
+
+namespace Magento\MediaGallerySynchronization\Model;
+
+use Magento\MediaGallerySynchronizationApi\Api\ImportFileInterface;
+use Magento\MediaGallerySynchronization\Model\Filesystem\SplFileInfoFactory;
+use Magento\MediaGalleryRenditionsApi\Api\GenerateRenditionsInterface;
+
+/**
+ * Generate Rendition Images
+ */
+class GenerateRenditionImages implements ImportFileInterface
+{
+    /**
+     * @var SplFileInfoFactory
+     */
+    private $splFileInfoFactory;
+
+    /**
+     * @var CreateAssetFromFile
+     */
+    private $createAssetFromFile;
+
+    /**
+     * @var GenerateRenditionsInterface
+     */
+    private $generateRenditions;
+
+    /**
+     * @param SplFileInfoFactory $splFileInfoFactory
+     * @param CreateAssetFromFile $createAssetFromFile
+     * @param GenerateRenditionsInterface $generateRenditions
+     */
+    public function __construct(
+        SplFileInfoFactory $splFileInfoFactory,
+        CreateAssetFromFile $createAssetFromFile,
+        GenerateRenditionsInterface $generateRenditions
+    ) {
+        $this->splFileInfoFactory = $splFileInfoFactory;
+        $this->createAssetFromFile = $createAssetFromFile;
+        $this->generateRenditions = $generateRenditions;
+    }
+
+    /**
+     * @inheritdoc
+     */
+    public function execute(string $path): void
+    {
+        $file = $this->splFileInfoFactory->create($path);
+        $createdAsset = $this->createAssetFromFile->execute($file);
+        $this->generateRenditions->execute([$createdAsset]);
+    }
+}

MediaGallerySynchronization/Model/ImportMediaAsset.php

@@ -10,7 +10,6 @@
 use Magento\MediaGallerySynchronizationApi\Api\ImportFileInterface;
 use Magento\MediaGalleryApi\Api\SaveAssetsInterface;
 use Magento\MediaGallerySynchronization\Model\Filesystem\SplFileInfoFactory;
-use Magento\MediaGalleryRenditionsApi\Api\GenerateRenditionsInterface;
 
 /**
  * Import image file to the media gallery asset table
@@ -32,27 +31,19 @@ class ImportMediaAsset implements ImportFileInterface
      */
     private $createAssetFromFile;
 
-    /**
-     * @var GenerateRenditionsInterface
-     */
-    private $generateRenditions;
-
     /**
      * @param SplFileInfoFactory $splFileInfoFactory
      * @param SaveAssetsInterface $saveAssets
      * @param CreateAssetFromFile $createAssetFromFile
-     * @param GenerateRenditionsInterface $generateRenditions
      */
     public function __construct(
         SplFileInfoFactory $splFileInfoFactory,
         SaveAssetsInterface $saveAssets,
-        CreateAssetFromFile $createAssetFromFile,
-        GenerateRenditionsInterface $generateRenditions
+        CreateAssetFromFile $createAssetFromFile
     ) {
         $this->splFileInfoFactory = $splFileInfoFactory;
         $this->saveAssets = $saveAssets;
         $this->createAssetFromFile = $createAssetFromFile;
-        $this->generateRenditions = $generateRenditions;
     }
 
     /**
@@ -61,8 +52,6 @@ public function __construct(
     public function execute(string $path): void
     {
         $file = $this->splFileInfoFactory->create($path);
-        $createdAsset = $this->createAssetFromFile->execute($file);
-        $this->saveAssets->execute([$createdAsset]);
-        $this->generateRenditions->execute([$createdAsset]);
+        $this->saveAssets->execute([$this->createAssetFromFile->execute($file)]);
     }
 }

MediaGallerySynchronization/composer.json

@@ -5,6 +5,7 @@
         "php": "~7.3.0||~7.4.0",
         "magento/framework": "*",
         "magento/module-media-gallery-api": "*",
+        "magento/module-media-gallery-renditions-api": "*",
         "magento/module-media-gallery-synchronization-api": "*",
         "magento/framework-message-queue": "*",
         "magento/module-media-gallery-metadata-api": "*"

MediaGallerySynchronization/etc/di.xml

@@ -15,6 +15,7 @@
             <argument name="importers" xsi:type="array">
                 <item name="0" xsi:type="object">Magento\MediaGallerySynchronization\Model\ImportMediaAsset</item>
                 <item name="1" xsi:type="object">Magento\MediaGallerySynchronization\Model\ImportImageFileKeywords</item>
+                <item name="generateRenditionImages" xsi:type="object">Magento\MediaGallerySynchronization\Model\GenerateRenditionImages</item>
             </argument>
         </arguments>
     </type>