Merge pull request #53 from magento-cia/MC-41844

Bugfixes

Author: sidolov

AdobeStockImage/Model/Storage/Save.php

@@ -11,6 +11,7 @@
 use Magento\Framework\App\Filesystem\DirectoryList;
 use Magento\Framework\Exception\AlreadyExistsException;
 use Magento\Framework\Exception\FileSystemException;
+use Magento\Framework\Exception\InputException;
 use Magento\Framework\Filesystem;
 use Magento\Framework\Filesystem\Driver\Https;
 use Magento\Framework\Filesystem\DriverInterface;
@@ -30,15 +31,23 @@ class Save
      */
     private $driver;
 
+    /**
+     * @var int|null
+     */
+    private $maxFileLength;
+
     /**
      * Storage constructor.
      * @param Filesystem $filesystem
      * @param Https $driver
+     * @param int|null $maxFileLength
      */
     public function __construct(
         Filesystem $filesystem,
-        Https $driver
+        Https $driver,
+        int $maxFileLength = null
     ) {
+        $this->maxFileLength = $maxFileLength ?: 255;
         $this->filesystem = $filesystem;
         $this->driver = $driver;
     }
@@ -51,10 +60,16 @@ public function __construct(
      * @return string
      * @throws AlreadyExistsException
      * @throws FileSystemException
+     * @throws InputException
      */
     public function execute(string $imageUrl, string $destinationPath = '') : string
     {
         $mediaDirectory = $this->filesystem->getDirectoryWrite(DirectoryList::MEDIA);
+        if (strlen($destinationPath) > $this->maxFileLength) {
+            throw new InputException(
+                __('Destination path is too long; must be %1 characters or less', $this->maxFileLength)
+            );
+        }
 
         if ($mediaDirectory->isExist($destinationPath)) {
             throw new AlreadyExistsException(__('Image with the same file name already exits.'));

AdobeStockImage/etc/di.xml

@@ -37,6 +37,7 @@
     <type name="Magento\AdobeStockImage\Model\Storage\Save">
         <arguments>
             <argument name="driver" xsi:type="object">Magento\Framework\Filesystem\Driver\Https</argument>
+            <argument name="maxFileLength" xsi:type="number">255</argument>
         </arguments>
     </type>
     <type name="Magento\AdobeStockImage\Model\GetRelatedImages">